Received-SPF: pass (google.com: domain of linux-wireless+bounces-4184-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <58ba855b78507a949244034262ba806bb6dfd0a1.camel@sipsolutions.net>
Subject: Re: [PATCH v2] wifi: rsi: fix endian conversions
From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, Siva Rebbagondla <siva8118@gmail.com>
Date: Wed, 28 Feb 2024 12:36:53 +0100
In-Reply-To: <170912015833.3742961.13610436136127981895.kvalo@kernel.org>
References: 
	<20240223115214.682fb94159fa.I576bbf9fe7ca2948dbe3e00c0fa0f37594e85046@changeid>
	 <170912015833.3742961.13610436136127981895.kvalo@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-02-28 at 11:36 +0000, Kalle Valo wrote:
> Johannes Berg <johannes@sipsolutions.net> wrote:
>=20
> > From: Johannes Berg <johannes.berg@intel.com>
> >=20
> > This really seems like a bug, endian conversions now happen
> > twice in this code.
> >=20
> > Note also that prior to the commit mentioned below, the code
> > was putting 16-bit values 0xBBAA as bytes "AA BB 00 00", and
> > the commit mentions making it work for 32-bit values and
> > makes no mention of fixing endian conversion; however, after
> > it, the bytes for 0xBBAA would now be "00 00 BB AA" on big
> > endian platforms.
> >=20
> > Remove one conversion to make sparse no longer warn.
> >=20
> > Not sure anyone can, has, or ever will use this on big endian
> > platforms though.
> >=20
> > Fixes: 0a60014b76f5 ("rsi: miscallaneous changes for 9116 and common")
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>=20
> Fails to apply, I guess because I had a patch for this warning earlier.
>=20

You did pretty much the same thing anyway, no need to do anything else.

johannes