Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp2609250rbb; Wed, 28 Feb 2024 07:12:31 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWAryebtYhsBqeQyQt75uj1VaHjWnkqQ1BwUYySu5OmrACOnCjoDVnqCGcD/1jL7zqdfZ1bJzc8sDaffO/loTbOWKev6VoKBFcURFUteQ== X-Google-Smtp-Source: AGHT+IGDEPhkH3yK4/ZRtqEanjdPF+j5J6RkoImwvKGXrzlweGihtQCvTwWY5XneedgwNdn4/wr0 X-Received: by 2002:ac8:5f06:0:b0:42d:d026:f1b2 with SMTP id x6-20020ac85f06000000b0042dd026f1b2mr15635426qta.14.1709133151634; Wed, 28 Feb 2024 07:12:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709133151; cv=pass; d=google.com; s=arc-20160816; b=o54kWVk9tI6tcXjWHCVTiiozpkAOrzGJKJM9i6mQP3LB+whNthkKBtb4wVAf2jAtBs p3phfDBAemE1CCdpBPL7mR9FymM4fbhiKg2QUQKQsXySH9tgRaY806x5dpqoBByCky/h m/Or5q1UYXN9goDLGdmJkpRE++qP3w/5lFPWNKxbzFNdIOvR5E4mXFI+htFJ+UKqmK3Q GyIYHpkS7nK7augdQhkQ9G9rClGoPVdC4UTW4CrcSHiFzRWuve1aKfVtnC0hb/bTZeCn TbsOmnNMPgWGNZZW4+mn/ccbBg3r7+BuwmeQJLQ68xl1gxlBY6t7SCU+60yut4kq2oCB +BLA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=M1R4APKky5KyG7CTqhi4cnxO0NMTC4XM+z7N5ZETRfk=; fh=YnEy5PrjHYeUDfIdlIr6Ue2YFmgnglwJGSsnfqsN+Is=; b=K83B/L6c+vJsHl/xplXER2hctxLVSSzmYI/KWw4etRboZMXHRE5MLGHuj7UoaGgh7M jhgXcAGgis4qupLFscP3uTtWwL9nhXIrRN7wfYekTHOuED2SexkbQmcTG+UzKDyC4wDK BOr0xk0gjP6S8zZld6xGuT5d7gHkwJbqaX+YtaGiIjD8zaDa5AYdWuLT7+hklUFVEqkq VYN26UalE4afP+Xhke4Q7T7uRPLCcRh4oZFEREelQNgDECktk9FUmEF9ZMWHxV3dijc7 NDos9+dY2qQXfvzqFldFlfEBT/kHqCyRAGtd2wG/ex4Aq1VQcsz6TK77ON4OjbGvrfMa ixiw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=TW+PDWyX; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-4203-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4203-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e25-20020ac84919000000b0042e6bb756c7si9303401qtq.650.2024.02.28.07.12.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 07:12:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-4203-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=TW+PDWyX; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-4203-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4203-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4CE651C21845 for ; Wed, 28 Feb 2024 15:12:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C3F0E15B0FD; Wed, 28 Feb 2024 15:12:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="TW+PDWyX" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66D3215AADD; Wed, 28 Feb 2024 15:12:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709133147; cv=none; b=gz2BWJ2NJvYQDa8tI1Oddk6zkgMtxfqU1WLlDDyfsYnjYomr3SLeK+fSVAS9cxDN2fj5kgkgacH8fvHcmxZU660oxESFPEQ6pAUmILqu6g55RPJB/9xzSad+6B4HyNP+51h/WmvTrMQvNvGdQ7QArJ0AqHrxhDf3Fqdj0s+jBYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709133147; c=relaxed/simple; bh=VtMS3cKkQZLDLI0a8kRR+IWw733AJddvCWUzj387QD4=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=pdxDXrK4qgxis1tyuspLaVSCmP9pb6ACwHJ1qftY+dcpcvzK9BAMmIkGZkWkf6Nu7EzazxjUhZaGZUuky6/uBUvcrqT4bGH0s0NubTtyhvVUC/pIM8ctHPfTZ25z5/XqA1kTT5FbbjloLmy6phqrUmLi6H98hWUdODwfG9kIpMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=TW+PDWyX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41SACk0S017571; Wed, 28 Feb 2024 15:12:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=M1R4APKky5KyG7CTqhi4cnxO0NMTC4XM+z7N5ZETRfk=; b=TW +PDWyX0BtG7PrQs8mZ1ziwZ5XKYzFZJ/mRqSd8wViWQ5oFQiBLa74ocC5GcZGLWE xPHmnQ0G7cKadi5slC0474YZKMV5K3f5qLADaqTVgs13p/NmRwFWq9PzOmPGpTRk ajlc8rVFft6yc+DuYM6wdQ/kMFtxAKORUwt7gchZF9LwFwBeG5sVN1IElbShX0pu jzw9cTFFDmkzwRMnEzDJPIEfi7Pi6zoiGwpyDa3B73Z7UGsivMA6SsD58LEDnTuk 1Zh+INcro/i7wGtYdRnQsv9MOjdyNyMXLJIVGIUvVSRa9v/1huPVQwwlP06WENrC ni/fR5L6LqLA9awpggoQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wj1d9ryph-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 15:12:15 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41SFCEdj020282 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 15:12:14 GMT Received: from [10.110.113.97] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 28 Feb 2024 07:12:14 -0800 Message-ID: Date: Wed, 28 Feb 2024 07:12:13 -0800 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] net: qrtr: support suspend/hibernation Content-Language: en-US To: Baochen Qiang , , CC: , , , , , , , References: <20240228022243.17762-1-quic_bqiang@quicinc.com> <20240228022243.17762-3-quic_bqiang@quicinc.com> From: Jeff Johnson In-Reply-To: <20240228022243.17762-3-quic_bqiang@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: dEm-2-uhJQ1ysMlIdUXYx5sdPC-SkLko X-Proofpoint-ORIG-GUID: dEm-2-uhJQ1ysMlIdUXYx5sdPC-SkLko X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-28_07,2024-02-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=753 mlxscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2402280120 On 2/27/2024 6:22 PM, Baochen Qiang wrote: > MHI devices may not be destroyed during suspend/hibernation, so need > to unprepare/prepare MHI channels throughout the transition, this is > done by adding suspend/resume callbacks. > > The suspend callback is called in the late suspend stage, this means > MHI channels are still alive at suspend stage, and that makes it > possible for an MHI controller driver to communicate with others over > those channels at suspend stage. While the resume callback is called > in the early resume stage, for a similar reason. > > Also note that we won't do unprepare/prepare when MHI device is in > suspend state because it's pointless if MHI is only meant to go through > a suspend/resume transition, instead of a complete power cycle. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30 > > Signed-off-by: Baochen Qiang Reviewed-by: Jeff Johnson