Received-SPF: pass (google.com: domain of linux-wireless+bounces-4213-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <17ff48b2-1f78-4eaf-b4ad-9dfeb5ea8620@lwfinger.net>
Date: Wed, 28 Feb 2024 13:02:02 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/4] wifi: rtw88: 8821c: Fix false alarm count
Content-Language: en-US
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Ping-Ke Shih <pkshih@realtek.com>
References: <909d9f75-44cd-4710-9d3f-56691fd58090@gmail.com>
 <38e3d94e-0cab-4a43-be10-c15ff5387919@gmail.com>
 <b908b9a7-e1fd-47ba-b573-ac11b334101b@lwfinger.net>
 <c68d2d91-fb81-41e2-b8a2-0eb63783311b@gmail.com>
From: Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <c68d2d91-fb81-41e2-b8a2-0eb63783311b@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2/28/24 03:57, Bitterblue Smith wrote:
> On 28/02/2024 00:46, Larry Finger wrote:
>> On 2/27/24 06:20, Bitterblue Smith wrote:
>>> Make dm_info->total_fa_cnt the sum of cck_fa_cnt and ofdm_fa_cnt,
>>> not just ofdm_fa_cnt.
>>>
>>> Fixes: 960361238b86 ("rtw88: 8821c: add false alarm statistics")
>>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>>> ---
>>>    drivers/net/wireless/realtek/rtw88/rtw8821c.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821c.c b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
>>> index 429bb420b056..fe5d8e188350 100644
>>> --- a/drivers/net/wireless/realtek/rtw88/rtw8821c.c
>>> +++ b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
>>> @@ -773,9 +773,9 @@ static void rtw8821c_false_alarm_statistics(struct rtw_dev *rtwdev)
>>>          dm_info->cck_fa_cnt = cck_fa_cnt;
>>>        dm_info->ofdm_fa_cnt = ofdm_fa_cnt;
>>> +    dm_info->total_fa_cnt = ofdm_fa_cnt;
>>>        if (cck_enable)
>>>            dm_info->total_fa_cnt += cck_fa_cnt;
>>> -    dm_info->total_fa_cnt = ofdm_fa_cnt;
>>>          crc32_cnt = rtw_read32(rtwdev, REG_CRC_CCK);
>>>        dm_info->cck_ok_cnt = FIELD_GET(GENMASK(15, 0), crc32_cnt);
>>
>> I applied these 4 patches to my rtw88 GitHub repo, and loaded rtw_core with the disable_lps_deep=y option. The option reduced the number of "firmware failed to leave lps state" messages, but did not eliminate all of them. The messages I received are as follows:
>>
>> [ 2063.847153] rtw_8821cu 3-6:1.0: firmware failed to leave lps state
>> [ 2450.120216] rtw_8821cu 3-6:1.0: timed out to flush queue 2
> 
> [...]
> 
>> [ 4323.823755] rtw_8821cu 3-6:1.0: firmware failed to leave lps state
>> [ 4453.846759] rtw_8821cu 3-6:1.0: firmware failed to leave lps state
>> [ 4455.822861] rtw_8821cu 3-6:1.0: firmware failed to leave lps state
>>
>> My system has now been up for about 4470 sec. Obviously these messages come in a burst.
>>
>> Larry
>>
> 
> I have never seen these. I guess you don't get these messages
> without the patches? Can you see which patch causes this, please?

Bitterblue,

These warnings are not new, but probably only happen for some models of 8821CU.

When I get time, I will try to see if I can quiet them,

Larry