Received-SPF: pass (google.com: domain of linux-wireless+bounces-4286-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Fiona Klute <fiona.klute@gmx.de>,
        "linux-wireless@vger.kernel.org"
	<linux-wireless@vger.kernel.org>
CC: "kvalo@kernel.org" <kvalo@kernel.org>,
        "ulf.hansson@linaro.org"
	<ulf.hansson@linaro.org>,
        "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>,
        "pavel@ucw.cz" <pavel@ucw.cz>, "megi@xff.cz"
	<megi@xff.cz>
Subject: RE: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
Thread-Topic: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
Thread-Index: AQHaadh8n611UJm6iUqkDrqnT0K/C7EiKLcw
Date: Fri, 1 Mar 2024 02:33:07 +0000
Message-ID: <3805850d51334319984bc304ca1dc3c4@realtek.com>
References: <20240227235507.781615-1-fiona.klute@gmx.de>
 <20240227235507.781615-6-fiona.klute@gmx.de>
In-Reply-To: <20240227235507.781615-6-fiona.klute@gmx.de>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0


> -----Original Message-----
> From: Fiona Klute <fiona.klute@gmx.de>
> Sent: Wednesday, February 28, 2024 7:55 AM
> To: linux-wireless@vger.kernel.org; Ping-Ke Shih <pkshih@realtek.com>
> Cc: Fiona Klute <fiona.klute@gmx.de>; kvalo@kernel.org; ulf.hansson@linar=
o.org; linux-mmc@vger.kernel.org;
> pavel@ucw.cz; megi@xff.cz
> Subject: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
>=20
> This is the main source for the new rtw88_8703b chip driver.
>=20
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> Tested-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
> ---
>  drivers/net/wireless/realtek/rtw88/rtw8703b.c | 2112 +++++++++++++++++
>  1 file changed, 2112 insertions(+)
>  create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8703b.c
>=20
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> new file mode 100644
> index 00000000000..83b1da60eb4
> --- /dev/null
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> @@ -0,0 +1,2112 @@
> +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
> +/* Copyright Fiona Klute <fiona.klute@gmx.de> */
> +
> +#include <linux/of_net.h>
> +#include "main.h"
> +#include "coex.h"
> +#include "debug.h"
> +#include "mac.h"
> +#include "phy.h"
> +#include "reg.h"
> +#include "rx.h"
> +#include "rtw8703b.h"
> +#include "rtw8703b_tables.h"
> +#include "rtw8723x.h"
> +
> +#define GET_RX_DESC_BW(rxdesc)                                          =
    \
> +       (le32_get_bits(*((__le32 *)(rxdesc) + 0x04), GENMASK(31, 24)))

Can we move this to rx.h GET_RX_DESC_xxx()?=20

> +
> +#define BIT_MASK_TXQ_INIT (BIT(7))
> +#define WLAN_RL_VAL 0x3030
> +/* disable BAR */
> +#define WLAN_BAR_VAL 0x0201ffff
> +#define WLAN_PIFS_VAL 0
> +#define WLAN_RX_PKT_LIMIT 0x18
> +#define WLAN_SLOT_TIME 0x09
> +#define WLAN_SPEC_SIFS 0x100a
> +#define WLAN_MAX_AGG_NR 0x1f
> +#define WLAN_AMPDU_MAX_TIME 0x70
> +
> +/* unit is 32us */
> +#define TBTT_PROHIBIT_SETUP_TIME 0x04
> +#define TBTT_PROHIBIT_HOLD_TIME 0x80
> +#define TBTT_PROHIBIT_HOLD_TIME_STOP_BCN 0x64
> +
> +/* raw pkt_stat->drv_info_sz is in unit of 8-bytes */
> +#define RX_DRV_INFO_SZ_UNIT_8703B 8
> +
> +#define TRANS_SEQ_END                  \
> +       {0xFFFF,                        \
> +        RTW_PWR_CUT_ALL_MSK,           \
> +        RTW_PWR_INTF_ALL_MSK,          \
> +        0,                             \
> +        RTW_PWR_CMD_END, 0, 0}

Move this macro to main.h along with RTW_PWR_CUT_ALL_MSK.

> +
> +static void rtw8703b_cfg_notch(struct rtw_dev *rtwdev, u8 channel, bool =
notch)
> +{
> +       if (!notch) {
> +               rtw_write32_mask(rtwdev, REG_OFDM0_RXDSP, BIT_MASK_RXDSP,=
 0x1f);
> +               rtw_write32_mask(rtwdev, REG_OFDM0_RXDSP, BIT_EN_RXDSP, 0=
x0);
> +               rtw_write32(rtwdev, REG_OFDM1_CSI1, 0x00000000);
> +               rtw_write32(rtwdev, REG_OFDM1_CSI2, 0x00000000);
> +               rtw_write32(rtwdev, REG_OFDM1_CSI3, 0x00000000);
> +               rtw_write32(rtwdev, REG_OFDM1_CSI4, 0x00000000);
> +               rtw_write32_mask(rtwdev, REG_OFDM1_CFOTRK, BIT_EN_CFOTRK,=
 0x0);
> +               return;
> +       }
> +
> +       switch (channel) {
> +       case 5:
> +               fallthrough;

no need fallthrough unless you do something by case 5.

> +       case 13:
> +               rtw_write32_mask(rtwdev, REG_OFDM0_RXDSP, BIT_MASK_RXDSP,=
 0xb);
> +               rtw_write32_mask(rtwdev, REG_OFDM0_RXDSP, BIT_EN_RXDSP, 0=
x1);
> +               rtw_write32(rtwdev, REG_OFDM1_CSI1, 0x06000000);
> +               rtw_write32(rtwdev, REG_OFDM1_CSI2, 0x00000000);
> +               rtw_write32(rtwdev, REG_OFDM1_CSI3, 0x00000000);
> +               rtw_write32(rtwdev, REG_OFDM1_CSI4, 0x00000000);
> +               rtw_write32_mask(rtwdev, REG_OFDM1_CFOTRK, BIT_EN_CFOTRK,=
 0x1);
> +               break;

[...]