Received-SPF: pass (google.com: domain of linux-wireless+bounces-4289-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Ping-Ke Shih <pkshih@realtek.com>, Fiona Klute <fiona.klute@gmx.de>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
CC: "kvalo@kernel.org" <kvalo@kernel.org>,
        "ulf.hansson@linaro.org"
	<ulf.hansson@linaro.org>,
        "linux-mmc@vger.kernel.org"
	<linux-mmc@vger.kernel.org>,
        "pavel@ucw.cz" <pavel@ucw.cz>, "megi@xff.cz"
	<megi@xff.cz>
Subject: RE: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
Thread-Topic: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
Thread-Index: AQHaadh8n611UJm6iUqkDrqnT0K/C7EiKLcwgAAmtxA=
Date: Fri, 1 Mar 2024 04:36:08 +0000
Message-ID: <4fc45b4289d747dd80f76dcacef3c54d@realtek.com>
References: <20240227235507.781615-1-fiona.klute@gmx.de>
 <20240227235507.781615-6-fiona.klute@gmx.de>
 <3805850d51334319984bc304ca1dc3c4@realtek.com>
In-Reply-To: <3805850d51334319984bc304ca1dc3c4@realtek.com>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0


> -----Original Message-----
> From: Ping-Ke Shih <pkshih@realtek.com>
> Sent: Friday, March 1, 2024 10:33 AM
> To: Fiona Klute <fiona.klute@gmx.de>; linux-wireless@vger.kernel.org
> Cc: kvalo@kernel.org; ulf.hansson@linaro.org; linux-mmc@vger.kernel.org; =
pavel@ucw.cz; megi@xff.cz
> Subject: RE: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
>=20
>=20
>=20
> > -----Original Message-----
> > From: Fiona Klute <fiona.klute@gmx.de>
> > Sent: Wednesday, February 28, 2024 7:55 AM
> > To: linux-wireless@vger.kernel.org; Ping-Ke Shih <pkshih@realtek.com>
> > Cc: Fiona Klute <fiona.klute@gmx.de>; kvalo@kernel.org; ulf.hansson@lin=
aro.org;
> linux-mmc@vger.kernel.org;
> > pavel@ucw.cz; megi@xff.cz
> > Subject: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
> >
> > +
> > +#define TRANS_SEQ_END                  \
> > +       {0xFFFF,                        \
> > +        RTW_PWR_CUT_ALL_MSK,           \
> > +        RTW_PWR_INTF_ALL_MSK,          \
> > +        0,                             \
> > +        RTW_PWR_CMD_END, 0, 0}
>=20
> Move this macro to main.h along with RTW_PWR_CUT_ALL_MSK.

Think of this again, I prefer removing braces
#define TRANS_SEQ_END			\
	 0xFFFF,			\
	 RTW_PWR_CUT_ALL_MSK,		\
	 RTW_PWR_INTF_ALL_MSK,		\
	 0,				\
	 RTW_PWR_CMD_END, 0, 0

Then, consumers look like

static const struct rtw_pwr_seq_cmd trans_carddis_to_cardemu_8703b[] =3D {
	{0x0005,
	 RTW_PWR_CUT_ALL_MSK,
	 RTW_PWR_INTF_ALL_MSK,
	 RTW_PWR_ADDR_MAC,
	 RTW_PWR_CMD_WRITE, BIT(7), 0},
	{TRANS_SEQ_END},  // <=3D=3D=3D This one will be consistent with others.
};

Ping-Ke