Received-SPF: pass (google.com: domain of linux-wireless+bounces-4303-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7b860e34-705b-43d9-9e61-cefdd768ccd1@gmx.de>
Date: Fri, 1 Mar 2024 17:54:37 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
Content-Language: de-DE, en-US
To: Ping-Ke Shih <pkshih@realtek.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
 "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
 "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
 "pavel@ucw.cz" <pavel@ucw.cz>, "megi@xff.cz" <megi@xff.cz>
References: <20240227235507.781615-1-fiona.klute@gmx.de>
 <20240227235507.781615-6-fiona.klute@gmx.de>
 <3805850d51334319984bc304ca1dc3c4@realtek.com>
 <4fc45b4289d747dd80f76dcacef3c54d@realtek.com>
From: Fiona Klute <fiona.klute@gmx.de>
Autocrypt: addr=fiona.klute@gmx.de; keydata=
 xsFNBFrLsicBEADA7Px5KipL9zM7AVkZ6/U4QaWQyxhqim6MX88TxZ6KnqFiTSmevecEWbls
 ppqPES8FiSl+M00Xe5icsLsi4mkBujgbuSDiugjNyqeOH5iqtg69xTd/r5DRMqt0K93GzmIj
 7ipWA+fomAMyX9FK3cHLBgoSLeb+Qj28W1cH94NGmpKtBxCkKfT+mjWvYUEwVdviMymdCAJj
 Iabr/QJ3KVZ7UPWr29IJ9Dv+SwW7VRjhXVQ5IwSBMDaTnzDOUILTxnHptB9ojn7t6bFhub9w
 xWXJQCsNkp+nUDESRwBeNLm4G5D3NFYVTg4qOQYLI/k/H1N3NEgaDuZ81NfhQJTIFVx+h0eT
 pjuQ4vATShJWea6N7ilLlyw7K81uuQoFB6VcG5hlAQWMejuHI4UBb+35r7fIFsy95ZwjxKqE
 QVS8P7lBKoihXpjcxRZiynx/Gm2nXm9ZmY3fG0fuLp9PQK9SpM9gQr/nbqguBoRoiBzONM9H
 pnxibwqgskVKzunZOXZeqyPNTC63wYcQXhidWxB9s+pBHP9FR+qht//8ivI29aTukrj3WWSU
 Q2S9ejpSyELLhPT9/gbeDzP0dYdSBiQjfd5AYHcMYQ0fSG9Tb1GyMsvh4OhTY7QwDz+1zT3x
 EzB0I1wpKu6m20C7nriWnJTCwXE6XMX7xViv6h8ev+uUHLoMEwARAQABzSBGaW9uYSBLbHV0
 ZSA8ZmlvbmEua2x1dGVAZ214LmRlPsLBlAQTAQgAPgIbIwULCQgHAwUVCgkICwUWAgMBAAIe
 AQIXgBYhBOTTE4/i2fL6gVL9ke6nJs4hI1pYBQJkNTaZBQkNK+tyAAoJEO6nJs4hI1pY3qwQ
 AKdoJJHZpRu+C0hd10k6bcn5dr8ibqgsMHBJtFJuGylEsgF9ipWz1rMDWDbGVrL1jXywfwpR
 WSeFzCleJq4D0hZ5n+u+zb3Gy8fj/o3K/bXriam9kR4GfMVUATG5m9lBudrrWAdI1qlWxnmP
 WUvRSlAlA++de7mw15guDiYlIl0QvWWFgY+vf0lR2bQirmra645CDlnkrEVJ3K/UZGB0Yx67
 DfIGQswEQhnKlyv0t2VAXj96MeYmz5a7WxHqw+/8+ppuT6hfNnO6p8dUCJGx7sGGN0hcO0jN
 kDmX7NvGTEpGAbSQuN2YxtjYppKQYF/macmcwm6q17QzXyoQahhevntklUsXH9VWX3Q7mIli
 jMivx6gEa5s9PsXSYkh9e6LhRIAUpnlqGtedpozaAdfzUWPz2qkMSdaRwvsQ27z5oFZ0dCOV
 Od39G1/bWlY+104Dt7zECn3NBewzJvhHAqmAoIRKbYqRGkwTTAVNzAgx+u72PoO5/SaOrTqd
 PIsW5+d/qlrQ49LwwxG8YYdynNZfqlgc90jls+n+l3tf35OQiehVYvXFqbY7RffUk39JtjwC
 MfKqZgBTjNAHYgb+dSa7oWI8q6l26hdjtqZG+OmOZEQIZp+qLNnb0j781S59NhEVBYwZAujL
 hLJgYGgcQ/06orkrVJl7DICPoCU/bLUO8dbfzsFNBGQ1Nr0BEADTlcWyLC5GoRfQoYsgyPgO
 Z4ANz31xoQf4IU4i24b9oC7BBFDE+WzfsK5hNUqLADeSJo5cdTCXw5Vw3eSSBSoDP0Q9OUdi
 PNEbbblZ/tSaLadCm4pyh1e+/lHI4j2TjKmIO4vw0K59Kmyv44mW38KJkLmGuZDg5fHQrA9G
 4oZLnBUBhBQkPQvcbwImzWWuyGA+jDEoE2ncmpWnMHoc4Lzpn1zxGNQlDVRUNnRCwkeclm55
 Dz4juffDWqWcC2NrY5KkjZ1+UtPjWMzRKlmItYlHF1vMqdWAskA6QOJNE//8TGsBGAPrwD7G
 cv4RIesk3Vl2IClyZWgJ67pOKbLhu/jz5x6wshFhB0yleOp94I/MY8OmbgdyVpnO7F5vqzb1
 LRmfSPHu0D8zwDQyg3WhUHVaKQ54TOmZ0Sjl0cTJRZMyOmwRZUEawel6ITgO+QQS147IE7uh
 Wa6IdWKNQ+LGLocAlTAi5VpMv+ne15JUsMQrHTd03OySOqtEstZz2FQV5jSS1JHivAmfH0xG
 fwxY6aWLK2PIFgyQkdwWJHIaacj0Vg6Kc1/IWIrM0m3yKQLJEaL5WsCv7BRfEtd5SEkl9wDI
 pExHHdTplCI9qoCmiQPYaZM5uPuirA5taUCJEmW9moVszl6nCdBesG2rgH5mvgPCMAwsPOz9
 7n+uBiMk0ZSyTQARAQABwsF8BBgBCAAmFiEE5NMTj+LZ8vqBUv2R7qcmziEjWlgFAmQ1Nr0C
 GwwFCQPCZwAACgkQ7qcmziEjWlgY/w//Y4TYQCWQ5eWuIbGCekeXFy8dSuP+lhhvDRpOCqKt
 Wd9ywr4j6rhxdS7FIcaSLZa6IKrpypcURLXRG++bfqm9K+0HDnDHEVpaVOn7SfLaPUZLD288
 y8rOce3+iW3x50qtC7KCS+7mFaWN+2hrAFkLSkHWIywiNfkys0QQ+4pZxKovIORun+HtsZFr
 pBfZzHtXx1K9KsPq9qVjRbKdCQliRvAukIeTXxajOKHloi8yJosVMBWoIloXALjwCJPR1pBK
 E9lDhI5F5y0YEd1E8Hamjsj35yS44zCd/NMnYUMUm+3IGvX1GT23si0H9wI/e4p3iNU7n0MM
 r9aISP5j5U+qUz+HRrLLJR7pGut/kprDe2r3b00/nttlWyuRSm+8+4+pErj8l7moAMNtKbIX
 RQTOT31dfRQRDQM2E35nXMh0Muw2uUJrldrBBPwjK2YQKklpTPTomxPAnYRY8LVVCwwPy8Xx
 MCTaUC2HWAAsiG90beT7JkkKKgMLS9DxmX9BN5Cm18Azckexy+vMg79LCcfw/gocQ4+lQn4/
 3BjqSuHfj+dXG+qcQ9pgB5+4/812hHog78dKT2r8l3ax3mHZCDTAC9Ks3LQU9/pMBm6K6nnL
 a4ASpGZSg2zLGIT0gnzi5h8EcIu9J1BFq6zRPZIjxBlhswF6J0BXjlDVe/3JzmeTTts=
In-Reply-To: <4fc45b4289d747dd80f76dcacef3c54d@realtek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:mtEZIwzA0a8=;Q2O80z9l2Lkl7qp5XTsQKfdWarX
 IFL9Cz7aZBdBTIBFWKmb/dO6sLaqJMhNNUqLA7+lIBEhN+I6gEHhzs5/DuhwlEesR0gB++dDA
 TAB8qO4HG4/JKyih40wbHuh3gpqfB2klHHM7YNVSz01urHQl1xR7jqyUugfEIG7XRzJBrC5KR
 mhDQBe6Fmu35L+5Mmi3bVR0GNQ7YnlMhYjux0EqKjFl3b4jRVtj2+NW/D+Vmew4uQLMGJU8vx
 G1ZVMqnbryRq7fB0eX5SFLOsFlqLgrzXKwi5bc9SIbebmpveTMRhVoJ3cjp7sy/ouWlIx/QlD
 zJZMnG2t00c+NUYWYlP0GWAggvY+MEjmRs7JTRPt8/DMabZFla+oZs4FWjgJMglCmWS4/wsYY
 MOL2L/XjyXcem6XR2ZWkRFJUloEzG0TOwnjkXuq3m20HHr6oHr4BpWEejPLu+7ZW6O1c0oFqs
 kRaM1Zd9vMGaRtZKq4M8WiLFYnNU4D6227SbcmxV+plRpT4fQ9xiOD/WAg1mfIjsOsUx8aQrD
 N07j0WGfKALn421o4yQudIidm1fl8ftHcrIHrcQjAvRktHnf9TKWa0Mfzhnl3KbhIIIbn215C
 ARi3nP1nHvRkCV3pbC6l/RbFHVDiXbpmn4BH5/ELAitMKTE32WI6nEWc5+XJ5qIrNzTpjWjAV
 8tgDT8TNY646FMF4hNVdQ2XB7dvEvWVf28j9d9UAGJ+Rck9D/91KVUkXfvn2lOkdy/0RWINvi
 sZ8/Fjs8ELjReIWGAGKiLWHzqfRfO7EadQfSb/9504dzadVDV0Q1/nCyJ0+NN9WJd9o58o5iV
 +wZvGEOFGbj0+1p0nkVBj1OWkaCoiFFFXUiEQivgao3Oo=

Am 01.03.24 um 05:36 schrieb Ping-Ke Shih:
>> -----Original Message-----
>> From: Ping-Ke Shih <pkshih@realtek.com>
>> Sent: Friday, March 1, 2024 10:33 AM
>> To: Fiona Klute <fiona.klute@gmx.de>; linux-wireless@vger.kernel.org
>> Cc: kvalo@kernel.org; ulf.hansson@linaro.org; linux-mmc@vger.kernel.org=
; pavel@ucw.cz; megi@xff.cz
>> Subject: RE: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
>>
>>
>>
>>> -----Original Message-----
>>> From: Fiona Klute <fiona.klute@gmx.de>
>>> Sent: Wednesday, February 28, 2024 7:55 AM
>>> To: linux-wireless@vger.kernel.org; Ping-Ke Shih <pkshih@realtek.com>
>>> Cc: Fiona Klute <fiona.klute@gmx.de>; kvalo@kernel.org; ulf.hansson@li=
naro.org;
>> linux-mmc@vger.kernel.org;
>>> pavel@ucw.cz; megi@xff.cz
>>> Subject: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
>>>
>>> +
>>> +#define TRANS_SEQ_END                  \
>>> +       {0xFFFF,                        \
>>> +        RTW_PWR_CUT_ALL_MSK,           \
>>> +        RTW_PWR_INTF_ALL_MSK,          \
>>> +        0,                             \
>>> +        RTW_PWR_CMD_END, 0, 0}
>>
>> Move this macro to main.h along with RTW_PWR_CUT_ALL_MSK.
>
> Think of this again, I prefer removing braces
> #define TRANS_SEQ_END			\
> 	 0xFFFF,			\
> 	 RTW_PWR_CUT_ALL_MSK,		\
> 	 RTW_PWR_INTF_ALL_MSK,		\
> 	 0,				\
> 	 RTW_PWR_CMD_END, 0, 0

Okay, will do that. And it gets rid of the odd "tab plus space" indent
for most of the definition. :-)