Received-SPF: pass (google.com: domain of linux-wireless+bounces-4301-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <da4b13d0-fe4f-4aec-8dfa-e64a5959387e@gmx.de>
Date: Fri, 1 Mar 2024 17:46:54 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 7/9] wifi: rtw88: Add rtw8703b_tables.c
Content-Language: de-DE, en-US
To: Ping-Ke Shih <pkshih@realtek.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
 "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
 "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
 "pavel@ucw.cz" <pavel@ucw.cz>, "megi@xff.cz" <megi@xff.cz>
References: <20240227235507.781615-1-fiona.klute@gmx.de>
 <20240227235507.781615-8-fiona.klute@gmx.de>
 <9ee0cb2bd7694e0da8f0576da6a182b5@realtek.com>
From: Fiona Klute <fiona.klute@gmx.de>
Autocrypt: addr=fiona.klute@gmx.de; keydata=
 xsFNBFrLsicBEADA7Px5KipL9zM7AVkZ6/U4QaWQyxhqim6MX88TxZ6KnqFiTSmevecEWbls
 ppqPES8FiSl+M00Xe5icsLsi4mkBujgbuSDiugjNyqeOH5iqtg69xTd/r5DRMqt0K93GzmIj
 7ipWA+fomAMyX9FK3cHLBgoSLeb+Qj28W1cH94NGmpKtBxCkKfT+mjWvYUEwVdviMymdCAJj
 Iabr/QJ3KVZ7UPWr29IJ9Dv+SwW7VRjhXVQ5IwSBMDaTnzDOUILTxnHptB9ojn7t6bFhub9w
 xWXJQCsNkp+nUDESRwBeNLm4G5D3NFYVTg4qOQYLI/k/H1N3NEgaDuZ81NfhQJTIFVx+h0eT
 pjuQ4vATShJWea6N7ilLlyw7K81uuQoFB6VcG5hlAQWMejuHI4UBb+35r7fIFsy95ZwjxKqE
 QVS8P7lBKoihXpjcxRZiynx/Gm2nXm9ZmY3fG0fuLp9PQK9SpM9gQr/nbqguBoRoiBzONM9H
 pnxibwqgskVKzunZOXZeqyPNTC63wYcQXhidWxB9s+pBHP9FR+qht//8ivI29aTukrj3WWSU
 Q2S9ejpSyELLhPT9/gbeDzP0dYdSBiQjfd5AYHcMYQ0fSG9Tb1GyMsvh4OhTY7QwDz+1zT3x
 EzB0I1wpKu6m20C7nriWnJTCwXE6XMX7xViv6h8ev+uUHLoMEwARAQABzSBGaW9uYSBLbHV0
 ZSA8ZmlvbmEua2x1dGVAZ214LmRlPsLBlAQTAQgAPgIbIwULCQgHAwUVCgkICwUWAgMBAAIe
 AQIXgBYhBOTTE4/i2fL6gVL9ke6nJs4hI1pYBQJkNTaZBQkNK+tyAAoJEO6nJs4hI1pY3qwQ
 AKdoJJHZpRu+C0hd10k6bcn5dr8ibqgsMHBJtFJuGylEsgF9ipWz1rMDWDbGVrL1jXywfwpR
 WSeFzCleJq4D0hZ5n+u+zb3Gy8fj/o3K/bXriam9kR4GfMVUATG5m9lBudrrWAdI1qlWxnmP
 WUvRSlAlA++de7mw15guDiYlIl0QvWWFgY+vf0lR2bQirmra645CDlnkrEVJ3K/UZGB0Yx67
 DfIGQswEQhnKlyv0t2VAXj96MeYmz5a7WxHqw+/8+ppuT6hfNnO6p8dUCJGx7sGGN0hcO0jN
 kDmX7NvGTEpGAbSQuN2YxtjYppKQYF/macmcwm6q17QzXyoQahhevntklUsXH9VWX3Q7mIli
 jMivx6gEa5s9PsXSYkh9e6LhRIAUpnlqGtedpozaAdfzUWPz2qkMSdaRwvsQ27z5oFZ0dCOV
 Od39G1/bWlY+104Dt7zECn3NBewzJvhHAqmAoIRKbYqRGkwTTAVNzAgx+u72PoO5/SaOrTqd
 PIsW5+d/qlrQ49LwwxG8YYdynNZfqlgc90jls+n+l3tf35OQiehVYvXFqbY7RffUk39JtjwC
 MfKqZgBTjNAHYgb+dSa7oWI8q6l26hdjtqZG+OmOZEQIZp+qLNnb0j781S59NhEVBYwZAujL
 hLJgYGgcQ/06orkrVJl7DICPoCU/bLUO8dbfzsFNBGQ1Nr0BEADTlcWyLC5GoRfQoYsgyPgO
 Z4ANz31xoQf4IU4i24b9oC7BBFDE+WzfsK5hNUqLADeSJo5cdTCXw5Vw3eSSBSoDP0Q9OUdi
 PNEbbblZ/tSaLadCm4pyh1e+/lHI4j2TjKmIO4vw0K59Kmyv44mW38KJkLmGuZDg5fHQrA9G
 4oZLnBUBhBQkPQvcbwImzWWuyGA+jDEoE2ncmpWnMHoc4Lzpn1zxGNQlDVRUNnRCwkeclm55
 Dz4juffDWqWcC2NrY5KkjZ1+UtPjWMzRKlmItYlHF1vMqdWAskA6QOJNE//8TGsBGAPrwD7G
 cv4RIesk3Vl2IClyZWgJ67pOKbLhu/jz5x6wshFhB0yleOp94I/MY8OmbgdyVpnO7F5vqzb1
 LRmfSPHu0D8zwDQyg3WhUHVaKQ54TOmZ0Sjl0cTJRZMyOmwRZUEawel6ITgO+QQS147IE7uh
 Wa6IdWKNQ+LGLocAlTAi5VpMv+ne15JUsMQrHTd03OySOqtEstZz2FQV5jSS1JHivAmfH0xG
 fwxY6aWLK2PIFgyQkdwWJHIaacj0Vg6Kc1/IWIrM0m3yKQLJEaL5WsCv7BRfEtd5SEkl9wDI
 pExHHdTplCI9qoCmiQPYaZM5uPuirA5taUCJEmW9moVszl6nCdBesG2rgH5mvgPCMAwsPOz9
 7n+uBiMk0ZSyTQARAQABwsF8BBgBCAAmFiEE5NMTj+LZ8vqBUv2R7qcmziEjWlgFAmQ1Nr0C
 GwwFCQPCZwAACgkQ7qcmziEjWlgY/w//Y4TYQCWQ5eWuIbGCekeXFy8dSuP+lhhvDRpOCqKt
 Wd9ywr4j6rhxdS7FIcaSLZa6IKrpypcURLXRG++bfqm9K+0HDnDHEVpaVOn7SfLaPUZLD288
 y8rOce3+iW3x50qtC7KCS+7mFaWN+2hrAFkLSkHWIywiNfkys0QQ+4pZxKovIORun+HtsZFr
 pBfZzHtXx1K9KsPq9qVjRbKdCQliRvAukIeTXxajOKHloi8yJosVMBWoIloXALjwCJPR1pBK
 E9lDhI5F5y0YEd1E8Hamjsj35yS44zCd/NMnYUMUm+3IGvX1GT23si0H9wI/e4p3iNU7n0MM
 r9aISP5j5U+qUz+HRrLLJR7pGut/kprDe2r3b00/nttlWyuRSm+8+4+pErj8l7moAMNtKbIX
 RQTOT31dfRQRDQM2E35nXMh0Muw2uUJrldrBBPwjK2YQKklpTPTomxPAnYRY8LVVCwwPy8Xx
 MCTaUC2HWAAsiG90beT7JkkKKgMLS9DxmX9BN5Cm18Azckexy+vMg79LCcfw/gocQ4+lQn4/
 3BjqSuHfj+dXG+qcQ9pgB5+4/812hHog78dKT2r8l3ax3mHZCDTAC9Ks3LQU9/pMBm6K6nnL
 a4ASpGZSg2zLGIT0gnzi5h8EcIu9J1BFq6zRPZIjxBlhswF6J0BXjlDVe/3JzmeTTts=
In-Reply-To: <9ee0cb2bd7694e0da8f0576da6a182b5@realtek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:KJNbZnyJyzQ=;mrj2NsQU8iTJG6YhvV/BSlqQsMu
 SsETvPqWrCAPFbuIeIm8BVkGjMTYrr228vJTYYxPhtY9frNQfDHigAjm3c0s/QPbRPQXZakTg
 VE3fUBxLkPt/lmKPsbZwTLIJ+PXc9QHvg5xs98p90J+VyJSCuwTZX7DgkWZAmh/sh10/fLBzZ
 5fEfpQIriOJ1XfrUBjHckXLM4gwd3HnqjYdsb8JsRUZeQh/xUeCgVrmbecQcFMNwm9a2HzZNi
 zCbDodk+XpkumTpAIQqVb9A9B9r6dEfBAuVlm1ziI0yp2I7OvLjDmRd3zgca0kjaLsKC6KWPP
 MqiuQtwOL0OfhUWxGqoCxStquiWbVKIPww6Po3r9jhokcB6BfFPKhyboJL+KKmIH13MH2ktnn
 JohhslP0l77prOX3S3pNbMA3P/AzRFa/7Cywf5C/D43zVHvxKmVjD/05zvOR3DQXgmxJ95+ke
 XjcyDw8ayzvxX6NkO36UjcC+/B+geI3Le05zI8vGa4vWN1Ej8aLPRaNxJ8xZmkEqYs4f2Mt5N
 eMiGjhkR1YgR9oiHBIpMusSRs462FVUCP/Pi16R4KbmUZ8IewWWFHPco5NorL/94PXHiI3+dS
 NZMkTESxg1KkQfjHvp/A8Y0afv164ngyiRvBxAMzFU37Oxex5dqCOIDWRaTHIUkGDaXNN9eVA
 Vk61JPEC4tkQccJZsgSQqYIDcdQMF8glX5wFrV7EXcO046Nq8oVxRHgqcHqFuYTl/eCKFuhnr
 m7YyNmCFmRDo3v+NnrdzXwbwvM0rfHrabCEYfbgx6KhHGNjSWR55BVpRZM0Xi5k7QBgMSiIED
 YZbEi6SegQQyxVkNk+buO2Xz9AxrjyVSXaNCi8yUEA8eA=

Am 01.03.24 um 03:36 schrieb Ping-Ke Shih:
>
>
>> -----Original Message-----
>> From: Fiona Klute <fiona.klute@gmx.de>
>> Sent: Wednesday, February 28, 2024 7:55 AM
>> To: linux-wireless@vger.kernel.org; Ping-Ke Shih <pkshih@realtek.com>
>> Cc: Fiona Klute <fiona.klute@gmx.de>; kvalo@kernel.org; ulf.hansson@lin=
aro.org; linux-mmc@vger.kernel.org;
>> pavel@ucw.cz; megi@xff.cz
>> Subject: [PATCH v2 7/9] wifi: rtw88: Add rtw8703b_tables.c
>>
>> Initialization tables for rtw8703b: Initial register values and TX
>> power limits.
>>
>> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>> Tested-by: Pavel Machek <pavel@ucw.cz>
>> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
>> ---
>>   .../wireless/realtek/rtw88/rtw8703b_tables.c  | 901 +++++++++++++++++=
+
>>   1 file changed, 901 insertions(+)
>>   create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8703b_tables=
.c
>>
>> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8703b_tables.c
>> b/drivers/net/wireless/realtek/rtw88/rtw8703b_tables.c
>> new file mode 100644
>> index 00000000000..6ece407d560
>> --- /dev/null
>> +++ b/drivers/net/wireless/realtek/rtw88/rtw8703b_tables.c
>> @@ -0,0 +1,901 @@
>> +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
>> +/* Copyright Fiona Klute <fiona.klute@gmx.de> */
>> +
>> +#include "main.h"
>> +#include "phy.h"
>
> include " rtw8703b_tables.h" to avoid sparse warnings:
>
> drivers/net/wireless/realtek/rtw88/rtw8703b_tables.c:16:1: warning: symb=
ol 'rtw8703b_bb_pg_tbl' was not declared. Should it be static?
> drivers/net/wireless/realtek/rtw88/rtw8703b_tables.c:194:1: warning: sym=
bol 'rtw8703b_txpwr_lmt_tbl' was not declared. Should it be static?
> drivers/net/wireless/realtek/rtw88/rtw8703b_tables.c:306:1: warning: sym=
bol 'rtw8703b_mac_tbl' was not declared. Should it be static?
> drivers/net/wireless/realtek/rtw88/rtw8703b_tables.c:633:1: warning: sym=
bol 'rtw8703b_agc_tbl' was not declared. Should it be static?
> drivers/net/wireless/realtek/rtw88/rtw8703b_tables.c:841:1: warning: sym=
bol 'rtw8703b_bb_tbl' was not declared. Should it be static?
> drivers/net/wireless/realtek/rtw88/rtw8703b_tables.c:901:1: warning: sym=
bol 'rtw8703b_rf_a_tbl' was not declared. Should it be static?

I'll add the #include. Oddly I don't get those warnings, I wonder if
it's a difference between Clang (which I'm using for easier
cross-compiling) and GCC?