Received-SPF: pass (google.com: domain of linux-wireless+bounces-4322-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 2 Mar 2024 09:01:18 +0100
From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 3/5] wifi: rt2x00: silence sparse warnings
Message-ID: <20240302080118.GA198451@wp.pl>
References: <20240223114023.c64e2d348453.Iccc4ace1116721a044e5f31f40ea7709e72145f3@changeid>
 <20240223114023.ce0c714124e9.I2b5710b761f63522574fbe7654d37151c31e0b77@changeid>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240223114023.ce0c714124e9.I2b5710b761f63522574fbe7654d37151c31e0b77@changeid>

On Fri, Feb 23, 2024 at 11:40:25AM +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> Clearly writing __le32 was intended here, so just put the
> right casts into the code to silence sparse about it.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>

> ---
>  drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> index aaf31857ae1e..3bb81bcff0ac 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> @@ -10946,13 +10946,13 @@ static void rt2800_efuse_read(struct rt2x00_dev *rt2x00dev, unsigned int i)
>  	/* Apparently the data is read from end to start */
>  	reg = rt2800_register_read_lock(rt2x00dev, efuse_data3_reg);
>  	/* The returned value is in CPU order, but eeprom is le */
> -	*(u32 *)&rt2x00dev->eeprom[i] = cpu_to_le32(reg);
> +	*(__le32 *)&rt2x00dev->eeprom[i] = cpu_to_le32(reg);
>  	reg = rt2800_register_read_lock(rt2x00dev, efuse_data2_reg);
> -	*(u32 *)&rt2x00dev->eeprom[i + 2] = cpu_to_le32(reg);
> +	*(__le32 *)&rt2x00dev->eeprom[i + 2] = cpu_to_le32(reg);
>  	reg = rt2800_register_read_lock(rt2x00dev, efuse_data1_reg);
> -	*(u32 *)&rt2x00dev->eeprom[i + 4] = cpu_to_le32(reg);
> +	*(__le32 *)&rt2x00dev->eeprom[i + 4] = cpu_to_le32(reg);
>  	reg = rt2800_register_read_lock(rt2x00dev, efuse_data0_reg);
> -	*(u32 *)&rt2x00dev->eeprom[i + 6] = cpu_to_le32(reg);
> +	*(__le32 *)&rt2x00dev->eeprom[i + 6] = cpu_to_le32(reg);
>  
>  	mutex_unlock(&rt2x00dev->csr_mutex);
>  }