Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1744150lqg; Mon, 4 Mar 2024 02:20:17 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVJ1kWj/T8/s1kB/nPCH3D37CmXXvOBQk7Gmv46x8oTzRWSgphkkdfo4GfsKhkcCLW3fXIn08imuYL7ni4hvUv3vgLbzJUIl+ydk/tkNg== X-Google-Smtp-Source: AGHT+IGQnoUwO74tAAEoApMA0qnt72O4iCE9b7S6cxl0sVgcdB+Ovz7k7sqJs9thMyi0lTTLCXo+ X-Received: by 2002:a05:6808:bd6:b0:3c1:b2c7:f6d3 with SMTP id o22-20020a0568080bd600b003c1b2c7f6d3mr10896171oik.41.1709547617515; Mon, 04 Mar 2024 02:20:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709547617; cv=pass; d=google.com; s=arc-20160816; b=mQGqGGphAj+Rb3trg/1yrBopROByUW86i/QW2eto6aRRYTU7/OeHjoNaoaIDCXAd+Z LTF1rm/vE94c13lsSBXVPACHC79JNxHDPjOK5aU+qkjsU7VVxo1gEmUgjnr4vG3rqKqc 2t/XR3ZOdPOyc4y2ircFjh9Je1B7iovXZT//QyLcOSyauOk3elVg7e5cwv8I3mq+xZ/7 Gh18NP5nEjIK2HyxiTk1Ex+k7e9VEWW8nt8DXPLJobb2iCKrKFN+UM67U8t23T5I950v Da/sYWbQF0bIKdDjmkzDurEdhpDkqnCtyrFTtxkvz//JMyVqRXdx2XSz9C0TMhzsNE68 3PGw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=D3pYtXHlcf+Bg2jiMbnGCra7ypaXgvmXgMcKoNI6C1s=; fh=BavzQ2TQbgAnA70spXLzJrHgRmO7EwpKntT9CLwJA+U=; b=h33ZtXrnpltQBpJYLmbc8+VDqjldr6Z4QfPFP/GpBcFRGUoHhUdDayapw54PqQETSe NKzNvEi4N+/XfFQHYMZHZ7oun7j+BGeOLmMFi2jvfGfiqeJAeHlRMfbTOWZKb0M4jt77 mNhWI/6cbp4zNKl9M+c527ssI3Hao9d2EZcWcnr0ERbX0WEN+olD3bgbfnHRmFV7X/Ps Rn9hd/i/voHwXxDmBrdU6tAiJ4lzEyrSeKFehqOwVeIRXcfu1X7iUu+sEXpIBviys08C yXuGhdpNI+vy7bTgV4sPr1J6J7OdqqjspbMKNZVPgaD8ddOYR0LJNb6tq64zyyYXyrCW 0MTg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=fb11IaKc; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-wireless+bounces-4336-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4336-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id t36-20020a635364000000b005dcd64fe5dbsi7861549pgl.431.2024.03.04.02.20.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:20:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-4336-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=fb11IaKc; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-wireless+bounces-4336-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4336-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 12C6E283897 for ; Mon, 4 Mar 2024 10:20:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 113FE364B7; Mon, 4 Mar 2024 10:17:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="fb11IaKc" X-Original-To: linux-wireless@vger.kernel.org Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85FA4241E5; Mon, 4 Mar 2024 10:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547436; cv=none; b=TBzlZraY1SI2XsCYBcpchtbPVgCjnG6N3fGAcaQOG7dXizrroS2Kf+9XnisQJnNH+qnylo8v6jfVqvsfyqpgUgudzCl8rPAG5PgFCeF7FrnP0qVIloYMAioE22f8SmHcj8cG9trD6W9liZ45ybMlbmlw1JEZjNw2FFotvzXB5tY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547436; c=relaxed/simple; bh=ltcyOw+TgqviIKZ8PQUG8CPcAe7I74uGtSNAStThC1w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VJOpuJ4Kb7F501R/AL3cTwe/+2P2gzOhLay28fshaUIk+kUrT3oliZTQpss/sHa2QLq8fMpZnbPSyYGhGcht/E1JbxFm797QHUyWzOMLjFvlCfV727IJ5Otr3tMNDn06rpSktSkF0ZoHS6XEzN70MlWeT8nlwfpLcBuaqLx4c4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=fb11IaKc; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709547432; bh=ltcyOw+TgqviIKZ8PQUG8CPcAe7I74uGtSNAStThC1w=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fb11IaKccd0sn7CyPKu2BXQKbFW2upyD39noI5TM03TJBBiM5ye+aWnCUUD2VbkIq 2TnHjnBrpEVsp4dAD81Wujg/2j3bYBUPN+PI1ui+pqh3XqbQ9AS1HyWi5D+Tm0y9Tl NXav/eWcHeq9xhcHxEkGYzaSJGHAt9AJ4EHlVVVOCSkNGkqR4NwznUGaNk+vUJaiDE IvaQKjCwcb0EBo5VHb7oK2HPqb7UUoSsCo+BnT+j04XQmITA8I8pylgLfe7w4TJCjv GVclBtl4+0/QhrYVEDW+AR1QYgVcXe+cPtL2ufpRyVs+46CSb+DPwSEyEoDusH73BK xCWmU2AHLwU7Q== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id D33AE3781FE9; Mon, 4 Mar 2024 10:17:11 +0000 (UTC) Message-ID: Date: Mon, 4 Mar 2024 11:17:11 +0100 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: mt76: connac: check for null before dereferencing Content-Language: en-US To: Muhammad Usama Anjum , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Kalle Valo , Matthias Brugger Cc: kernel@collabora.com, kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20240301144406.2808307-1-usama.anjum@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20240301144406.2808307-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 01/03/24 15:44, Muhammad Usama Anjum ha scritto: > The wcid can be NULL. It should be checked for validity before > dereferencing it to avoid crash. > > Fixes: 098428c400ff ("wifi: mt76: connac: set correct muar_idx for mt799x chipsets") > Signed-off-by: Muhammad Usama Anjum Reviewed-by: AngeloGioacchino Del Regno