Received-SPF: pass (google.com: domain of linux-wireless+bounces-4338-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <91955fe006705879b5debbb1618262754ea4be7a.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: mac80211: Adjust CQM handling for MLO
From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, Ilan Peer <ilan.peer@intel.com>, Miriam
	Rachel Korenblit <miriam.rachel.korenblit@intel.com>
Date: Mon, 04 Mar 2024 16:23:13 +0100
In-Reply-To: <8734t682er.fsf@kernel.org>
References: 
	<20240228094753.bf6a3fefe553.Id738810b73e1087e01d5885508b70a3631707627@changeid>
	 <8734t682er.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-03-04 at 17:03 +0200, Kalle Valo wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>=20
> > From: Ilan Peer <ilan.peer@intel.com>
> >=20
> > The CQM handling did not consider the MLO case and thus notified
> > a not-existing link with the CQM change. To fix this, propagate
> > the CQM notification to all the active links (handling both the
> > non-MLO and MLO cases).
> >=20
> > TODO: this currently propagates the same configuration to all
> > links regardless of the band. This might not be the correct
> > approach as different links might need to be configured with
> > different values.
>=20
> Is that TODO link there intentionally?
>=20

Yeah, we need to consider this in the context of what wpa_s wants to do,
etc. So this _helps_, but it may not appropriately resolve the issue of
what this API really does.

johannes