Received-SPF: pass (google.com: domain of linux-wireless+bounces-4358-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <574de3b9-3328-470b-a998-761e1d5fb8a9@quicinc.com>
Date: Mon, 4 Mar 2024 13:28:47 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iw: Add JSON output options to 'iw' for scan results
Content-Language: en-US
To: Isaev Ruslan <legale.legale@gmail.com>,
        Johannes Berg
	<johannes@sipsolutions.net>
CC: <linux-wireless@vger.kernel.org>
References: <CACDmYyeipzNzeBoXQEtsXRu9uHUuteZ1ymJZZ-GsM=zhT19trg@mail.gmail.com>
 <4370a021c6870c58fb15718ee9e4ce8d675b3e3a.camel@sipsolutions.net>
 <CACDmYydF7ZDSGh-9XQ5bvyAcXt1m8JE-EXMTd8mDbGcegO1gfA@mail.gmail.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <CACDmYydF7ZDSGh-9XQ5bvyAcXt1m8JE-EXMTd8mDbGcegO1gfA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 3/4/2024 12:23 PM, Isaev Ruslan wrote:
> On Mon, 4 Mar 2024 at 22:00, Johannes Berg <johannes@sipsolutions.net> wrote:
>>
>>>
>>> If these changes prove valuable, I am prepared to continue working on
>>> extending JSON output support throughout the tool.
>>> Feedback is welcome and appreciated.
>>>
>>
>> I'd prefer to look at it unmangled - can you resend it with whitespace
>> preserving tools please?
> 
> If I understood you correctly, you wanted to see the patch without whitespaces.
> I have sent the patch v2 in a separate email.

no, we want patches with correct whitespace/indentation

all of the patches you've sent so far have multiple places where correct
code indentation is not present.

for example:
+ if (argc > 0 && strcmp(*argv, "-j") == 0) {
+ iw_json = 1;
+ new_json_obj(1, 0); //pretty print disabled
+ argc--;
+ argv++;
+ }

Not sure how you are posting, but note that many e-mail clients mangle
patches.

Please refer to:
<https://docs.kernel.org/process/email-clients.html>