Received-SPF: pass (google.com: domain of linux-wireless+bounces-4379-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <172b85b1166c2f026df396ee4dabc3cbb2c300f9.camel@sipsolutions.net>
Subject: Re: [PATCH v5] Add JSON output options to 'iw' for scan results
From: Johannes Berg <johannes@sipsolutions.net>
To: Isaev Ruslan <legale.legale@gmail.com>
Cc: Nicolas Escande <nico.escande@gmail.com>, linux-wireless@vger.kernel.org
Date: Tue, 05 Mar 2024 14:29:55 +0100
In-Reply-To: <CACDmYycV9qP2TUMMz5ij75A18NEaVpke6t70r7ELNgV=8+sCRw@mail.gmail.com>
References: <5c5be485dcfceb44fc731e47758d6be3.legale.legale@gmail.com>
	 <12f91b008d6f2b4e6241794d2852c1c84fe6c12c.camel@sipsolutions.net>
	 <CZLQMMSSUWBF.1NPJJYDRIXGIR@gmail.com>
	 <37398c88130c487be656eed4e378d6b047a3d612.camel@sipsolutions.net>
	 <CACDmYycV9qP2TUMMz5ij75A18NEaVpke6t70r7ELNgV=8+sCRw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-03-05 at 14:32 +0300, Isaev Ruslan wrote:
>=20
> I think i could make a universal printf() like function with
> additional args for json representation.
>=20
> Something like this:
> before:
> printf("\t * Manufacturer: %.*s\n", sublen, data + 4);
>=20
> after:
> printf_json("\t * Manufacturer", "%.*s", sublen, data + 4);

I think you meant

printf_json("Manufacturer", "%.*s", sublen, data + 4);

but yeah, that seems better? Not sure I'd call it print_json() over just
print() or output() or so at that point.

> void printf_json(const char* key, const char* fmt, ...) {
>     char buf[1024];
>     va_list args;
>     va_start(args, format);
>=20
>     if (iw_json) {
>         vsnprintf(buf, sizeof(buf), format, args);
>         print_string(PRINT_JSON, key, "%s", buf);
>     } else {
>         printf("\t * %s: ", key);

Guess we'd have to be careful about the indentation. Track the (JSON)
object nesting level and apply it that way?

johannes