Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp610384lqs; Tue, 5 Mar 2024 10:54:29 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVmf2VGr8vXtBe/4cJ+y8lGAmB/qxMGB592OLISmtHYBPAATTUkIARhRif7qqdQmSv5Pph9N6wCamdZFKfV679S2c3jLvwd167Bg0Ay6Q== X-Google-Smtp-Source: AGHT+IFVTxJZjWxnjKkFP46XrNmF3B4CBuengec0V9zvZ5p6y+637QyCzmTwgQi4pinem/aqp0IU X-Received: by 2002:a05:6122:2024:b0:4d3:4aad:7bf0 with SMTP id l36-20020a056122202400b004d34aad7bf0mr2908976vkd.0.1709664869128; Tue, 05 Mar 2024 10:54:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709664869; cv=pass; d=google.com; s=arc-20160816; b=j/KtfuGPak59udFdPAJkCC3dkdijQGANY2D/hp/917V6wxPyYleZI6Rwbhn9mG16tD S/kE7BPB9uo66HX3K3rzN+AqENGDL4q/25p6yirMQa9LoUfO/o2OzuGRLej0uqM7fpnU 8WrKfV7rU4FTJI2jn3FE237KxKR1Ehd5omN3nrvuzX9PN2qwFFdAH3lT+mQRIItRa4pP N6mFoYjKC2tNKYDNR4Sthxvc1QlDBjpOq6abAIrYgpGCpZMMVyjpVnsR6PihUJmawyXe wjjydpyu9E3k1P9BveFCAF7WjmUWtmuB5uNzKmHvjNV0B1i9eBj5odvawvypwFY3P4b4 8qqg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=YeZQnz7PyXOFt6a1zo8Ilkt9CAEMAN/8w6zL32SOYDw=; fh=HquEARPJ8ho/GjVfiAKDOvRIEFd3jAtZE0YK0340DHg=; b=LFUrI3LplR8oHtP7AJmlgUvVtdEZ//ossiQP0cIMU4rdW9sUJYALbVSNmvPTQtUdCr /9koxzjedrjXQbrwdE5NrTX+ZnuNoilIO5EP+TB3MLIteF0djCQQY4Vebb8y+IGdeEIL j7rpnTZMW1oXZ+TvBCbo2q2FvDKGwcn1eMUb4WWanxdOq3Z33t0QOVeHZUbFJp3VjZyr cQIveF1D8ffrxqUMjMGgebkhO4piUpLZDBxBkdusf5ZDaSCMSTV7cNOsPa6JvHj8cBup PozBFrV/DhNBxF5DwBN1KNIwdw5nMtT5kikwkUZ3Azt/qMuUqzB0261rDSUv3B8ath6D /OAQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ecm+wuF4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-4395-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4395-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id u20-20020a05622a011400b0042e579d2599si7722189qtw.687.2024.03.05.10.54.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 10:54:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-4395-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ecm+wuF4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-4395-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4395-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D376D1C23847 for ; Tue, 5 Mar 2024 18:54:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B2DD51AAAE; Tue, 5 Mar 2024 18:53:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ecm+wuF4" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A2AF18EBB; Tue, 5 Mar 2024 18:53:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709664837; cv=none; b=PKktMb2umToAnRR1MDLIWODuKI6EE4udaNyWekhfvFtsYabSk7KeOLx5x9+bbzLw1VAhhRNCcpqOUd70xG2x8nxG5A6CVPaqZvOJcT1Ln9s4Kn5WZ4IMUWit1pf7jaZXy6hWLuxxyqlDdkVm+SwrTb8dDIY+9Jnwp5MM+nCYSyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709664837; c=relaxed/simple; bh=vLqY0HFHJgDeiDMFCS0uUpBm2ixyQTrPWM9Q5wyrM2U=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=oSnE4/3sTDWI8FRax8+xAys2Ilmswxn147NrQZEtUxlow9yNuoCXx1RbPengRIjiBwchrcne3NXrErVbleKlUZ6zzLEVUUseoMpW3xzJPn6GitEUk/wLkGde0cNm0g/KEgJlgYw/OEe/W5NesKJ+KYzF2/973fN2xwFxy0gQixY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ecm+wuF4; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BDEEC433C7; Tue, 5 Mar 2024 18:53:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709664837; bh=vLqY0HFHJgDeiDMFCS0uUpBm2ixyQTrPWM9Q5wyrM2U=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Ecm+wuF4LmNV/89c+AryxHeGUFkgtZ53aQH4ZAJt/9QIlYMkIETKcayycNeF9Ej0W 9z31v9TCkC1RGdhBbg655U8SrfzlPYD/GvEGu9aeKXaQCKmhHyoh5ZHGn8q3eawP9q 9xQUyPYHdLrV9q/E1GahCw9ZqiTdiwIpJieYo4ArV+6QS7OwxEzI20u5LgZ7Kc3JMo r7sHbulsQMz1TVKwmwy/u7AlUgW9aPkv8ws1uVVadOur07B8oWcsgFNVWa9lb9bAn+ phXLJ5RT4oyCqm9sHwqUIP2XlwD0ekSbUurBGpzGbhNmlFcYUbJZkU0LYoOVgZ3K8f kK1+ULfHs54AQ== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v2] wifi: wlcore: sdio: Rate limit wl12xx_sdio_raw_{read,write}() failures warns From: Kalle Valo In-Reply-To: <20240228101042.728881-1-javierm@redhat.com> References: <20240228101042.728881-1-javierm@redhat.com> To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Nishanth Menon , Javier Martinez Canillas , Breno Leitao , Li Zetao , linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170966483365.424347.18076602135809337745.kvalo@kernel.org> Date: Tue, 5 Mar 2024 18:53:55 +0000 (UTC) Javier Martinez Canillas wrote: > When these failures happen, the warning and call trace is printed which is > excessive. Instead, just print the error but rate limited to prevent warns > to unnecessarily pollute the kernel log buffer and make the serial console > practically unusable. > > For example, on an AM625 BeaglePlay board where accessing a SDIO WiFi chip > fails with an -110 (ETIMEDOUT) error: > > $ dmesg | grep "sdio write\|read failed (-110)" | wc -l > 39 > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Breno Leitao Patch applied to wireless-next.git, thanks. f6e36d9e1c63 wifi: wlcore: sdio: Rate limit wl12xx_sdio_raw_{read,write}() failures warns -- https://patchwork.kernel.org/project/linux-wireless/patch/20240228101042.728881-1-javierm@redhat.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches