Received: by 2002:ab2:788f:0:b0:1ee:8f2e:70ae with SMTP id b15csp522826lqi; Thu, 7 Mar 2024 04:32:28 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVFoP1YEzAwq19uyNDT16HInpt6cT9LUjDropYHI7JVMpsdJvHFIL9CXLy7U4c1idONGXWi+ESZO5dvIAAfl1T9hbGbS8R/4JiQ6QsdsA== X-Google-Smtp-Source: AGHT+IHEz6FkG3mxtknvLCHr3iPzfHN+GtyemlOw3uT8EhDx/kMWK8WGc59M5cralEd3cn2IgpS3 X-Received: by 2002:a05:6871:e01a:b0:221:381b:1cf8 with SMTP id by26-20020a056871e01a00b00221381b1cf8mr8197314oac.3.1709814748144; Thu, 07 Mar 2024 04:32:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709814748; cv=pass; d=google.com; s=arc-20160816; b=e0c08MjyKMBOvokV5zIYgiXiMtOx5BSy+eoenar60ehzN9GvSar/PNENk+V9Z2VLNf Rc8Ugokhdr51+n4kSyM04m9P4eP4GDfS4X519Q4i7rrWStdE8+9sGZRsB3sME3yX29lk cZqlqyWj0vHWF4nDKmgm7ppbS8Id+2B+F7ZrPX1tCYycs+cBglhA9+Hpwsajcy0FofaR Y+GGET191POWdpzZoDw44G8nR2Xk8HchiRp9ZN/MHyXHclYDeSm7pAwc+PpyTvVm9NOl 4K007KchbDApicMZ/KRsQ2+XpGaRgDwehz1FO0ohO2ivKMPSqsNRY7sIoviRkRbjSPfJ G3+A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=CnKV7YkmwKVN45OVgq9HMp191oP0lkB4cDHb6peK+T4=; fh=tsuyM29b7GoEpFPfPU3+O6Zf7ZCsrHw4ifPW3HRA1sI=; b=n4ywfKRmjSov9+95/+gBL4knvS2n0nbbapxohMt1HCapxa26GFkCTwvYXyk+d+LpVh hO+nBZ3fq7pch/afFJ7z0hpjPeqWn3J4U5fmBE4cKXWupWE6FMFYCw7+476o/dHpNuZt cUqurB2WQcwDMikekZXXn4YlPO5kzWItkEOC7M/kWAhXaIfAjPlaGuZBS0mKxzB/lrnx SZANidQZxcK8kU1NwVGl6tgps9gi88b3Rta+sEGNb/2RAxvCw6Oz8AKrkKlFkxvDxKhb yhx8Kbax8dP3vBn1xF+VKcOXrcd03puL1gK5PaJsyfia7pFB2uoDU/8nwwbSBYWeLFPv HAbw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=lBx1+QuJ; arc=pass (i=1 spf=pass spfdomain=ellerman.id.au dkim=pass dkdomain=ellerman.id.au); spf=pass (google.com: domain of linux-wireless+bounces-4453-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4453-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id v5-20020a05622a188500b0042e5ce97b2esi13332171qtc.793.2024.03.07.04.32.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 04:32:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-4453-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=lBx1+QuJ; arc=pass (i=1 spf=pass spfdomain=ellerman.id.au dkim=pass dkdomain=ellerman.id.au); spf=pass (google.com: domain of linux-wireless+bounces-4453-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4453-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 0A5761C22B43 for ; Thu, 7 Mar 2024 12:32:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A0D7486656; Thu, 7 Mar 2024 12:32:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="lBx1+QuJ" X-Original-To: linux-wireless@vger.kernel.org Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D78F384FD5; Thu, 7 Mar 2024 12:32:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=150.107.74.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709814742; cv=none; b=qlrHjZF5gfMHB129LSyAWWqP2IoxSWOf210cWLZpG6im0mcsxbpDRKZ/wH/+4QTofWegGoXm0PSqWYJDQ20yNU069sTvF5x7u2OzfIF9J3u8Fx54earuwfFVlU9Ep75b/KRcRVbzS6RN5tyUW48IHEQlcqYJ0AChMc3b94KyOaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709814742; c=relaxed/simple; bh=CnKV7YkmwKVN45OVgq9HMp191oP0lkB4cDHb6peK+T4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=qSXw9glSI9pQzgAlZWw01fjMjQRLCoYzV23qVcUHioZC0HVjAXzgiDk9IEn3fvtI04niI/Hp8XJ3kLK8YOx/xl3LthwwB8UvrfrVCjtioVkV7NSWpGB2J32Y6dVJTbGOLtyTmvsS4k7e3p+6CmBWYuyk9U5TOBXTK9pp7uauiK4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au; spf=pass smtp.mailfrom=ellerman.id.au; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b=lBx1+QuJ; arc=none smtp.client-ip=150.107.74.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ellerman.id.au DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1709814736; bh=CnKV7YkmwKVN45OVgq9HMp191oP0lkB4cDHb6peK+T4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lBx1+QuJTEVHApTpCCDU+EV1Aykxe0USdn1M5qeFxUu86nOmkjduBDq8dT3o7qXpm oS8/qBbiILsQJC5KQx/qJRP/+1Rtwj+Mvna+PmMaQHKiOOUzj3K4BfsAnCXpYBeO5i sIHi1sZKR2G1jRkcILr1PE7EJZw85kHZ0/HyQZD5Je+4MUjufb3f6fIkyubjPbz8re /xYRYrDhHsNlHZi8hwJ5D8xkg2qXwM8ii3IePd37e1Jh7QAPge7a0+jwCSZNdI+ZOe Y4f3knEgXbFr14hWz3pvmzLU64Pzxk2jZ5fbpD4Fd7BcqwRmHFTOSol/RnqeVlE3F0 mpc6I8Pch7Hkg== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Tr7wZ6z4Xz4wc8; Thu, 7 Mar 2024 23:32:14 +1100 (AEDT) From: Michael Ellerman To: Dawei Li , Christophe Leroy Cc: "npiggin@gmail.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-ide@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-serial@vger.kernel.org" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned In-Reply-To: References: <3dc29701-239f-4a3b-b571-b9732975bd73@csgroup.eu> Date: Thu, 07 Mar 2024 23:32:14 +1100 Message-ID: <87bk7qnrxt.fsf@mail.lhotse> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Dawei Li writes: > Hi Christophe, > > On Tue, Feb 20, 2024 at 04:12:17PM +0000, Christophe Leroy wrote: >> Hi Michael, >>=20 >> ping ? >>=20 >> Le 01/02/2023 =C3=A0 15:36, Dawei Li a =C3=A9crit=C2=A0: >> > Commit fc7a6209d571 ("bus: Make remove callback return void") forces >> > bus_type::remove be void-returned, it doesn't make much sense for any >> > bus based driver implementing remove callbalk to return non-void to >> > its caller. >> >=20 >> > This change is for macio bus based drivers. >> >=20 >> > Signed-off-by: Dawei Li >>=20 >> This patch is Acked , any special reason for not applying it ? >>=20 >> Note that it now conflicts with commit 1535d5962d79 ("wifi: remove=20 >> orphaned orinoco driver") but resolution is trivial, just drop the=20 >> changes to that file. > > Thanks for picking it up, hardly believe that it's been one year. > > Michael, > > I will respin V4 if it's needed. No that's fine, I'll sort it out. cheers