Received-SPF: pass (google.com: domain of linux-wireless+bounces-4456-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <a1ac8dae34081e0ccde0fddf445f2ef13dbd06e5.camel@sipsolutions.net>
Subject: Re: [PATCH v7] Add JSON output options to 'iw' for scan results
From: Johannes Berg <johannes@sipsolutions.net>
To: Isaev Ruslan <legale.legale@gmail.com>, linux-wireless@vger.kernel.org
Date: Thu, 07 Mar 2024 16:23:47 +0100
In-Reply-To: <d1988e179abb5911a8ddedfe95018bf4.legale.legale@gmail.com>
References: <d1988e179abb5911a8ddedfe95018bf4.legale.legale@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-03-04 at 23:01 +0300, Isaev Ruslan wrote:
> v7 changes:
> - binaries json/a json/a.out removed
>=20
> v6 changes:
> - add iw_printf(const char *key, const char *fmt, ...)
> - rewrite print_ssid_escaped() as a demo with new concept
>=20

I guess it'd kind of be useless to test that way, but it'd be nicer to
review a patch that only has new concepts?

Maybe split it anyway - one patch to add all the external code, one to
do the 'right' things and one with all the other stuff for testing?

johannes