Received-SPF: pass (google.com: domain of linux-wireless+bounces-4458-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 7 Mar 2024 19:14:41 +0300
From: Ruslan Isaev <legale.legale@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v7] Add JSON output options to 'iw' for scan results
Message-ID: <Zenn8QaDJ0kxon2w@radar-prod1.wnam.ru>
References: <d1988e179abb5911a8ddedfe95018bf4.legale.legale@gmail.com>
 <a1ac8dae34081e0ccde0fddf445f2ef13dbd06e5.camel@sipsolutions.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a1ac8dae34081e0ccde0fddf445f2ef13dbd06e5.camel@sipsolutions.net>

On Thu, Mar 07, 2024 at 04:23:47PM +0100, Johannes Berg wrote:
> On Mon, 2024-03-04 at 23:01 +0300, Isaev Ruslan wrote:
> > v7 changes:
> > - binaries json/a json/a.out removed
> > 
> > v6 changes:
> > - add iw_printf(const char *key, const char *fmt, ...)
> > - rewrite print_ssid_escaped() as a demo with new concept
> > 
> 
> I guess it'd kind of be useless to test that way, but it'd be nicer to
> review a patch that only has new concepts?
> 
> Maybe split it anyway - one patch to add all the external code, one to
> do the 'right' things and one with all the other stuff for testing?
> 
> johannes

Ok. I will replace all the prints with new concept prints with iw_printf().
I hope it will not be useless.