Received-SPF: pass (google.com: domain of linux-wireless+bounces-4482-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 8 Mar 2024 05:50:49 +0100
From: Michael =?UTF-8?B?QsO8c2No?= <m@bues.ch>
To: James Dutton <james.dutton@gmail.com>
Cc: Rand Deeb <rand.sec96@gmail.com>, deeb.rand@confident.ru,
 jonas.gorski@gmail.com, khoroshilov@ispras.ru, kvalo@kernel.org,
 linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
 lvc-project@linuxtesting.org, voskresenski.stanislav@confident.ru
Subject: Re: [PATCH v3] ssb: Fix potential NULL pointer dereference in
 ssb_device_uevent
Message-ID: <20240308055049.50a830fc@barney>
In-Reply-To: <CAAMvbhGmu5VtkA=KnxoHr=Fg_4=1yHFP_SERwKD_rxH=jpM1BA@mail.gmail.com>
References: <20240307192405.34aa9841@barney>
	<20240307211928.170877-1-rand.sec96@gmail.com>
	<20240307223849.13d5b58b@barney>
	<CAAMvbhGmu5VtkA=KnxoHr=Fg_4=1yHFP_SERwKD_rxH=jpM1BA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/Rhyzgt75tD3LaJRP/HlHUF7";
 protocol="application/pgp-signature"; micalg=pgp-sha512

--Sig_/Rhyzgt75tD3LaJRP/HlHUF7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, 7 Mar 2024 22:02:29 +0000
James Dutton <james.dutton@gmail.com> wrote:

> If one does a NULL check after it has been previously dereferenced,
> the compiler will totally remove the NULL check anyway,

I think the kernel uses -fno-delete-null-pointer-checks.

But anyway, this doesn't invalidate the point of having a NULL check.
The intent of the code was very clear.
So don't remove it.

--=20
Michael B=C3=BCsch
https://bues.ch/

--Sig_/Rhyzgt75tD3LaJRP/HlHUF7
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEihRzkKVZOnT2ipsS9TK+HZCNiw4FAmXqmSkACgkQ9TK+HZCN
iw5FQw//bOaVLWgfyhfI4G/Yl8Syd1+U+W3zc5f7fIpIbNGqn7UnWyWhgb196In1
knUBwNb5lyCmjtSBnMxl3xrm8LatJgwFnFk8sVjbljGrEpdL5pVTrABdYQA5d6br
xZOWm7vFQWTGLTNdvjmLP6CqF96yVCiFMyCtQ8xnOw0zplPFnG/kO3yz5t/hFxER
2JHGwdJMatyBXVyPjFqkKOdU0+i9heOUvvwTfcQby5kbaP8r2iPy4JEewnCQLQEV
DCvUyOE6Gv8PNDngX9EcMyxoBe7teYDxX6wWlVx9eldRVlATl0g2Qgl52PPh8hAE
dr8UetddVgX7yA2VwZT4IYfL1tu4GAd+8DjPh98r79V28DrmRcnxE+eGM0mCfTaJ
TwLDSd9UGPTe1EDBqMkNG5JtpzNHKaFAz84HOUS8bf/QlQtOBnZUo9c4IPWtWdNv
mbqAd5FgVEfjRpCSyJ8A5ty8lplQH80ORx/z8ty7Rpp2JqYq6yyrGhQkU42IEH8D
WJvwoWEh7yyluL1o1J8p0xwMI+OxTB36uCb1EkuV2jEjfBjOWhYXr7BEQtQBRBs3
6GH2UKmL5h0nVhGsKXgo0vUIPFeG+jpG1wGaSPtyUBn/xo+JU7APxpNOCob12DhH
1umDjHtUlf1K0FZ6sfDAa5FMIvCwsaKRyrxbfiqTY2+gi5Z1wAA=
=3Ich
-----END PGP SIGNATURE-----

--Sig_/Rhyzgt75tD3LaJRP/HlHUF7--