Received-SPF: pass (google.com: domain of linux-wireless+bounces-4498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org,  linux-wireless@vger.kernel.org,  Ching-Te Ku
 <ku920601@realtek.com>,  Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: pull-request: wireless-next-2024-03-08
References: <20240308100429.B8EA2C433F1@smtp.kernel.org>
	<20240308074539.04512f66@kernel.org>
Date: Fri, 08 Mar 2024 18:50:11 +0200
In-Reply-To: <20240308074539.04512f66@kernel.org> (Jakub Kicinski's message of
	"Fri, 8 Mar 2024 07:45:39 -0800")
Message-ID: <87wmqc4qik.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Jakub Kicinski <kuba@kernel.org> writes:

> On Fri,  8 Mar 2024 10:04:29 +0000 (UTC) Kalle Valo wrote:
>> here's a pull request to net-next tree, more info below. Please let me know if
>> there are any problems.
>
> coccicheck flags:
>
> drivers/net/wireless/realtek/rtw89/rtw8922a.c:2235:2-4: WARNING: possible condition with no effect (if == else)

Thanks, but how did you find this? I'm asking just to understand your process, at
least the pull request shows all green:

https://patchwork.kernel.org/project/netdevbpf/patch/20240308100429.B8EA2C433F1@smtp.kernel.org/

We don't run coccicheck so it's not surprising there are new warnings.

> for a non-urgent follow up. Doesn't look like an obvious false positive.

Ping, could you fix this, please? In the patch please add Closes tag
pointing to Jakub's email and mark it for wireless tree (assuming the
merge window starts on Sunday, otherwise we take it to wireless-next).

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches