Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp913725lqc; Fri, 8 Mar 2024 16:14:59 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXCrMagqp8OqB62DhzuEJW/qvvzM2WOebQt52A5IR5AsgNgqs9PeGuAQKfS/3izkPZw7RPPt3T46lIMUr6DaIUJBJcMZEKMutXsTIo8Hg== X-Google-Smtp-Source: AGHT+IE9+mDefdXXIUZYp8bX4KSqYeFcYtE9RmNyuGsu+hm+E30yf1JZ6NGq5/W1l/axuorxESEc X-Received: by 2002:a2e:900a:0:b0:2d2:6193:6d53 with SMTP id h10-20020a2e900a000000b002d261936d53mr388501ljg.13.1709943299771; Fri, 08 Mar 2024 16:14:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709943299; cv=pass; d=google.com; s=arc-20160816; b=g/5Gj6AOcg58Nv2j6vqsygLz1MY1R8aVvU2SFlqt2cix12VdUPTMl04rKkVC1NmYHx 813f192Tzi54lx0ABLEMP4jJv1cWc7iCWlRnTdLaVPtK/ZCIZjB7hYfV1jUwb7YVOorf Eif/EDDEAtXC2JdtoMA+4nO0aIpS2WV8lSD0n/X9r4tod/2sfry1FeEyIdNpew1eNUbC hoS0V9LrjIoTgBus0IQg74m2zdpVpRx6oZkwDwPu1NXH0wWMLIYzsaJ1Oz3hqb3ToXU0 mAxvPiyrpwhJ4IulqTu8rYAi0RbhBM9a1fzqSiJxVnRtHqoK4IgWHeGghCH2K2k7HF9E ZUUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=2T2rDL7feTi8lXYhXpQMnFMiQnyb4Rl/O89vAgFiTTw=; fh=irNo3I5BCkvG93c+svVyOfwqyhxiIBthDhXoyP7UJTI=; b=U5juyX37vHTAOqQLuGtUMBRZSJASS1Iz9Ka/JmaFwZjSolqc7FaJmcLN6LUxYxTW95 DJ3CFVab+fbnr4MEspN/7xpKBaFDB/D1RAouuGj1tgKbR/i5B/4TzQNas/rqGUD3p0CR BHOL0d/TacuZVZkVoxlzK2Qw43D5LfFIzpYR4mPOs1wCMe8j5oWYn8Yq3dvh4c2mbnRp n4t9ggL6153CbHixbxNOXFz7LRQ3v5hLh1Q8ZWDC0mZQmTiK0JRd4c2jlLrPgZTaeMJt cmfGLiyQwyk/josAseXq3MQZN7dAGbFWQBwZ41j5BPHUWPJWGyZOnDcBdtbxx7PxQywW bbQg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-4503-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4503-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id r17-20020a05640251d100b005675de9c98bsi264042edd.327.2024.03.08.16.14.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 16:14:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-4503-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-4503-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4503-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 65E051F220F6 for ; Sat, 9 Mar 2024 00:14:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 65A1D188; Sat, 9 Mar 2024 00:14:55 +0000 (UTC) X-Original-To: linux-wireless@vger.kernel.org Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FC7B36E for ; Sat, 9 Mar 2024 00:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709943295; cv=none; b=rNd30/I+3/ZwXI2S2LOM2rBYXBixh4cEsq1yPrwnvcygIXvR8Uv4KhalUBREgEnS76GYZP3Rd1Up7rAf4vP2x2y+hb9i/veOW177hXoSTQoo9RrmsN798YzDd8sMrgQ0xhwXsybToUVMhGKfttW3Mn13k8uqjAMQ3XAz565gQkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709943295; c=relaxed/simple; bh=Ibp79Cs1kCxk3qRg4r9rlcQt2Z41H6jWOhbKCQ8gUhQ=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=KvHRw4huT/6V8St9PyYuq3Jz9RtBM9WftjZIMeg4jqowvX2h4+QWlmZgfJ7FxxEDDjyz3GZPgk37f736kwJ44drweaS48lciUjgF1MtzxaohrnY1IDO74TZM3cr3hS1CZpmZc8a5AnZv20+LJ/Refg/XHLMy+bNc1rjZ2/3IgLk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 4290EiJA22355724, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 4290EiJA22355724 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 9 Mar 2024 08:14:44 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sat, 9 Mar 2024 08:14:44 +0800 Received: from [127.0.1.1] (172.16.17.25) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sat, 9 Mar 2024 08:14:44 +0800 From: Ping-Ke Shih To: CC: , , Subject: [PATCH wireless] wifi: rtw89: coex: fix configuration for shared antenna for 8922A Date: Sat, 9 Mar 2024 08:13:48 +0800 Message-ID: <20240309001348.9906-1-pkshih@realtek.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: RTEXMBS02.realtek.com.tw (172.21.6.95) To RTEXMBS04.realtek.com.tw (172.21.6.97) X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback WiFi 2x2 + BT combo cards can be two or three physical antenna. For two antenna case, one antenna is shared by WiFi and BT, and different configuration should be applied. Fix the typo. This problem was found by Coccicheck, and actually that is a typo instead: drivers/net/wireless/realtek/rtw89/rtw8922a.c:2235:2-4: WARNING: possible condition with no effect (if == else) Fixes: 652c9642eda6 ("wifi: rtw89: coex: add init_info H2C command format version 7") Closes: https://lore.kernel.org/linux-wireless/170992024446.15593.2682606960737891240.git-patchwork-notify@kernel.org/T/#m074885bdbd91071c7d1771f08917831d9f89d95a Cc: Ching-Te Ku Cc: Jakub Kicinski Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw89/rtw8922a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw89/rtw8922a.c b/drivers/net/wireless/realtek/rtw89/rtw8922a.c index 367459bd1345..708132d5be2a 100644 --- a/drivers/net/wireless/realtek/rtw89/rtw8922a.c +++ b/drivers/net/wireless/realtek/rtw89/rtw8922a.c @@ -2233,7 +2233,7 @@ static void rtw8922a_btc_init_cfg(struct rtw89_dev *rtwdev) * Shared-Ant && BTG-path:WL mask(0x55f), others:WL THRU(0x5ff) */ if (btc->ant_type == BTC_ANT_SHARED && btc->btg_pos == path) - rtw8922a_set_trx_mask(rtwdev, path, BTC_BT_TX_GROUP, 0x5ff); + rtw8922a_set_trx_mask(rtwdev, path, BTC_BT_TX_GROUP, 0x55f); else rtw8922a_set_trx_mask(rtwdev, path, BTC_BT_TX_GROUP, 0x5ff); -- 2.25.1