Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp933852lql; Tue, 12 Mar 2024 02:26:01 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV70kLl9i54J9GQ1VrNUdXvLqz9zJW0Ryb6iSD1WMKv7wLDm3fDl11G7gwCSoeWwJnrfHl5oZJ7rzkIC7Rvi+Pio0eGZ0QTA4nAUdnPKw== X-Google-Smtp-Source: AGHT+IFexzOT4F0+3+2pwN0yh8sqA0iY28fv3DEd001mC3dGCw4cOQFQWR/izqeiRK2gIXZwUVWy X-Received: by 2002:a05:6808:190f:b0:3c1:e5dd:aab with SMTP id bf15-20020a056808190f00b003c1e5dd0aabmr11939747oib.6.1710235560946; Tue, 12 Mar 2024 02:26:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710235560; cv=pass; d=google.com; s=arc-20160816; b=wFlZ6agAP9EKjSut3eHYnFNETnijpp0r6OdgkR1DMuiJslrgTIfyX/g3/eRIA/2FNw 3dyUWcBJaeHc94FNQIfNlOyWqxa4X9baqgsKpMdQ8H47peJ9TALN6C9pJ8iEErdbujft 56kn0/g7tej1/nO8n/4Qu5WKazRQ5n6FB8io/tbMWTN3WkT5m0go/Z1H9rwXbf32BaG2 rbsMiAJGFQCiKs5/2sP+Zsq4QJLqMXhVJNDm8mQBVKIrlYkWR+evyB/P6/3CjKBKsYe6 mlL0gr3sRkT5u8Gi3Uf4CJtspsyztvaiYiQjbdRn3VN3tGD45TSZfLv+v5vRIKoqvnLo m5eA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=synPQhheQ7nttk4p7RxsmUA/ZDUQQxQq5beeblx3oTU=; fh=qS/ownCzmKEaYy+nQOSYXIyB69zPabuRQlWPfFyt6ls=; b=uGDcuiBu87LF7lKrYvUfXEKqpOZGguGbB1fnbQnND0OPx6XFM0RAwNi5jjHc2OjWor 8MeE69hM6ptZQqCC4oVJogBX+INvifcw1HmQ4BhCfOSFxF/8QA1KpIGoFQvHLWQsKC56 Cif+Ygl3dbJA7gtm4FD0mS68UZOfDlOD5SxVCPqIVYp3fuqeCGJWQXUzf0t+DSf16ekJ NYM8FM8bWhRwQrm6+ylChbtmdwe95ZN9Oxx+DIHavnGLqP9L0ji72wcX/utr0W5FWW4a 6mypLwIoe0viv63ZrFVZvhLrNyhAu4NASj/PzmFYbdn8ICVYpWTSy8kT77IY3EwvLoeM RWJw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Hh8BbXaY; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-4606-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4606-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id t1-20020a632d01000000b005d8e12c85d9si6637905pgt.738.2024.03.12.02.26.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 02:26:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-4606-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Hh8BbXaY; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-4606-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4606-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9AC4128745F for ; Tue, 12 Mar 2024 09:26:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3169C79B62; Tue, 12 Mar 2024 09:23:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Hh8BbXaY" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA4B37994D for ; Tue, 12 Mar 2024 09:23:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710235399; cv=none; b=JlfowJcOFxRal6PLUiaASzWq5FAQIqMLcUed9TaK2MQ7075rQGr5miLdOYxTFIzE7+yo+DVlmg3I8q5S67Weza06V6z78KDgudCuJrw+m4knm4JW+1/EavPZhPk/GnIZpU2H6st4aj/wGaxojhxAHto8cY8GCvqCbDxnjLOaTVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710235399; c=relaxed/simple; bh=DC+YtlnL/Z6qy48ylKxp7c6h9b6EkSgjimDeGp/l+hc=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=jyvAy6JYQTjVzDMOmdtr5tA1RghKZhDm278WGEVuMTelrf2shS8EdR//o5v+XMcRFRrToNE/xv/VyqSNvESJ4wkTMf2b4nZqfqlk5FgYIIam1iQkfArV1PBWBChp4ZXabaHkmT0Nz6csW7k7vWncxLptkkqJazO8Sz/h4ib9iFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=Hh8BbXaY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42C7XMNs023593; Tue, 12 Mar 2024 09:23:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=synPQhheQ7nttk4p7RxsmUA/ZDUQQxQq5beeblx3oTU=; b=Hh 8BbXaYX9rlWOFgBQL4wGCpg3U2rdpGRUULaAsujVuHHJ0Qkk08aJp8cjC2+q1G3v zKHyJOtYTczMf7lom/RiCtH4B722l7ubxlPlWXFllTXSX04WslAS8xJ/FaFxfOIr Vd2pnuQVtTXMYq3LCfJVYVeNK9eW4g6nTZgLRZdNnNeuSwo6Br2LnXvCX+ODTXJe n4mKog+h5RpfDU9jDBXUxpcqlBLPUErf8ik/4Etcv5JPOzhc56h2WPXPrKUwOSF7 82GvsXngsJRVDQBxhOwq7/VjXNOEdyZ9b3Noap7TKbBiLxpV1f1VRQfk/c5ppxJ/ CxrkiEcen/ETZi+N28gw== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wt75e9h33-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2024 09:23:02 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 42C9N1PH021151 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2024 09:23:01 GMT Received: from [10.253.9.188] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 12 Mar 2024 02:22:59 -0700 Message-ID: <4c1adfca-96aa-4b41-86b0-2fe5ad3e6cfb@quicinc.com> Date: Tue, 12 Mar 2024 17:22:57 +0800 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] wifi: mac80211: supplement parsing of puncturing bitmap Content-Language: en-US To: Johannes Berg , CC: References: <20240312045947.576231-1-quic_kangyang@quicinc.com> <20240312045947.576231-2-quic_kangyang@quicinc.com> <8cc7e7f7b2914385b481ecfdd7bc3f67fc4546b3.camel@sipsolutions.net> From: Kang Yang In-Reply-To: <8cc7e7f7b2914385b481ecfdd7bc3f67fc4546b3.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: M-UDRIE9omzwNjmEBQ68hSYJk6VkVDcD X-Proofpoint-ORIG-GUID: M-UDRIE9omzwNjmEBQ68hSYJk6VkVDcD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-12_08,2024-03-11_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 mlxscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 clxscore=1015 mlxlogscore=999 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2403120072 On 3/12/2024 4:16 PM, Johannes Berg wrote: > On Tue, 2024-03-12 at 12:59 +0800, Kang Yang wrote: >> Current mac80211 won't parsing puncturing bitmap when process EHT >> Operation element in 6 GHz band or Bandwidth Indication element. This >> leads to puncturing bitmap cannot be updated in related situations, such >> as connecting to an EHT AP in 6 GHz band. >> >> So supplement parsing of puncturing bitmap for these elements. > > Hah, yes, I just noticed that too and fixed the second part yesterday, > and was still thinking about how I could test the first part :-) > Should we add validation for puncturing bitmap in validate_chandef_by_6ghz_he_eht_oper()? > johannes > >