Received-SPF: pass (google.com: domain of linux-wireless+bounces-4607-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <84b85c7f409ec38a34ffe040f4d1e90253854c21.camel@sipsolutions.net>
Subject: Re: [PATCH 1/2] wifi: mac80211: supplement parsing of puncturing
 bitmap
From: Johannes Berg <johannes@sipsolutions.net>
To: Kang Yang <quic_kangyang@quicinc.com>, ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Date: Tue, 12 Mar 2024 11:17:33 +0100
In-Reply-To: <4c1adfca-96aa-4b41-86b0-2fe5ad3e6cfb@quicinc.com>
References: <20240312045947.576231-1-quic_kangyang@quicinc.com>
	 <20240312045947.576231-2-quic_kangyang@quicinc.com>
	 <8cc7e7f7b2914385b481ecfdd7bc3f67fc4546b3.camel@sipsolutions.net>
	 <4c1adfca-96aa-4b41-86b0-2fe5ad3e6cfb@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-03-12 at 17:22 +0800, Kang Yang wrote:
>=20
> On 3/12/2024 4:16 PM, Johannes Berg wrote:
> > On Tue, 2024-03-12 at 12:59 +0800, Kang Yang wrote:
> > > Current mac80211 won't parsing puncturing bitmap when process EHT
> > > Operation element in 6 GHz band or Bandwidth Indication element. This
> > > leads to puncturing bitmap cannot be updated in related situations, s=
uch
> > > as connecting to an EHT AP in 6 GHz band.
> > >=20
> > > So supplement parsing of puncturing bitmap for these elements.
> >=20
> > Hah, yes, I just noticed that too and fixed the second part yesterday,
> > and was still thinking about how I could test the first part :-)
> >=20
>=20
> Should we add validation for puncturing bitmap in=20
> validate_chandef_by_6ghz_he_eht_oper()?
>=20

We already have, no?

It calls ieee80211_chandef_he_6ghz_oper(), which checks
cfg80211_chandef_valid(), which includes puncturing.

johannes