Received-SPF: pass (google.com: domain of linux-wireless+bounces-4705-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <7eba247f-fa78-47c5-a130-5d07689180df@gmail.com>
Date: Thu, 14 Mar 2024 00:39:24 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Subject: Re: [PATCH 1/3] wifi: rtlwifi: Move code from rtl8192de to
 rtl8192d-common
To: Ping-Ke Shih <pkshih@realtek.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
 "s.l-h@gmx.de" <s.l-h@gmx.de>, "chewitt@libreelec.tv" <chewitt@libreelec.tv>
References: <e1922019-21eb-4013-a35f-0077167e92cf@gmail.com>
 <27f2a0a588ed2f6c3c89fb0b60eab7d2f60f65b6.camel@realtek.com>
Content-Language: en-US
In-Reply-To: <27f2a0a588ed2f6c3c89fb0b60eab7d2f60f65b6.camel@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 13/03/2024 04:16, Ping-Ke Shih wrote:
> On Wed, 2024-03-13 at 00:18 +0200, Bitterblue Smith wrote:
>>
>> Create the new module rtl8192d-common and move some code into it from
>> rtl8192de. Now the rtl8192de driver (PCI) and the new rtl8192du driver
>> (USB) can share some of the code.
>>
>> This is mostly the code that required little effort to make it
>> shareable. There are a few more functions which they could share, with
>> some changes.
>>
>> The only other changes in this patch should be adjusting whitespace and
>> renaming some functions.
> 
> Please run checkpatch.pl that reports 
>    "total: 5 errors, 20 warnings, 67 checks, 9388 lines checked"
> 
> I know you just move them from a place to another, but let's fix them
> when touching. 
> 

All right, I will make checkpatch less unhappy.

> 
> Two unused warnings on channel_all and 
> rtl92d_dm_check_txpower_tracking_thermal_meter (you also pointed it out)
> > Ping-Ke 
> 
>