Received-SPF: pass (google.com: domain of linux-wireless+bounces-4706-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <198972bc-bed3-449c-b879-716d59f65793@gmail.com>
Date: Thu, 14 Mar 2024 00:40:21 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Subject: Re: [PATCH 1/3] wifi: rtlwifi: Move code from rtl8192de to
 rtl8192d-common
To: Ping-Ke Shih <pkshih@realtek.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
 "s.l-h@gmx.de" <s.l-h@gmx.de>, "chewitt@libreelec.tv" <chewitt@libreelec.tv>
References: <e1922019-21eb-4013-a35f-0077167e92cf@gmail.com>
 <19743f05-5c95-41ad-bdb9-3694e5d2bb41@gmail.com>
 <c23608da2932896f7beb8fc29247efa5b2e92be0.camel@realtek.com>
Content-Language: en-US
In-Reply-To: <c23608da2932896f7beb8fc29247efa5b2e92be0.camel@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 13/03/2024 05:53, Ping-Ke Shih wrote:
> On Wed, 2024-03-13 at 01:21 +0200, Bitterblue Smith wrote:
> 
>>
> 
>> rtl92d_dm_check_txpower_tracking_thermal_meter() is actually
>> unused in rtl8192de. Should I just delete it?
>>
>> I don't remember why I made it static, but that introduced
>> a warning.
> 
> 
> I feel we can set rtlpriv->dm.txpower_tracking = false, and then uncomment
> /* rtl92d_dm_check_txpower_tracking_thermal_meter(hw); */
> 

That sounds good.

> 
> More, this function appears twice: 
> 
> $ git grep rtl92d_dm_check_txpower_tracking_thermal_meter
> rtl8192de/dm.c:static void rtl92d_dm_check_txpower_tracking_thermal_meter(struct ieee80211_hw *hw)
> rtl8192de/dm.c:         /* rtl92d_dm_check_txpower_tracking_thermal_meter(hw); */
> rtl8192du/dm.c:void rtl92d_dm_check_txpower_tracking_thermal_meter(struct ieee80211_hw *hw)
> rtl8192du/dm.c:         rtl92d_dm_check_txpower_tracking_thermal_meter(hw);
> 
> I suppose you should move rtl92d_dm_check_txpower_tracking_thermal_meter()
> to dm_common.c. 
> 

I didn't move the TX power tracking to dm_common.c because
it calls two functions which are different in the PCI driver
and the out-of-tree USB driver. (The USB driver is a few years
newer.)

* rtl92d_phy_lc_calibrate()
* rtl92d_phy_iq_calibrate()

I suppose if rtl92d_dm_check_txpower_tracking_thermal_meter()
takes two function pointers, it can be moved:

void rtl92d_dm_check_txpower_tracking_thermal_meter(struct ieee80211_hw *hw,
						    void (*lc_calibrate)(struct ieee80211_hw *hw),
						    void (*iq_calibrate)(struct ieee80211_hw *hw))

Or, struct rtl_hal_ops already has phy_lc_calibrate member.
I could add phy_iq_calibrate too.