Received-SPF: pass (google.com: domain of linux-wireless+bounces-4728-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Kalle Valo <kvalo@kernel.org>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
  Ping-Ke Shih <pkshih@realtek.com>,  Larry Finger
 <Larry.Finger@lwfinger.net>,  Stefan Lippers-Hollmann <s.l-h@gmx.de>,
  Christian Hewitt <chewitt@libreelec.tv>
Subject: Re: [PATCH 1/3] wifi: rtlwifi: Move code from rtl8192de to
 rtl8192d-common
References: <e1922019-21eb-4013-a35f-0077167e92cf@gmail.com>
	<87jzm64ig6.fsf@kernel.org>
	<7fd2d445-9db0-4170-8d89-78d42f476255@gmail.com>
Date: Thu, 14 Mar 2024 10:18:13 +0200
In-Reply-To: <7fd2d445-9db0-4170-8d89-78d42f476255@gmail.com> (Bitterblue
	Smith's message of "Thu, 14 Mar 2024 00:46:13 +0200")
Message-ID: <87a5n1fcqi.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:

> On 13/03/2024 10:58, Kalle Valo wrote:
>> Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:
>> 
>>> Create the new module rtl8192d-common and move some code into it from
>>> rtl8192de. Now the rtl8192de driver (PCI) and the new rtl8192du driver
>>> (USB) can share some of the code.
>>>
>>> This is mostly the code that required little effort to make it
>>> shareable. There are a few more functions which they could share, with
>>> some changes.
>>>
>>> The only other changes in this patch should be adjusting whitespace and
>>> renaming some functions.
>>>
>>> Tested only with RTL8192DU.
>>>
>>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>> 
>> A cover letter is would be really good to have.
>
> I can add one. What should I write in it?

Basically just a short (few sentences) introduction what the patchset
adds and if there are problematic/broken/todo items, for example in this
case that the firmware upload is pending. This info helps the reviewers
and also having the cover letters makes the grouping in email
applications better.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches