Received: by 2002:ab2:5c0e:0:b0:1ef:a325:1205 with SMTP id i14csp239922lqk; Thu, 14 Mar 2024 01:27:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUySt6gS8yeGzuqGjU4VhUT/B/3RIZEZtVWfFqkjczi8WrINhQS5Bi2cVPl+oDLnSvXGNbyMmywYFtSnkivnU1TdqPMahQcSCb2jIxAhQ== X-Google-Smtp-Source: AGHT+IEsQU9/eBx4EO2JTlVEvYvlqmm0d6qlbJo2Tfp/RLPk+ajEya0UHOAJQYezc/1ioVZhRtuO X-Received: by 2002:a25:83cd:0:b0:dc7:6f13:61d1 with SMTP id v13-20020a2583cd000000b00dc76f1361d1mr1023243ybm.20.1710404831993; Thu, 14 Mar 2024 01:27:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710404831; cv=pass; d=google.com; s=arc-20160816; b=o1IwQOqZot313qD0jTGspl6RbyqSoAefMzUwCXYPK5F2qZmG2PnI/0hNTCIkkIibGx E3wEa7tjPZ7UE2za9NfnSZMgctBaCyPAzT09w4DptZQ6lUO/jzFwZ0u4BWkuX8V25PzC qs2Sd/Sw0OM+gbnjhks7isF0i52GV5l/4NYFM1xdITS06a55zQjKvs52/9Ag4Ka/E2Ul 2lsNKQSVxawMH+F9gd9J51ZpitAKgPvyX/8flb9UQ3SLvExile77LHswXrmGbjgu1GaU 7iHmjJNehityTy13xhdEC3t4/bsNSQHbL0qWMqSidLhkoK4ZM79Ib/Y6PbA2yTmOeTr+ BOUA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=6+i9+54uPWF/COHJEGfSDD1USMvFOydWaYmSYPYe1hw=; fh=sYEhJTtnTEN1lCnmFKyE9HjZohMbEK1h/NYxKkIvoas=; b=Nsek1UQklPvCKw9ci4E/FUppPVk9DDNjgzI9jQlCVQ5EvvvzqxSFXeR2CXqXnlsHDY Hdzkjm3xX+HHyNDgSVhNQ0NipNFzAYUYLZtSrWjy9BDMVyHtIUYkd/r/hkhRH1uSxAzF iCP5a1QI3I2aBxKJUy4ufiV6U48MolmAgp4soQT077W/5Y7HjeBBymRQlc4XEZAux8Uf OVEtByvPfaqGkv6qvZKU75NkuciuVef0K9avB63AIuuWsikhmauWWRHqqT98wgFVZRhy /g0QzNUyFkYXlx01DXkWKbXNz1Kiult3cr1nkv9DAAmEtQZIeCMkq8aL9NRgFpTpFgpz QB+w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SO+NkM49; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-4729-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4729-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id v17-20020a05622a145100b0042ec938a4acsi974218qtx.6.2024.03.14.01.27.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 01:27:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-4729-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SO+NkM49; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-4729-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4729-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3D9281C21515 for ; Thu, 14 Mar 2024 08:26:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 560215D488; Thu, 14 Mar 2024 08:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SO+NkM49" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 312052A1DB for ; Thu, 14 Mar 2024 08:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710404812; cv=none; b=uwyc9e2pGQmgiKJIc04VZU2pfZbP5e+bkDOBwIygULpDsgNTAb7379YL00fiZdwikep+rLktwK2WBlJIdu6nWO0/ZpKfhaUIa013e8eYkS+o6BxsUQSWiQSYPKOGXk8ATA+wmeePAPIEHCCNo76wuD9vcuRDXKAfovYXDBtTwG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710404812; c=relaxed/simple; bh=NMPqL6Zqr7EmaMd5aQN8KKo00e/2uFnDS1/sLs6HIFM=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=RZV1jqyWZkGsrYA8yWw3WKFCKaOyypHyTdo/qawfUcdYAPNwLpDK3Vmamu/QzzoUKwTlphmOe/YsGx0vvl+1VjeFLpe0VAE6eIwo2bGETb7Qh1QOeaW8hyvuZseBGooF6TUsS+Cnp76X8VZ1d4c/Ml7UVqPxD/D6/jFP+09TnpI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SO+NkM49; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6857C433F1; Thu, 14 Mar 2024 08:26:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710404811; bh=NMPqL6Zqr7EmaMd5aQN8KKo00e/2uFnDS1/sLs6HIFM=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=SO+NkM49NvYcmApsyff7X79OFT0F5pbkIlM3Tdqekv7acH/MvNljZkRACZLAMyP7Y RV7U0xRu/0/lVqIve8Trhj78bAub6h17ANyvwuwpg8LRIfpzefN8fIaJ97G+FnIWtb 2wU3y7BAU9PTiD18KOLaFjmZ5vpl9BBEYG5XsOTYGZTfftd6x+iyPnxbcI7c3MqxWs M+03+TlslN4mS0yJkfSwLx31fRkzAM3hXQkTtPOC0OD0fCU+JIpSt9OCOtD800KZmk 1GX+2EfyfjVjmh1uFx2gF58Ash4MhYU5wu/ZUPuowbKPZ8juwizQ1bmkhIZL32sgqV Xajiji+g0iZMQ== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [wireless] wifi: rtw89: coex: fix configuration for shared antenna for 8922A From: Kalle Valo In-Reply-To: <20240309001348.9906-1-pkshih@realtek.com> References: <20240309001348.9906-1-pkshih@realtek.com> To: Ping-Ke Shih Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171040480864.2330768.13987992906518213166.kvalo@kernel.org> Date: Thu, 14 Mar 2024 08:26:50 +0000 (UTC) Ping-Ke Shih wrote: > WiFi 2x2 + BT combo cards can be two or three physical antenna. For two > antenna case, one antenna is shared by WiFi and BT, and different > configuration should be applied. Fix the typo. > > This problem was found by Coccicheck, and actually that is a typo instead: > > rtw8922a.c:2235:2-4: WARNING: possible condition with no effect (if == else) > > Fixes: 652c9642eda6 ("wifi: rtw89: coex: add init_info H2C command format version 7") > Closes: https://lore.kernel.org/linux-wireless/20240308074539.04512f66@kernel.org/ > Cc: Ching-Te Ku > Cc: Jakub Kicinski > Signed-off-by: Ping-Ke Shih Patch applied to wireless.git, thanks. cec60af1972d wifi: rtw89: coex: fix configuration for shared antenna for 8922A -- https://patchwork.kernel.org/project/linux-wireless/patch/20240309001348.9906-1-pkshih@realtek.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches