Received-SPF: pass (google.com: domain of linux-wireless+bounces-4730-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: <ku920601@realtek.com>,  <kuba@kernel.org>,
  <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH wireless] wifi: rtw89: coex: fix configuration for
 shared antenna for 8922A
References: <20240309001348.9906-1-pkshih@realtek.com>
Date: Thu, 14 Mar 2024 10:33:29 +0200
In-Reply-To: <20240309001348.9906-1-pkshih@realtek.com> (Ping-Ke Shih's
	message of "Sat, 9 Mar 2024 08:13:48 +0800")
Message-ID: <875xxpfc12.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Ping-Ke Shih <pkshih@realtek.com> writes:

> WiFi 2x2 + BT combo cards can be two or three physical antenna. For two
> antenna case, one antenna is shared by WiFi and BT, and different
> configuration should be applied. Fix the typo.
>
> This problem was found by Coccicheck, and actually that is a typo instead:
>   drivers/net/wireless/realtek/rtw89/rtw8922a.c:2235:2-4:
>     WARNING: possible condition with no effect (if == else)
>
> Fixes: 652c9642eda6 ("wifi: rtw89: coex: add init_info H2C command format version 7")
> Closes: https://lore.kernel.org/linux-wireless/170992024446.15593.2682606960737891240.git-patchwork-notify@kernel.org/T/#m074885bdbd91071c7d1771f08917831d9f89d95a

BTW for Closes and Link tags it's better to use a direct lore link with
Message-Id:

    Closes: https://lore.kernel.org/linux-wireless/20240308074539.04512f66@kernel.org/

The benefits are:

* as the Message-Id is in the link, the mail can be found even if
  lore.kernel.org would go away

* it's shorter

* regzbot uses the Message-Id to close the issues

In lore you can get the URL from "permalink" link. I changed the link
during commit, so no need to resend.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches