Received-SPF: pass (google.com: domain of linux-wireless+bounces-4736-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <fd8384dc-b35f-477e-aac3-b7a5f49ce712@quicinc.com>
Date: Thu, 14 Mar 2024 17:27:22 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4] wifi: ath12k: report tx bitrate for iw dev xxx station
 dump
To: Kalle Valo <kvalo@kernel.org>
CC: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
References: <20240219095802.1147-1-quic_lingbok@quicinc.com>
 <87y1b7jkxu.fsf@kernel.org>
 <6f39eb1c-97f7-4029-a5f2-5ab36ff0f0a6@quicinc.com>
 <877ciq9h3e.fsf@kernel.org>
 <4e67118d-80e4-422e-aa39-73b891ee6042@quicinc.com>
 <87a5nkkfs1.fsf@kernel.org>
Content-Language: en-US
From: Lingbo Kong <quic_lingbok@quicinc.com>
In-Reply-To: <87a5nkkfs1.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2024/2/28 19:08, Kalle Valo wrote:
> Lingbo Kong <quic_lingbok@quicinc.com> writes:
> 
>> On 2024/2/27 21:23, Kalle Valo wrote:
>>> Lingbo Kong <quic_lingbok@quicinc.com> writes:
>>>
>>>> On 2024/2/26 23:37, Kalle Valo wrote:
>>>>> Lingbo Kong <quic_lingbok@quicinc.com> writes:
>>>>>
>>>>>> The tx bitrate of "iw dev xxx station dump" always show an invalid value
>>>>>> "tx bitrate: 6.0MBit/s".
>>>>>>
>>>>>> To address this issue, parse the tx complete report from firmware and
>>>>>> indicate the tx rate to mac80211.
>>>>>>
>>>>>> After that, "iw dev xxx station dump" show the correct tx bitrate such as:
>>>>>> tx bitrate: 104.0 MBit/s MCS 13
>>>>>> tx bitrate: 144.4 MBit/s MCS 15 short GI
>>>>>> tx bitrate: 626.9 MBit/s 80MHz HE-MCS 6 HE-NSS 2 HE-GI 0 HE-DCM 0
>>>>>> tx bitrate: 1921.5 MBit/s 160MHz HE-MCS 9 HE-NSS 2 HE-GI 0 HE-DCM 0
>>>>>>
>>>>>> Tested-on: WCN7850 hw2.0 PCI
>>>>>> WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>>>>>> Tested-on: QCN9274 hw2.0 PCI QCN9274 hw2.0 PCI
>>>>>> WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>>>>>>
>>>>>> Signed-off-by: Lingbo Kong <quic_lingbok@quicinc.com>
>>>>> Please use full englist words like transmit instead of tx. Also the
>>>>> title could be simplified to:
>>>>> wifi: ath12k: report station mode transmit rate to user space
>>>>> Here I assumed this only works in station mode. Or does this also
>>>>> support AP and P2P mode? The commit message should explain that.
>>>>>
>>>>
>>>> Ok, i will apply it in next version. Thanks for pointing out.
>>> After rereading my comments maybe keep the title simple like:
>>>     wifi: ath12k: report station mode transmit rate
>>> But it would be good to clarify in the commit message what modes
>>> this is
>>> supported. And what hardware families support this.
>>
>> Hi kalle, Could you please offer your opinion on this commit message?
>>
>> wifi: ath12k: report station mode transmit rate
>>
>> Currently, the transmit rate of "iw dev xxx station dump" command
>> always show an invalid value.
>>
>> To address this issue, ath12k parse the info of transmit complete
>> report from firmware and indicate the transmit rate to mac80211.
>>
>> This patch only applies to the WCN7850's station mode.
>>
>> After that, "iw dev xxx station dump" show the correct transmit rate.
>> Such as:
>> tx bitrate: 104.0 MBit/s MCS 13
>> tx bitrate: 144.4 MBit/s MCS 15 short GI tx bitrate: 626.9 MBit/s
>> 80MHz HE-MCS 6 HE-NSS 2 HE-GI 0 HE-DCM 0 tx bitrate: 1921.5 MBit/s
>> 160MHz HE-MCS 9 HE-NSS 2 HE-GI 0 HE-DCM 0
> 
> Looks good, except for readability I would add an empty line after "Such
> as:".
> 
> I noticed that the signal patch depends on this patchset:
> 
> https://patchwork.kernel.org/project/linux-wireless/patch/20240219111417.1185-1-quic_lingbok@quicinc.com/
> 
> In that you should submit both patchses in same patchset. But please
> wait until I have reviewed the signal strength patch.

Hi, kalle,

Would you mind if I kindly inquire whether you might have forgotten to 
review "wifi: ath12k: report signal for iw dev xxx station dump" patch?
After you review, I can put the two patches into the same patchset:)

Best regards
Lingbo Kong