Received-SPF: pass (google.com: domain of linux-wireless+bounces-4753-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Kalle Valo <kvalo@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,  Johannes Berg
 <johannes.berg@intel.com>,  Miri Korenblit
 <miriam.rachel.korenblit@intel.com>,
    ath12k@lists.infradead.org
Subject: Re: [PATCH 2/2] wifi: iwlwifi: mvm: disable MLO for the time being
References: <20240314110951.b50f1dc4ec21.I656ddd8178eedb49dc5c6c0e70f8ce5807afb54f@changeid>
	<20240314110951.d6ad146df98d.I47127e4fdbdef89e4ccf7483641570ee7871d4e6@changeid>
Date: Thu, 14 Mar 2024 18:08:07 +0200
In-Reply-To: <20240314110951.d6ad146df98d.I47127e4fdbdef89e4ccf7483641570ee7871d4e6@changeid>
	(Johannes Berg's message of "Thu, 14 Mar 2024 11:09:52 +0100")
Message-ID: <87bk7g4x08.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

+ ath12k

Johannes Berg <johannes@sipsolutions.net> writes:

> From: Johannes Berg <johannes.berg@intel.com>
>
> MLO ended up not really fully stable yet, we want to make
> sure it works well with the ecosystem before enabling it.
> Thus, remove the flag, but set WIPHY_FLAG_DISABLE_WEXT so
> we don't get wireless extensions back until we enable MLO
> for this hardware.
>
> Cc: stable@vger.kernel.org
> Reviewed-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
> index 1935630d3def..69227954e281 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
> @@ -360,7 +360,7 @@ int iwl_mvm_mac_setup_register(struct iwl_mvm *mvm)
>  	if (mvm->mld_api_is_used && mvm->nvm_data->sku_cap_11be_enable &&
>  	    !iwlwifi_mod_params.disable_11ax &&
>  	    !iwlwifi_mod_params.disable_11be)
> -		hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_MLO;
> +		hw->wiphy->flags |= WIPHY_FLAG_DISABLE_WEXT;

I think we should add the same for ath12k, right?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches