Received-SPF: pass (google.com: domain of linux-wireless+bounces-4756-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <09e961f89c9d86ff8e60e860376924961a18387b.camel@sipsolutions.net>
Subject: Re: [PATCH 2/2] wifi: iwlwifi: mvm: disable MLO for the time being
From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Johnson <quic_jjohnson@quicinc.com>, Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, Miri Korenblit
	 <miriam.rachel.korenblit@intel.com>, ath12k@lists.infradead.org
Date: Thu, 14 Mar 2024 17:36:09 +0100
In-Reply-To: <3883eb2c-54dc-4492-bbc1-9fea02e7e46e@quicinc.com>
References: 
	<20240314110951.b50f1dc4ec21.I656ddd8178eedb49dc5c6c0e70f8ce5807afb54f@changeid>
	 <20240314110951.d6ad146df98d.I47127e4fdbdef89e4ccf7483641570ee7871d4e6@changeid>
	 <87bk7g4x08.fsf@kernel.org>
	 <09ca997159333980a168051a2a49c675a8ad5eeb.camel@sipsolutions.net>
	 <3883eb2c-54dc-4492-bbc1-9fea02e7e46e@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

>=20
> what does it mean "disable wext" if we are a mac80211 driver that doesn't
> utilize wext?
>=20

You don't have a choice about wireless extension support - cfg80211 will
support wext for any non-MLO drivers.

However now we're faced with the situation where we have devices today
that enable MLO, and thus don't have wext. But if we disable MLO, then
those devices would get wext, and then when we later enable MLO again,
they'd lose wext again ... all that seems very unreasonable, and more
likely to lead to complaints than "new device doesn't support wext",
hence the first patch and disabling it explicitly for a device that will
again get MLO later.

johannes