Received-SPF: pass (google.com: domain of linux-wireless+bounces-4758-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <db6a60e0dbd66f307a5890d958f67029ad5bcb4f.camel@sipsolutions.net>
Subject: Re: [PATCH 2/2] wifi: iwlwifi: mvm: disable MLO for the time being
From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, Miri Korenblit
	 <miriam.rachel.korenblit@intel.com>, ath12k@lists.infradead.org
Date: Thu, 14 Mar 2024 17:40:21 +0100
In-Reply-To: <87plvwepjq.fsf@kernel.org>
References: 
	<20240314110951.b50f1dc4ec21.I656ddd8178eedb49dc5c6c0e70f8ce5807afb54f@changeid>
	 <20240314110951.d6ad146df98d.I47127e4fdbdef89e4ccf7483641570ee7871d4e6@changeid>
	 <87bk7g4x08.fsf@kernel.org>
	 <09ca997159333980a168051a2a49c675a8ad5eeb.camel@sipsolutions.net>
	 <87plvwepjq.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-03-14 at 18:39 +0200, Kalle Valo wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>=20
> > On Thu, 2024-03-14 at 18:08 +0200, Kalle Valo wrote:
> > >=20
> > > > -		hw->wiphy->flags |=3D WIPHY_FLAG_SUPPORTS_MLO;
> > > > +		hw->wiphy->flags |=3D WIPHY_FLAG_DISABLE_WEXT;
> > >=20
> > > I think we should add the same for ath12k, right?
> > >=20
> >=20
> > It's really up to you, I think. I'm hoping to even get this into stable=
,
> > FWIW.
>=20
> ath12k doesn't support MLO yet but I feel that disabling wext already
> now would be consistent from user's point of view.

Ah, you're in the situation where wext is still enabled now, but will
disappear when you enable MLO.

Agree then that it would make sense to disable wext right now so it's
not a software upgrade for the same hardware that removes it.

johannes