Received-SPF: pass (google.com: domain of linux-wireless+bounces-4760-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <50b2d162-00a1-4001-894b-d5560c4226b2@quicinc.com>
Date: Thu, 14 Mar 2024 09:42:08 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] wifi: iwlwifi: mvm: disable MLO for the time being
Content-Language: en-US
To: Kalle Valo <kvalo@kernel.org>, Johannes Berg <johannes@sipsolutions.net>
CC: <linux-wireless@vger.kernel.org>,
        Miri Korenblit
	<miriam.rachel.korenblit@intel.com>,
        <ath12k@lists.infradead.org>
References: <20240314110951.b50f1dc4ec21.I656ddd8178eedb49dc5c6c0e70f8ce5807afb54f@changeid>
 <20240314110951.d6ad146df98d.I47127e4fdbdef89e4ccf7483641570ee7871d4e6@changeid>
 <87bk7g4x08.fsf@kernel.org>
 <09ca997159333980a168051a2a49c675a8ad5eeb.camel@sipsolutions.net>
 <87plvwepjq.fsf@kernel.org>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <87plvwepjq.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 3/14/2024 9:39 AM, Kalle Valo wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
> 
>> On Thu, 2024-03-14 at 18:08 +0200, Kalle Valo wrote:
>>>
>>>> -		hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_MLO;
>>>> +		hw->wiphy->flags |= WIPHY_FLAG_DISABLE_WEXT;
>>>
>>> I think we should add the same for ath12k, right?
>>>
>>
>> It's really up to you, I think. I'm hoping to even get this into stable,
>> FWIW.
> 
> ath12k doesn't support MLO yet but I feel that disabling wext already
> now would be consistent from user's point of view.

Now that I understand what this is doing I completely agree. We should prevent
the use of wext with ath12k.

/jeff