Received-SPF: pass (google.com: domain of linux-wireless+bounces-4822-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: David Lin <yu-hao.lin@nxp.com>
To: Brian Norris <briannorris@chromium.org>
CC: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvalo@kernel.org" <kvalo@kernel.org>, "francesco@dolcini.it"
	<francesco@dolcini.it>, Pete Hsieh <tsung-hsien.hsieh@nxp.com>, Francesco
 Dolcini <francesco.dolcini@toradex.com>
Subject: RE: [EXT] Re: [PATCH v9 2/2] wifi: mwifiex: add host mlme for AP mode
Thread-Topic: [EXT] Re: [PATCH v9 2/2] wifi: mwifiex: add host mlme for AP
 mode
Thread-Index: AQHab2oqV1El38Ap00yuI3DpHpR6T7E5l5eAgAM6irA=
Date: Mon, 18 Mar 2024 02:04:04 +0000
Message-ID:
 <PA4PR04MB9638D5722670E38B5691B948D12D2@PA4PR04MB9638.eurprd04.prod.outlook.com>
References: <20240306020053.18054-1-yu-hao.lin@nxp.com>
 <20240306020053.18054-3-yu-hao.lin@nxp.com> <ZfTrm7bxMykHO-M-@google.com>
In-Reply-To: <ZfTrm7bxMykHO-M-@google.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?TbntTmI7LSAMgrdDERl4pTlK27QkQsAAQuNKX3c0IneCPRr1k0rnCYXJFsQH?=
 =?us-ascii?Q?4G5dTHZ6nA++0QIHMx/ohvEcH6EkrBn72woUNL9FHU63VZDmXb7pWH3PFJnC?=
 =?us-ascii?Q?0E0ThW/9K43AiTtmyu4f5eyXkEG80AXSgvoxg7aCO0Bfy7btnD2pVCRa1qqy?=
 =?us-ascii?Q?FJ19OxVFe+WpCA2ZMyZv2AfAYguCTlzFAuvc/4udyTnu63imDHKDiTPFoT76?=
 =?us-ascii?Q?A3zU033/tZ3QwVAtCC8RwNqiob5ecXjvBhZawQ1hovB1XLM/QP15mCezRwQq?=
 =?us-ascii?Q?PvNH+VPHO/GvyK1l80QYC9STsY1LPPCig8kMghd8AcNYXr9UBtWjuIZu5c13?=
 =?us-ascii?Q?bkVRo9tThqoG1YlMsphlvZnihbYmjrz9SlHMBJ+Q3RCocu/iTDZnTT9Fiebr?=
 =?us-ascii?Q?w592B290d1DiLpwb/QZy0YQlE2VMUW1T0CQUNpMXBh3X4M8AWQKMatvst6DX?=
 =?us-ascii?Q?lT22NUrvuJ1P0FceKp53yz4nYx/Snz39M2lvrFP/b4y+TVssXb+YqtHy2uSD?=
 =?us-ascii?Q?W6C6/QD//pGM7GOSRo/nVWyXyxOgiFwj39quuXFGTW49lFHLmZuFpTAs9YY6?=
 =?us-ascii?Q?PTaTAYJP60NdJcxCrCPuJAmTECdbud3lzuaH9sSdb5wUcmE4Ge9M9pE9Lvzr?=
 =?us-ascii?Q?no8/J/g13NmcC+UewRN3krhHCitvrrpaGfSgcJoHd+Mqd+h60DkfRmw0gJBH?=
 =?us-ascii?Q?uiNJkOAUIqZeuLGb2l+UxTetQQFkn63uNiS0SIr42+a4Dv/iS6hTaiKRNGuW?=
 =?us-ascii?Q?1gNByog+LRPmMEyLfjahFo64AbkpB02IPwhM/+aKN6qcFGJ/U2Kj3BI8oEaA?=
 =?us-ascii?Q?3uiXhP1Xq6zu0bNDK2D2rICYmUTNdibseUUDdC+tyNB/ON5hvxRqf4dC2a7f?=
 =?us-ascii?Q?AUy/uGHw7uz3YHL10Lgih8dEEqYgfeL0y+Kabo1QgJwGw172gnl38dhuRFkD?=
 =?us-ascii?Q?wfd2vwmFycuBCPpArDiEKKiDRn+Q84wGSMpFRgrMxlZADE5ZjC2bGlxO6n+C?=
 =?us-ascii?Q?7Cxvji0XV1YxCiewKcU2DVGP/zYsGcyqcCFaGVCLJJfw8i6EUeJVxV9Z2u6B?=
 =?us-ascii?Q?n9EkpmRvrWdpbsEiqlk971UksCXrlszLvnsPEEPoLHFa6K/BiYCGFy/jiTW3?=
 =?us-ascii?Q?ye9EfSiwXh3wXcPgC8Lm2013P8Pq029VnNFDglso200DL/an192IjfvkAF7A?=
 =?us-ascii?Q?xFaf/MVyl/P4sR9Whr4PIUy48FZgLe3m2ZXjGFfgWtIpISyk9tezggPKosaC?=
 =?us-ascii?Q?kqE6YDQJDtd/VkGS4wVf1SNyeFwk28p/ISenkCS/Bt7no8kAjXpYY4FIbjA0?=
 =?us-ascii?Q?7WLwdrpiPh8IQvN9JB0eKFJoBq/tdjzkBkiggAI8/gwBCRiS4Crij5MdM7me?=
 =?us-ascii?Q?Zr7uqOOat06Srqya3uC6L3KQ4U6uIAfC163SFb4NnqWi22nDIQfyC0mzwY8n?=
 =?us-ascii?Q?zD6eIuCWutyYD0slR/Y3ivcusY7s8LaitW1QlU4Boe/u6hBuNOoukmi0rTJi?=
 =?us-ascii?Q?qKGtpq35rO+uqPh3kQ7MmPZE+BvIN5iMdfBa0W7ZaJyYK8JfvM6U9jH2+SdS?=
 =?us-ascii?Q?PcCSxbvRObypsMkOgIadHJQwiktliG6qWEhlRzq0?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-wireless@vger.kernel.org
List-Id: <linux-wireless.vger.kernel.org>
List-Subscribe: <mailto:linux-wireless+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-wireless+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9638.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c4ec21f-797e-4e6d-3620-08dc46efaffd
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2024 02:04:04.2962
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JrFQjphHVAXTi8BMrLLceeyL0p1qrLOK4LG0OTmB3pw7QrqfledGRhoI9AvPNuu83bKHxMc/M/Hbazf47Thx5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9593

> From: Brian Norris <briannorris@chromium.org>
> Sent: Saturday, March 16, 2024 8:45 AM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> kvalo@kernel.org; francesco@dolcini.it; Pete Hsieh
> <tsung-hsien.hsieh@nxp.com>; Francesco Dolcini
> <francesco.dolcini@toradex.com>
> Subject: [EXT] Re: [PATCH v9 2/2] wifi: mwifiex: add host mlme for AP mod=
e
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>=20
>=20
> On Wed, Mar 06, 2024 at 10:00:53AM +0800, David Lin wrote:
> > Add host based MLME to enable WPA3 functionalities in AP mode.
> > This feature required a firmware with the corresponding V2 Key API
> > support. The feature (WPA3) is currently enabled and verified only on
> > IW416. Also, verified no regression with change when host MLME is
> > disabled.
> >
> > Signed-off-by: David Lin <yu-hao.lin@nxp.com>
> > Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
>=20
> Quick pass for now; nothing jumps out at me today, but I'll give a better
> look/Ack next week:
>=20
> > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
>=20
>=20
> > @@ -3951,12 +3974,43 @@
> mwifiex_cfg80211_tdls_cancel_chan_switch(struct wiphy *wiphy,
> >       }
> >  }
> >
> > +static int
> > +mwifiex_cfg80211_uap_add_station(struct mwifiex_private *priv, const u=
8
> *mac,
> > +                              struct station_parameters *params) {
> > +     struct mwifiex_sta_info add_sta;
> > +     int ret;
> > +
> > +     memcpy(add_sta.peer_mac, mac, ETH_ALEN);
> > +     add_sta.params =3D params;
> > +
> > +     ret =3D mwifiex_send_cmd(priv, HostCmd_CMD_ADD_NEW_STATION,
> > +                            HostCmd_ACT_ADD_STA, 0, (void
> *)&add_sta,
> > + true);
> > +
> > +     if (!ret) {
> > +             struct station_info *sinfo;
> > +
> > +             sinfo =3D kzalloc(sizeof(*sinfo), GFP_KERNEL);
>=20
> Couldn't this just be stack allocation?
>=20
>                 struct staion_info sinfo;
>=20
>                 cfg80211_new_sta(priv->netdev, mac, &sinfo,
> GFP_KERNEL);
>=20
> I'm not sure you need to kzalloc() something here, if you're freeing it a=
 few
> lines later.
>

Will modify it in patch v10.
=20
>=20
> > +             if (!sinfo)
> > +                     return -ENOMEM;
> > +
> > +             cfg80211_new_sta(priv->netdev, mac, sinfo, GFP_KERNEL);
> > +             kfree(sinfo);
> > +     }
> > +
> > +     return ret;
> > +}
>=20
> Brian