Received-SPF: pass (google.com: domain of linux-wireless+bounces-4823-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: David Lin <yu-hao.lin@nxp.com>
To: Brian Norris <briannorris@chromium.org>
CC: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvalo@kernel.org" <kvalo@kernel.org>, "francesco@dolcini.it"
	<francesco@dolcini.it>, Pete Hsieh <tsung-hsien.hsieh@nxp.com>, rafael.beims
	<rafael.beims@toradex.com>, Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: RE: [EXT] Re: [PATCH v9 0/2] wifi: mwifiex: add code to support host
 mlme
Thread-Topic: [EXT] Re: [PATCH v9 0/2] wifi: mwifiex: add code to support host
 mlme
Thread-Index: AQHab2onJLj7by1TDUGmc5gbcJq9YLE5jRqAgANHPyA=
Date: Mon, 18 Mar 2024 02:20:56 +0000
Message-ID:
 <PA4PR04MB96388A076FC16CF4C76F661AD12D2@PA4PR04MB9638.eurprd04.prod.outlook.com>
References: <20240306020053.18054-1-yu-hao.lin@nxp.com>
 <ZfTiz_fhzPwRk4Xb@google.com>
In-Reply-To: <ZfTiz_fhzPwRk4Xb@google.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?raJgGy18o9v2zY74p8X63h13xyC6ZamrZbIvWx/O7BOBslcIr/oeeeJc1meY?=
 =?us-ascii?Q?0dCr3bCruvAqrCExqErrvS8YHvblmjPohZBV1lK6dTNrbzKHkHhe/rYrD8TG?=
 =?us-ascii?Q?Xk5Qiat5XTqkwXe7z/JH43b32cTtcBvAiAyyhc7SQYopHX3TRsGecIYAyiu1?=
 =?us-ascii?Q?fm88/fKfIyzkf3PB8yznkMr6N+P744jSpX1kOU5tdcJa+ektiEX0WRy98/T3?=
 =?us-ascii?Q?9h24+vCp5dYW7GmKwYSO5/i3RI/oCSotDefSnaH4RUeBTym+mXyhSXeRu/Be?=
 =?us-ascii?Q?9JJfjoPWSWQbM3OdiOGZQ3n4wbXDCixjDkW0t4WdXLKOXDGKmmwRE4PtD4TU?=
 =?us-ascii?Q?aHCEMpUP8zYMZnp3SlU5MtvVrsmJ9oexBNpdwdDtdk8Ro8mz9YMCGixSddYw?=
 =?us-ascii?Q?8qrmkKDmI2PUVCewIDwKocxFnVYtF1/md53Lt0FM35vlebTgNxkSIFbJDriV?=
 =?us-ascii?Q?KlAJTvWLVDBaegM2wYFNdFWnqI+a4pyhl6Dc7VvyJsPgyxMZkhCrYi3gKH5k?=
 =?us-ascii?Q?yyXHeHD9hfnhFwkrMq0kpSAnQZMSlLKvIkkUlbHRZveUG3xSAI93w2ZbZgDL?=
 =?us-ascii?Q?NsjtrX6tZlDOXLPFoW3+oqP6yQv6qjs6JX37x2L2z63sI1QdQN0e7ycBjSi0?=
 =?us-ascii?Q?BxcC9dUMyK6JNUwQNRKy1CQR8njXRYcos8IQaKaeqtvTSzmhqVqsffJQyIvJ?=
 =?us-ascii?Q?066oTkspqxRu+XZzBKtwgYc2LOkbmpDyeTBQY0Nv4Dk0Lv4pnOVe8mbCf9+v?=
 =?us-ascii?Q?DfOLIvJTAWIV5F1/mBWlVEcJpXb/BpmtOw8TqVcKV3LXu/Gpd40NVHSFctwv?=
 =?us-ascii?Q?WB9N/k3kkwJmvtAuG99TgLM+DhTdQMdTunRJ8QIbBrJZH8lI+fk/G4QZ9XOk?=
 =?us-ascii?Q?hPBRQFpou5yMcLrdPLRgpoujHpS0YA1XOiVNinHeBdOeAliZCUs6BRGGfu6J?=
 =?us-ascii?Q?HdCwHwaacevgtnIx9DtISXTaLg5kEkhcjXBacDTXAfkxgD3I2kIvozoYN/zy?=
 =?us-ascii?Q?oIwx75vD3+7NLxm6lnH+9f555ZU4pBjAX8UoWC/na/azxFjcN8z+L80SXuY6?=
 =?us-ascii?Q?KLPjCmOUI2c948nKmMEVRF8+h/s+2EVFPvseKT8WEY+UAaPhfCsgHq2p6tsr?=
 =?us-ascii?Q?ZIA1vlzWrjOUGUrLhXd6QadtpmLzWRkxKz+z5iIYC7k95NIzdPkgbViYowEE?=
 =?us-ascii?Q?te/48tFX3r1HfiSxXQR+kee9SG6my9tuYhgvyz5HLm7tp6elY17fVLkIhXNn?=
 =?us-ascii?Q?93ccpDDzS5KbrsFoluXRK69vgQ76gDP+O7tuAILZrqHacOfr7d7UMg/uP40W?=
 =?us-ascii?Q?t6BirK6c7cklgLI/EnJGUIbnfJEtM4pgnHcrkVFxIk+zF1yINGIcTe+Xf3Xu?=
 =?us-ascii?Q?LarA7QhUNfEkxf5o4K6cXq9DBBGZD5PxECux9hTxeFWkAcWSMiEpG5c84D1m?=
 =?us-ascii?Q?tb3gxXxmOceyuY6zxaL1JNTWTqOBAfrOETDWH0zXXnRE0k/LP5m3gbyd3FJ7?=
 =?us-ascii?Q?GLG+LtTbVo1XasOiJaFShmUidaxXAb6jZc3dinNE035b2ZQD52rLZnE0smgn?=
 =?us-ascii?Q?ffBF/88VT132gnAg7oIFHsnrpmob7ja/kaRo6NTc?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-wireless@vger.kernel.org
List-Id: <linux-wireless.vger.kernel.org>
List-Subscribe: <mailto:linux-wireless+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-wireless+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9638.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 474d044b-9949-477d-4ea5-08dc46f20b02
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2024 02:20:56.0325
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: De3rMDSeyUYfzAiCUl8WC2UKR2HlbSDV7HnFEiqX2CFIsqR6o3tTa2I+iglAcKuRhxRVbciGzPc1WjY9cSk89A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9291

> From: Brian Norris <briannorris@chromium.org>
> Sent: Saturday, March 16, 2024 8:08 AM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> kvalo@kernel.org; francesco@dolcini.it; Pete Hsieh
> <tsung-hsien.hsieh@nxp.com>; rafael.beims <rafael.beims@toradex.com>;
> Francesco Dolcini <francesco.dolcini@toradex.com>
> Subject: [EXT] Re: [PATCH v9 0/2] wifi: mwifiex: add code to support host=
 mlme
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>=20
>=20
> On Wed, Mar 06, 2024 at 10:00:51AM +0800, David Lin wrote:
> > With host mlme:
> > Tested-by: <rafael.beims@toradex.com> #Verdin AM62 IW416 SD Without
> > host mlme:
> > Tested-by: Francesco Dolcini <francesco.dolcini@toradex.com> #
> > 88W8997-SD
> >
> > This series add host based MLME support to the mwifiex driver, this
> > enables WPA3 support in both client and AP mode.
> > To enable WPA3, a firmware with corresponding V2 Key API support is
> > required.
> > The feature is currently only enabled on NXP IW416 (SD8978), and it
> > was internally validated by NXP QA team. Other NXP Wi-Fi chips
> > supported in current mwifiex are not affected by this change.
>=20
> Thank you for all the evoluation in this series. This looks much better t=
han it
> did at the start, and I appreciate the additional explanation of features=
et (HW
> and FW versions). I'm not sure if this has been asked/answered before, bu=
t are
> the MLME/WPA3 limitations exclusively tied to the firmware support ("V2 K=
ey
> API")? Or are there hardware limitations on top (e.g., some firmware migh=
t get
> "V2 Key API" but still be unsupported on a given chip family)? Could othe=
r
> chips chips theoretically get this feature-set in the future?
>=20
> In absence of a clear answer on this, it's definitely a good idea to do t=
hings like
> you have in this series now -- that you have a short-list (of 1) of HW wh=
ere
> where it's validated, and additionally a FW feature/revision check to ens=
ure it's
> running appropriate firmware. But I just wonder what the feasibility woul=
d be
> for adding to the shortlist (or providing users/developers the option of =
doing so)
> in the future, if people are so inclined.
>=20
> To be clear, this is mostly an informational curiosity and forward-lookin=
g
> question -- not a request to change the implementation in this series.
>=20
> Thanks,
> Brian

If firmware reported support of V2 Key API, then host mlme can be supported=
 without issues. There is a flag 'host_mlme' in struct 'mwifiex_sdio_device=
' to indicate if host mlme should be supported. If this flag is set, driver=
 will still check if firmware can support V2 Key API. If firmware can't sup=
port it, host mlme will be disabled.

Thanks,
David