Received-SPF: pass (google.com: domain of linux-wireless+bounces-4874-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: David Lin <yu-hao.lin@nxp.com>
To: Francesco Dolcini <francesco@dolcini.it>
CC: Brian Norris <briannorris@chromium.org>, "linux-wireless@vger.kernel.org"
	<linux-wireless@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "kvalo@kernel.org" <kvalo@kernel.org>, Pete
 Hsieh <tsung-hsien.hsieh@nxp.com>, Francesco Dolcini
	<francesco.dolcini@toradex.com>
Subject: RE: [EXT] Re: [PATCH v9 1/2] wifi: mwifiex: add host mlme for client
 mode
Thread-Topic: [EXT] Re: [PATCH v9 1/2] wifi: mwifiex: add host mlme for client
 mode
Thread-Index: AQHab2opv6Idy9UrJEGIWaaBKnpXoLE5iv+AgANDAgCAAKWbgIAA6H6g
Date: Tue, 19 Mar 2024 01:36:01 +0000
Message-ID:
 <PA4PR04MB9638742AA1748A9EA7371FBDD12C2@PA4PR04MB9638.eurprd04.prod.outlook.com>
References: <20240306020053.18054-1-yu-hao.lin@nxp.com>
 <20240306020053.18054-2-yu-hao.lin@nxp.com> <ZfThCwGj-P5Owlsn@google.com>
 <PA4PR04MB9638F2586DF7E8A41330C8C9D12D2@PA4PR04MB9638.eurprd04.prod.outlook.com>
 <20240318114131.GB9565@francesco-nb>
In-Reply-To: <20240318114131.GB9565@francesco-nb>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?XG21BmbRSpH6K+LRCuAZN1/CiWHoVn6C770VFXeBe3+jmKvUDB9RfZrSvhdE?=
 =?us-ascii?Q?rC7r+MukmWel4Qpce5PRM/iY22GeOGnilpXY3ZkVbEoConVRt4GAlgA2kkLy?=
 =?us-ascii?Q?so+HDmyf8yg7YVb1QyEswUmEm8mp/YL641HsDyy1mjjjoWCMpqiFvVbP1W9I?=
 =?us-ascii?Q?LHIvXGc6Qt+TC4QfoYY8rAtti9RWxU4UUA2OxKiPgD9skK9jjOFxRa72b6LZ?=
 =?us-ascii?Q?/Kxt3WDHKZsUe0BWU87lAB1ndA078FibWQqNAx7iTy/SO43a/v5Q5U38rSch?=
 =?us-ascii?Q?418PvPvyDo7Su1xxGp5qCIi/qafmHaMJlXjNXsAJvYqhExRY67Fe7CiF+DB9?=
 =?us-ascii?Q?B7bPIVzQlCVmfCKQgH/0zMM06F6yFjM4nTQfikIDLCVUn7WO8QcNor6Lbdvf?=
 =?us-ascii?Q?naZz/HO03KLfV7KWWu9yoJN8kZE3lTs5Fs+Cg0Z4P7uig7GaOHxR8UbFcj5w?=
 =?us-ascii?Q?2LJpW4hk8y2SXKYumffPAYGgswlBb0n/V01YNRkvn8XDAFYAJhoDwoq6Ah1g?=
 =?us-ascii?Q?D/ZEVoujIkvEg42yZDtK7uYeGdAqZ9BGX8TGKo5pPp/iwmNGjbpkF9wNZ6b3?=
 =?us-ascii?Q?4wJ8BJwi6Ik+dBiBYxX8Gh6FV3DO1WHEC2/63rcZz7Kl0zy5rdGdGPb3I4Tu?=
 =?us-ascii?Q?WI7V4wYk7sZNxeRnmeVAXw8HBcDkMqZPcK/y0zpEMQLUsUEtsXe2hFXWWZ3J?=
 =?us-ascii?Q?6Z04v/zoB7Bq9qWYn94Y6p9/a9q3peIoeAo+Nqgyvzt6uP/1d7553tigNr2S?=
 =?us-ascii?Q?qwNZTh3srDnXKIbuOW6AaqvmkYZqlNn2e3rTHaiJMYmAC7ylAJLWgMcPkrLP?=
 =?us-ascii?Q?WCXdYqGQfVMaYp4+mcI3a6Cqckx0eDzk+B/5a1bsccSEmi3g6qTScGzogE/s?=
 =?us-ascii?Q?zHRYbRAyMY+PacUzD0hMGc4z5r1XiQP6FqDZ2LLcMoU86xOyDC+kmot8NYPn?=
 =?us-ascii?Q?iYerZib3jAoKlcwCX3DikudDjZBKj5gEdeNu/EOws26vijxktrOTkc+tWZqc?=
 =?us-ascii?Q?Iq3u92Ccu2Coc9EizQI6NmP/q4ssp7bMgBaRUy37U8ih4UrdsxvaZRCZRRVF?=
 =?us-ascii?Q?QFXVC5eDKo6PkPfJ43xkzz/47lMhIeewlsbRvXGt13VF8PkEJ3IhEZ6GuDH4?=
 =?us-ascii?Q?e5pCbHtm8jZafHbRFXlGUJauj2vZZKnnxs6ArOSRPeApH/f/huGPSmQWLkFc?=
 =?us-ascii?Q?1pXHqLUJLNuZtuib5/rzE7EG6weZDNPisAMrHBwlWfZKhW8fBftk2jWAO8kg?=
 =?us-ascii?Q?c5DItpn7Yp1GW6bkz4bvdfXPqDrGe3Hz7nC7eKitjvpZSIO1bEl+RWFJZPLw?=
 =?us-ascii?Q?lVWqrGG/Vv0N3MM5wq/FBHuFoFTg4Pk4wjy0DOxCQBWIN4kZCN6zywCjCtao?=
 =?us-ascii?Q?xba67k65mKmZ778bHpShJFtYP5qUN98SYVTAOBOTElWYk60IZxClEtTm3oZ8?=
 =?us-ascii?Q?xo9Jqml0m6e6hiUXvtG1bthM6KnfJ4tNC+nr5SkWQDBHaLDwL5I9NB6VSE8n?=
 =?us-ascii?Q?yEU6YjYJkyfkcF8oUeIf781GzgfhxEOqQrRTuO/wzCGYJENEVzv1EvsHI/TM?=
 =?us-ascii?Q?Lxizn4e2U/rFnom8tKYBrEDBhRvFlk/QaLQ3SfG0?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-wireless@vger.kernel.org
List-Id: <linux-wireless.vger.kernel.org>
List-Subscribe: <mailto:linux-wireless+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-wireless+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9638.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8070eb75-404d-4ee5-e001-08dc47b4ef4c
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2024 01:36:01.3650
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 92lCYEb03p+Ra5WlJWVi0dprCHVfq+sVT6cdwbHIJv7w116hNss3if0oCJl9xY4IJZuZpNIThKOgL6MlpMQqyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7001

> From: Francesco Dolcini <francesco@dolcini.it>
> Sent: Monday, March 18, 2024 7:42 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: Brian Norris <briannorris@chromium.org>; linux-wireless@vger.kernel.o=
rg;
> linux-kernel@vger.kernel.org; kvalo@kernel.org; francesco@dolcini.it; Pet=
e
> Hsieh <tsung-hsien.hsieh@nxp.com>; Francesco Dolcini
> <francesco.dolcini@toradex.com>
> Subject: [EXT] Re: [PATCH v9 1/2] wifi: mwifiex: add host mlme for client=
 mode
>
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> Hello David,
>
> On Mon, Mar 18, 2024 at 02:00:35AM +0000, David Lin wrote:
> > > From: Brian Norris <briannorris@chromium.org>
> ...
> > > >  .../net/wireless/marvell/mwifiex/sta_ioctl.c  |   2 +-
> > > >  drivers/net/wireless/marvell/mwifiex/sta_tx.c |   9 +-
> > > >  drivers/net/wireless/marvell/mwifiex/util.c   |  80 +++++
> > > >  15 files changed, 671 insertions(+), 14 deletions(-)
> > >
> > > (Per the above, I'd normally consider whether ~671 new lines is
> > > worth splitting into multiple patches. But I don't see any great
> > > logical ways to do that.)
> > Francesco suggested to use two patches for this host mlme new feature
> > from previous many patches. I knew it is a lot of changes, but I think
> > it should be the best way to add host mlme with two patches (one for
> > client and one for AP).
>
> What I explicitly asked was to not add code in a patch, and fix the newly=
 added
> code in a following patch. What you are supposed to do is to just amend t=
he
> original code when you get review feedback.
>

Yes. I will do that for patch v10 and keep all 'Review-by:' and 'Tested-by:=
' tags.

> Splitting a big patch into multiple patches is welcome to easier review, =
and this
> needs to be done breaking down in logical pieces keeping in mind also
> bisect-ability.
>
> This [1] is an example of the addition of a relatively big new driver, an=
d you
> can see that the series is broken down in smaller patches like "Add skele=
ton
> PowerVR driver", with intermediate steps that were non-functional, but th=
ey
> were building fine, they were correct and they were enabling more effecti=
ve
> code review.
>
> Unfortunately, as Brian agreed here, there was no easy way to do it for t=
his
> patch.
>
> Francesco
>
> [1]
> https://lore.kern/
> el.org%2Fall%2Fcover.1700668843.git.donald.robson%40imgtec.com%2F&data
> =3D05%7C02%7Cyu-hao.lin%40nxp.com%7C6ce04f812a5b4dd7e74908dc47405cc
> 7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6384635889617189
> 65%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
> CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=3DHPgEuiKfmtEicp
> PfTz57piOdOoT0iQfo5qnPp9p6jlY%3D&reserved=3D0