Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1380730lqt; Wed, 20 Mar 2024 02:03:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX9jId1eHBT819FGs+PSsZJUFALefudoeuoCkDJ7RHkIGdDwSPqq8g109rYAdkPu3Zh7sio231G5CeLFbb/G2J9zGl3Bn0zfAjRRJio8A== X-Google-Smtp-Source: AGHT+IFmqeyIFLoyZT9a0IVAixm3ZfRIqXicvqM5RC35JCq4eB0Dw6GNOpPKZ0XMiSTC5sc64daA X-Received: by 2002:a9d:67d0:0:b0:6e6:8564:6672 with SMTP id c16-20020a9d67d0000000b006e685646672mr1523109otn.25.1710925435462; Wed, 20 Mar 2024 02:03:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710925435; cv=pass; d=google.com; s=arc-20160816; b=PgexXp6QVCxDBTQReJ5HtFrqpUJ9TbeBZc+Nn5GVJBhs27ItCZjqu/aFFr00AWeRhh nNaZhXYiIkkJgMftIh2Cko3DKi7ep2z4W9z1y6hnl7vTugCic6jwmXEpKxqrhEZwr8CP 8IZLD7zDhs9rzrsJ61FA/+8XlgAwWsVLuiSmI5LMTBTHuBjjhQixgKrs7Yu8NUDVYAQV EdsYRfZJqVZkPseXDPOtHN2vBtDA9io/oYuWjwG5+OqoSND4WEz1OMoygUnKJFt4Kls4 kBVt4AEbzXXlsRvnhp6VN230mnCez87++cfKp+75njXZVgpUq2mnkQWf1li6JLovM3bq NlXw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id:dkim-signature; bh=tZqcChox9CcHzEf0v2PKkwHSnC5LQfuFi9qz0i1saPE=; fh=zTmybEKRLW0X5bquMIm0g3sTvQ8MZmO4xANS/XVXSHo=; b=QbDuW1cCqgl3VkPoOGUj40H07veVh7dPdabAvhFI/B7he975PmHU0IzlLSIzpjilPR A2eBtd8ykzS09f1Ev15+oqCGnPC3UTNqTaM46T1MJnOFh2/L6q4xzz8HAVIQvTr4U0ca egkIeH9l5nIktDbgnsW15F5Fyw+d0FX6Usom+WC+72fMnEGnHY2KTQ0Gx8xA8SWddcrk QqYEcM43Voz0o/9XvynsOjIFpijZnDyNPYgcl5GLNVOf2AC919n1uufDl3Cs2Z/Ok8QF 6enPPGwNtgqtaacy0MN1TJe3tzm0eZz5IOHbxDJGPpVD9MhAq+/5WPSGvS+cXFkVjpri OY7A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=pkbhoZLW; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-4955-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4955-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id c16-20020a37e110000000b00788358dc526si13035848qkm.575.2024.03.20.02.03.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 02:03:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-4955-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=pkbhoZLW; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-4955-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4955-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A01B21C20D35 for ; Wed, 20 Mar 2024 09:03:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A2ECA25605; Wed, 20 Mar 2024 09:03:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="pkbhoZLW" X-Original-To: linux-wireless@vger.kernel.org Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 048723B791; Wed, 20 Mar 2024 09:03:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710925430; cv=none; b=XJdyPMDw4jUAF13w9rdD+AL1dRKlUjaygOTulYRjedAF0No2M8vP19gON6DvWv2tAmpIVWQr378kLiJXSyG9MD2HSrcDv1xGeKuOIQvWdgP5TYaek/CDktuZyh9T6enWgpSVFvhHc+RCmlUXXa3QEkMcK3JEYGohZhIL3f3OinI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710925430; c=relaxed/simple; bh=ajQewOq3z6kaZJsImjXe5I9M1OMxJ07y6xZgj3AxAWs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=HNw8m4BFF1mgfJNIyZ4EtnUIEFJcsQZTaKl/BsOa965khOTy36zpHnz+FDgMG4bKKnDBZC7zRhX6LyGcSP17jzw4BGZ/8XmzcU/sOOhuLjG1ivcokaE3t4XcC3bR7/OYbrMlw/f4u+hH5ESm0K2Z9mD6XnykDhZX9KEQnLFgq/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=pkbhoZLW; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=tZqcChox9CcHzEf0v2PKkwHSnC5LQfuFi9qz0i1saPE=; t=1710925428; x=1712135028; b=pkbhoZLWOaWUotWk2wlSAZuhtswfw5tJ5ctb9qAhvsT3Jlo 0jpavuXQhcW8QhjIWpUgwHSs2HqUmqinU+HRYmpy6xbqIXkYT8NLKQ2VhBFC7N4Wfy7svp8zpUxPr gsK+B+41eYsz0dj3cOgyu00JGi5vPu1qU1MnVKjoB5ZtdC4cU84Xx4qaCo6lHMiCTAx9CyIcxa95a 9urn6mLGKA0xMlqeFj91KIqQCCEmHwUlCPTwhpaV5tM8b8HkTYFJzIjabl0vmg6tUEFPbERS1ME3M CfQYHLESjNCeoZLXBZZYZk6JBYgRve0/f/Qt6/rxogKmL0dNJTLOY3o2sOw1iR6g==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1rmrrJ-00000006tf1-3zv6; Wed, 20 Mar 2024 10:03:42 +0100 Message-ID: Subject: Re: [RFC] wireless: ti: Can we just remove this flexible array? From: Johannes Berg To: "Gustavo A. R. Silva" , Jeff Johnson , Kalle Valo Cc: linux-wireless@vger.kernel.org, LKML , linux-hardening@vger.kernel.org Date: Wed, 20 Mar 2024 10:03:40 +0100 In-Reply-To: <483362b8-ea79-4036-89eb-d6ab737e1e96@embeddedor.com> References: <3a531d5b-9bf6-4e88-ba8c-a76cfa95be20@embeddedor.com> <328306d9-953f-482b-bf9a-a753d7d4e2ed@quicinc.com> <483362b8-ea79-4036-89eb-d6ab737e1e96@embeddedor.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Tue, 2024-03-19 at 18:42 -0600, Gustavo A. R. Silva wrote: >=20 > > > - /* payload */ > > > - u8 data[]; > > > } __packed; > >=20 Why not keep (or even add in the cases where it's not) the comment though? johannes