Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1593200lqt; Wed, 20 Mar 2024 08:26:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXyW0G5wtEsjsnwAbUTmLzBPODNjXTD93SCOi69nI3KqdNIy9j++O1L4TjQtDGcsyNFWDVf2V2IZIdbS9d0LQUVwaWHddn9CNtxCvyUQg== X-Google-Smtp-Source: AGHT+IFjeuUMCUltmUG8Hr/P+o1m4oZ1rKRqZamg67XnLPsmsjld8bs40FLqfaWd6B0Jm3E1tb1J X-Received: by 2002:a05:6359:8086:b0:17e:b9f1:2e37 with SMTP id re6-20020a056359808600b0017eb9f12e37mr13922802rwb.22.1710948359875; Wed, 20 Mar 2024 08:25:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710948359; cv=pass; d=google.com; s=arc-20160816; b=Daic/OWRTy1tNZ/pwNcVqnEZM/V2yWn0n6v3u36QuRZl2rA685dv2So7G3EjQEoQHf 07crgE/YTTegyTKfLZywT8/CD4RKXgLyMRlW8Hj5XV6EEQWk3Zy8k4u/pZzmeg6m1VJS sFiK7mvMEssHpAvMQSsGeHc5JtvbqgY+WC4GYHhTAWOucrTYCNy+LNk6pP3q1e0+VKU+ AYMuRXCaMTEcngIWCx5sr6S0CeUrQ3j0+IfpdQ+Y4zXoLp2Puj9fbvat8Fgwvafv/4NE wnvmdC6Ueyvd8baqbhOyNbojLg7T9HtVMWq+fuzeTOhM48+SkjilnMm+ejuFZNOdCZRm n/Bw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=qblYvL+8Q1RrDqel0i7CO0djad3/mdPRjr4pcjYAvGs=; fh=CEwDS8oYbUIjz49QCXYwHVJkOp9N9rm7kv85883n3tU=; b=sbnKr0OitLqVV1IUosMM0OTLRvX1T/6dLHam04tAsbG2lDN8rOPMG/tmloCjIAe1KI N6TzM99pNPd26WMXFKLReToMLaOwcT4IBnNIe0gnfZdy8IJLk/rmu6hzUzCChwzUDGJK yRMqlR40TsoxPIiKYfKpwGeAU0mTdFy854TdkxFM+Cy09Nx+g+pj0HZPSvBj8JdokTKQ o1Ygb9LwhdsA4cObriIVm9ITQbcI4ZAVMBeSVEcB0BsaXvkXYrpl0XkCcXo3EE/YXXcm gL1pBVAtcIA1V1W9EEqy/wRCtax3hGiprfgKlxk176wO7UrmctleSKZESx5D8YKMIqc3 HfEQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MIuESAPt; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-4989-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4989-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id a29-20020a634d1d000000b005dc210489fdsi12279615pgb.63.2024.03.20.08.25.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 08:25:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-4989-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MIuESAPt; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-4989-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4989-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7F964282191 for ; Wed, 20 Mar 2024 15:25:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2651650260; Wed, 20 Mar 2024 15:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MIuESAPt" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F30E34C61F; Wed, 20 Mar 2024 15:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710948356; cv=none; b=iBfOOiC+3/jkue5x0spiZUAA6DWtvttTJpGQS4qfG60aWIwfd9tyCIo/Wg/Z8Zq5sfN3GYurVlAHjedonllWQ236LpHL7Vn9T0sEDMrQphIrZ7VgekAvulg2b3G3qVBvinrgMMz8amF0Kf/NEB09MDD43JPkhzyrYja0ElQmbic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710948356; c=relaxed/simple; bh=0UWHhH7UBptN7bELngpHg4QMteISn0vghq9W+vJ512A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=iIsJbwlHYhkb6HAPsZ2jZBo7QTc2xapPSJOzDoPN6foE+qewKSn4nqhGf+rFVKnIk9QscZE5OzI9U8IcjLWfRVLQlmkLWdLWyoN516ogymCtvr1ieVAxhwezWwH1dX2fTmMbT7zs8JQbf6ZXizoQtGXUsSYqI6ADGQoSIGkVcFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MIuESAPt; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBF0FC433C7; Wed, 20 Mar 2024 15:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710948355; bh=0UWHhH7UBptN7bELngpHg4QMteISn0vghq9W+vJ512A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MIuESAPtRv5GCgirO/qyzmRLvHHXJCOrd8plPAqUfLX2iR/7j7XUgPTzp85BLcf2t JUMAxHHID/F3grlo60zxh7IOHAutVwv2Bw77Nh3uF94JTl3HeBxVN5CXrHNqJkLEoZ RZ2WsXwn6RnI53FjjkCIqecI8Wlj8s6/U0RxYanVFyy80rQlcARHCa7kGsGOfFZLfi ayJKHO3W78VYlmjzB/4RZ0ZgSAPONOi6qYKHVHcX8TujvDzcyL861ms/7HGtAOBnrf I+4BubwtX/3n36arXTF00LzJ4meYKBO5jMgH73O07HuFOPPdgBGCivkYaBRdy2rIGI W++pT72selqRw== From: Kalle Valo To: Jeff Johnson Cc: Breno Leitao , Jeff Johnson , , , "open list:NETWORKING DRIVERS (WIRELESS)" , "open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER" , open list Subject: Re: [PATCH] ath10k: allocate dummy net_device dynamically References: <20240319104754.2535294-1-leitao@debian.org> <9fcdb857-da62-4832-ae11-043fe993e4ad@quicinc.com> Date: Wed, 20 Mar 2024 17:25:52 +0200 In-Reply-To: <9fcdb857-da62-4832-ae11-043fe993e4ad@quicinc.com> (Jeff Johnson's message of "Wed, 20 Mar 2024 08:12:46 -0700") Message-ID: <87wmpwaprz.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Jeff Johnson writes: > On 3/19/2024 3:47 AM, Breno Leitao wrote: >> Embedding net_device into structures prohibits the usage of flexible >> arrays in the net_device structure. For more details, see the discussion >> at [1]. >> >> Un-embed the net_device from struct ath10k by converting it >> into a pointer. Then use the leverage alloc_netdev() to allocate the >> net_device object at ath10k_core_create(). The free of the device occurs >> at ath10k_core_destroy(). >> >> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ >> >> Signed-off-by: Breno Leitao > > NAK this based upon the ath11k patch results. > > As suggested there we should just use kmalloc/kfree to match the existing logic. BTW if the patch is not tested on a real device then it's good to document that in the commit message with "Compile tested only" or similar. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches