Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp83908lqp; Wed, 20 Mar 2024 14:32:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXZq1jQjJjocQKCaeMcTa+p9vO3UaVPr30IIaMXd/5a2xcjIij44EiAuXpu5tFn4h7pKDLmWqAuqImK4EbvRmQ4IC4rDkVPZOkLNqjhRQ== X-Google-Smtp-Source: AGHT+IHP250BBHncPFL5MFRjhj33opPMPHziBFhKWSvKQS7i1j9zCWmDEPc+wDbxbTb8TvhlZCgT X-Received: by 2002:a05:6358:7f8e:b0:17e:b867:cb94 with SMTP id c14-20020a0563587f8e00b0017eb867cb94mr167023rwo.17.1710970368683; Wed, 20 Mar 2024 14:32:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710970368; cv=pass; d=google.com; s=arc-20160816; b=MeAaj9QD2ogYHu3mY05bvVZAZuxBcAmA/1oqXwzBW/g4NKN/W6hAOHhBVlo6bscRGf Q6OKepQYoIzuKNI5YuUz5f5WKGsGUw+1zIot8SxJDt9YxyfRjy62Vv+FsD8W8Bfc2I4c Y8mG03kOCzsloW1vCTJUqG41fBqwZcs5Rlmhp1vrkqzXXME6rKZ64U9UfK3bbsIDo2c5 stlGN3ptN/o1DvIKuRRoULmbGDIlMv9GvGbyW2HhMrtyEcEeJaqP0xq5Y5WCiTeC9FQ4 P60Rq83+oKq8EBQ7KFVMhqJX3ui/nU+ocjstDYaIBDW49YPNwGdGftaEdUpeBWulmmzf 1XPA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:organization:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=5/qA+Im9K+zVR3mz2/M2EFV779XQ897zE/KVyedbiy4=; fh=cP96cs9K3X2Q+lH/xjkrH8lK/6zZ8UeeH1/SHyTX/1g=; b=iJ9pr0COqrvk9+WBvINIRSRrrZ/biA/wkkkJ73vklhDkFNj3NEfah9wRveKMz8iBwg HjgpY8rX2BWrv/3/k1CEFcyYqaAsQziez9qA1iyZfprMm28yUuwugbsdw6TMd7fE6lmt 6Sst1pFmLPcSIAIS8NS5hCtC7EZjAVJYA5tPI8DB4D1+IPAJwVyV4/SfkDSIIVk0vYQc 15HpKQaW/IkGP6sGcjmyLo6dn/sdZTyqvRylPUfKKYmGOQX34SK/2YXXLtDn5UjfhVgl MwgV/JAiA9c1qm7fgKxspv/EYaoB+gjHY/4wIP00uogXt7cWyePi5YWC6mjGurFribVn TvIg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=daJ3RC11; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-wireless+bounces-5048-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5048-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id q22-20020a656a96000000b005cee9117ef6si13489522pgu.810.2024.03.20.14.32.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 14:32:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5048-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=daJ3RC11; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-wireless+bounces-5048-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5048-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 59AF7284BCA for ; Wed, 20 Mar 2024 21:27:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CFA748595A; Wed, 20 Mar 2024 21:27:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="daJ3RC11" X-Original-To: linux-wireless@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BA6985C46 for ; Wed, 20 Mar 2024 21:27:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710970021; cv=none; b=eUIIj11/XQchn+c3zvj2WguqiIQeh++zH1BMScXiO3WN3UsDSc/zbATdFHFKmF5+KYouy95/Fl0SQPFz7r9DgxI91n9f6zNb52/XT9Nn1oNvJPnQIJ6XGlKIhQD7RIucDd57346obLzAXfP80uv++SFPx1vmLMwAm2ytY0RGtbU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710970021; c=relaxed/simple; bh=4FCbGYFitIKkLyOeNfJiWXvDliIC1hijxy0WtQlr6Ys=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mZ7+xGlOs25AOXbyTCUI0ug190HOFnMvNRh1x0u1VLA/o+R3sqkvtjw8N0EXRg1Tv0nxWq0vIgZ47yBsugyZ+ujhdWAU7rtf9u6xdXFGwx/0S3tUSdSx+td44hou09QPc5zfSgZgYTLtXpEq78V/7eeGumHY/EsknNNhsNLX1Ak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=daJ3RC11; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710970020; x=1742506020; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4FCbGYFitIKkLyOeNfJiWXvDliIC1hijxy0WtQlr6Ys=; b=daJ3RC11Rj6HIp6bXqgL484re/tlk8x1gPUgeQP014wilpg/EkoReyNr zdpMQw2i+V6if9pLYgdNjJYVlEaLHD+MsvafyXxsYi1H6cdaqk80RYUG7 i10cANxSLl+SPE/UsYyOREiPr+GIVpe2VOzTBYk7PlJjQdFM+x5CzfLxf 6hzi+M+ZM5EAekmVuIzM9Na87mH+80bvwHMDuxaSleLgb74Uhiujfwxu4 ZHlzPiMza9Yiuhn/7JGThUUA6yIsVJ8omSFUlYE8M8XwzqUs9sxYRjS7/ 573hPsg1bVybu+JcMWhH/NC/+qAIRHoxh+8SRi0OX04fBhtLrXH6mK05H Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11019"; a="9698062" X-IronPort-AV: E=Sophos;i="6.07,141,1708416000"; d="scan'208";a="9698062" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2024 14:27:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,141,1708416000"; d="scan'208";a="14184128" Received: from unknown (HELO WEIS0040.iil.intel.com) ([10.12.217.108]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2024 14:26:58 -0700 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Benjamin Berg , Johannes Berg Subject: [PATCH 05/17] wifi: iwlwifi: mvm: mark EMLSR disabled in cleanup iterator Date: Wed, 20 Mar 2024 23:26:26 +0200 Message-Id: <20240320232419.71eb622d6ce3.Ic4d50695b9bb332190dc712473096083aa96074b@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240320212638.1446082-1-miriam.rachel.korenblit@intel.com> References: <20240320212638.1446082-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited Content-Transfer-Encoding: 8bit From: Benjamin Berg During HW restart only one link will be active initially and other links are only activated again later on. With only a single link EMLSR cannot be enabled and having it marked enabled confuses the internal state. Mark EMLSR as disabled in the cleanup iterator, it can be reenabled later one once this is possible. Signed-off-by: Benjamin Berg Reviewed-by: Johannes Berg Signed-off-by: Miri Korenblit --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c index 964871f31c73..448b43d73625 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c @@ -1108,6 +1108,9 @@ static void iwl_mvm_cleanup_iterator(void *data, u8 *mac, mvmvif->ba_enabled = false; mvmvif->ap_sta = NULL; + mvmvif->esr_active = false; + vif->driver_flags &= ~IEEE80211_VIF_EML_ACTIVE; + for_each_mvm_vif_valid_link(mvmvif, link_id) { mvmvif->link[link_id]->ap_sta_id = IWL_MVM_INVALID_STA; mvmvif->link[link_id]->fw_link_id = IWL_MVM_FW_LINK_ID_INVALID; -- 2.34.1