Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp105293lqp; Wed, 20 Mar 2024 15:18:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXR9RxSBr87HZr6mgmmjDMSM6YL0fZZINZT4BdcPIjB6bA/g8WpST7pWUoe69kFtnZSZWbvHvVOPww6FKp78AZUOe0JghUt7B9DyQjeDw== X-Google-Smtp-Source: AGHT+IHmyiUMkikS2VFMUznaWGRjLOMc+9X9MSE2FPekFAk27zfW5IqKtr8c/k/r9OmkWXVkb5Fm X-Received: by 2002:a05:6358:88d:b0:17e:6954:5750 with SMTP id m13-20020a056358088d00b0017e69545750mr3408125rwj.9.1710973127877; Wed, 20 Mar 2024 15:18:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710973127; cv=pass; d=google.com; s=arc-20160816; b=u4EW5WhmlJk3jgVXjIpG/14+UrxdeJ0Zvs6fgVhuElwqWLEklxVBLEJiExm04cn3Ha 3eEFpUMxbwXBp/f8P9klZKrHXtHFVuanyAummleezLJay/M8KaMYwFlgN3Rks+g9FR2/ kCNTNZ4WgvAW0ZVhuJoYFnuqyZjww1bKBq52/z2pTAbPEkOhN8DHbchDxzqJPYVTbxh0 Eyq7NLaAdG/uAH4bP5EKm4pVmN3aryOM2nA93PDbyd91WOhXk5t4MBDDOyE3kq9JcwHG 3F530w+ymRe/N05gfURlepGwj6BlChA+/BMdT54a4iyl5g0GOgph5h/4CwNAgL4aGtow KRMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:organization:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=FqhfX6/6dBZCBevLIXJ/wuZhCreJzTPBgt6QxEU5hdU=; fh=TquNsOiV+zNY1csTpltVB6A9QFW5SbuNs6JlqcKCQkw=; b=Ybe9FSnsb8gpzXZaweHzoFYG0ofWQtyYS8zsFbqNeLl4iwEtNJ57YkuF27jrAb58Nv eJp3KCwJcWRKrZ2WxZQEZ5WgfnFBD/L/vUeVy1SD/bceNlQk//+l8/JWRlbN56Bt+2h7 SOZ0LcT6DmOLulnL7qp6iDkgM3IipyRYT/+G/r9wJi4lPrbbz26SYo9luEtjXSc5S16a q4r3CBN4ufFkLj2n1Hf9gFpyMkRRzQ66tU6cL983KpK9/KqvqqFJLhfSuzrodAU1If9+ ln7Hg4e3WeY40Wu+NcrVZf0TGBwFxhe44/iPi42s3Wn2vocyCYYwvPvzog/oMHlh+N+Q CMRg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=oBcwark6; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-wireless+bounces-5059-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5059-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id z17-20020a63c051000000b005dc8a171689si13482298pgi.411.2024.03.20.15.18.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 15:18:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5059-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=oBcwark6; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-wireless+bounces-5059-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5059-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8D22C286146 for ; Wed, 20 Mar 2024 21:28:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3AF6D86128; Wed, 20 Mar 2024 21:27:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="oBcwark6" X-Original-To: linux-wireless@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF4C785C6A for ; Wed, 20 Mar 2024 21:27:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710970045; cv=none; b=qmCMP692pFUggvBW44UT/NE5MV53ICQHi8nF5mBW8ithI+uyNb2zLabmzYTikElCzIKj0BLbM1cUBRMIG6OM4LUYWK8OOrynW5ik/o4+AaPDQyCRVkDJZR1hDGvZphvcODvlg7NrijIJWaHbQF+vJtM3ovKLabHSDnjFEsQSZ1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710970045; c=relaxed/simple; bh=sb/MrSc7f5j4XJm/TkdNyCKfNQxLIBe0XYBQZI4Sksk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Rzenf0JfhwsyHrIXffwAW75Vc2WIchdbLHmvGV8R86rybxJVkgOIG3Lt03neU3Gvd3byGk9Lj2inFDQ1qTp8pC+svzw4J7YwJArrQ62sG67DqL7dyn5bAUIMt4i/maT9CdQgOKf0tEwwPVX2u5sLk0YlNdJ/B9RPtmnU91v6x+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=oBcwark6; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710970043; x=1742506043; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=sb/MrSc7f5j4XJm/TkdNyCKfNQxLIBe0XYBQZI4Sksk=; b=oBcwark63Ddp0tunC6NYaVhyV/HuYTn5UltKTv5vwaFjscrWDhibmgLJ raavyzgvWYxNRyNOdMIISyGiBsC1xypGD9kduOnPbWU773YA98J/DxfyQ 9iseNxTjFnvVxE44RU4GGZVz+Q7+cfTn1ezU2emsklPsO5NSZri4D46Ri AAbp/H84EPrBrYAvv6sC8jKH0BHaIlk0xa7v1Yx/AqQqcthPiO/fz8AWV wmKGMQRx8/7969WEdzT3C5IrkIAfqnnKOCHwDuGUC6sM2nTgf3QNrSyeL +XgxMttV1xWPa2FNgIkyN91njUgcbMZ0T7gG4hK9hpSfDOHfMNPsBGh9A Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11019"; a="9698153" X-IronPort-AV: E=Sophos;i="6.07,141,1708416000"; d="scan'208";a="9698153" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2024 14:27:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,141,1708416000"; d="scan'208";a="14184209" Received: from unknown (HELO WEIS0040.iil.intel.com) ([10.12.217.108]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2024 14:27:22 -0700 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Johannes Berg Subject: [PATCH 16/17] wifi: iwlwifi: mvm: don't change BA sessions during restart Date: Wed, 20 Mar 2024 23:26:37 +0200 Message-Id: <20240320232419.70ba08540db0.Ic604d384e660c755308a49a79d3f7e78bc27597c@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240320212638.1446082-1-miriam.rachel.korenblit@intel.com> References: <20240320212638.1446082-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited Content-Transfer-Encoding: 8bit From: Johannes Berg During restart, we haven't added BA sessions, so we also cannot change them to switch between links when that happens in restart. Short-circuit the appropriate function. Signed-off-by: Johannes Berg Signed-off-by: Miri Korenblit --- drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c index 5785b70a4aff..a1c00099cadb 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c @@ -989,6 +989,10 @@ static int iwl_mvm_mld_update_sta_baids(struct iwl_mvm *mvm, u32 cmd_id = WIDE_ID(DATA_PATH_GROUP, RX_BAID_ALLOCATION_CONFIG_CMD); int baid; + /* mac80211 will remove sessions later, but we ignore all that */ + if (test_bit(IWL_MVM_STATUS_IN_HW_RESTART, &mvm->status)) + return 0; + BUILD_BUG_ON(sizeof(struct iwl_rx_baid_cfg_resp) != sizeof(baid)); for (baid = 0; baid < ARRAY_SIZE(mvm->baid_map); baid++) { -- 2.34.1