Received-SPF: pass (google.com: domain of linux-wireless+bounces-5092-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 21 Mar 2024 07:26:13 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Breno Leitao <leitao@debian.org>, Kalle Valo <kvalo@kernel.org>, Jeff
 Johnson <jjohnson@kernel.org>, keescook@chromium.org, "open list:NETWORKING
 DRIVERS (WIRELESS)" <linux-wireless@vger.kernel.org>, "open list:QUALCOMM
 ATHEROS ATH11K WIRELESS DRIVER" <ath11k@lists.infradead.org>, open list
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath11k: allocate dummy net_device dynamically
Message-ID: <20240321072613.67466168@kernel.org>
In-Reply-To: <a44f21e3-1773-4b56-b1f0-c03a6462a7c1@gmail.com>
References: <20240319185735.1268980-1-leitao@debian.org>
	<a44f21e3-1773-4b56-b1f0-c03a6462a7c1@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 20 Mar 2024 07:05:42 -0700 Florian Fainelli wrote:
> > @@ -533,8 +534,11 @@ static int ath11k_ahb_config_ext_irq(struct ath11k_base *ab)
> >   
> >   		irq_grp->ab = ab;
> >   		irq_grp->grp_id = i;
> > -		init_dummy_netdev(&irq_grp->napi_ndev);
> > -		netif_napi_add(&irq_grp->napi_ndev, &irq_grp->napi,
> > +		irq_grp->napi_ndev = alloc_netdev(0, "dummy", NET_NAME_UNKNOWN,
> > +						  init_dummy_netdev);  
> 
> Is not this going to be a problem with multiple network device drivers 
> loaded in a given system and all using "dummy" here? While 
> NET_NAME_UNKNOWN ensures that this is not exposed to user-space, there 
> is still this part of alloc_netdev_mqs() which is going to be non-unique:
> 
>          ref_tracker_dir_init(&dev->refcnt_tracker, 128, name);

Names are allocated are registration time, I think, so basically all
devices will get an non-uniquely named ref tracker dir. For ethernet
it will be unconverted "eth%d". The name only shows up in some prints,
AFAICT, so not very important?