Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp497359lqp; Thu, 21 Mar 2024 07:29:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXsM8T2wHTf3eFGg3GQly5r0y5m0eiTd1+WS4DvUzlO2yMTy0tTzixvXJNpQ/iTM/Zj7t1vGCesVBi14sa5e1v3t4pv0nvtZYNB0ycj5g== X-Google-Smtp-Source: AGHT+IExAa/NKD9ROIFiMvQ3pL2ANGepn2suallSxjQ3JtaRvJzDPSuuHMouW328UcKWBExOT2jA X-Received: by 2002:a17:90b:e93:b0:29c:750b:2e79 with SMTP id fv19-20020a17090b0e9300b0029c750b2e79mr2558021pjb.21.1711031360333; Thu, 21 Mar 2024 07:29:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711031360; cv=pass; d=google.com; s=arc-20160816; b=FwNWOHlZmYB6CGOVrUUrkK3dDgx7uNd+fN7TcW/qd9n0xp0RyPeVPvsIXP6IdE7deQ M1MiywVtp2I/NNeTDSRSQHSbGYAXJmMsOuija4Uo2RCq4O6c7I0bU9NRvvdxfrecItd2 r5cj+ShMCr/kynlnlFhYmARLqLlnI7VKXk/4e2CwKi3EQvUiYGysZoKJ8kz4nU5wGAWK YPqd2zM+vn+ehKsWwozbfIOM6e75n4mQSA1o4kS8g836R+azs7c24OylIHGHG7CND403 OeiwTH4k4vPyG5B+wCO6QANYkorkefMtHEFnjYyKKO8VFbz3LK8QV40CXWGlFwgVHVeV p3WQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=pH2prGeFdJHwwa2fwQUUxFRLlz1GTq7varQulC5JgdY=; fh=78aS6OSbQca+AmLri7x7TjGL6CS3tiUzr5vx0S9bN/A=; b=BEzTrwmsHIVuCLHzXksvn1U3BktBREOGxDB+DNh8dx0ef/0/dzBL8exEBaD2HiI+5u gOKEhf5hrHDI8ZeV7eNeFpOo8avA81YXgd/gP5B+KOhuVmxDkHQ6f08ts7CRKXtZRrPo K96zmvH38YCP5Ier+EUngXO6AgppPJcEpfNctfRf3vlRVBwPwa1L4N0IsXqAF53ijMxX aNbC9K9LecbZdwywq1dampRh8XY9S23D+HwTvYr43hjuoWXVJ/SXdfF94bZOBTfPUGwc leI6uPzUht+GSke1syhv1xroWDmB3L3Kvg+LOLYLvX9CZz+cvDDJgTzgCF02ujnEMhZT MFVQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SpxN06Lp; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5093-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5093-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ob2-20020a17090b390200b002a01ca9fb02si1614458pjb.11.2024.03.21.07.29.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 07:29:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5093-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SpxN06Lp; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5093-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5093-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C9B99281722 for ; Thu, 21 Mar 2024 14:29:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5C83185937; Thu, 21 Mar 2024 14:28:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SpxN06Lp" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3339885279; Thu, 21 Mar 2024 14:28:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711031303; cv=none; b=Rz9YUc+q5bErlzlbFEYaR35HfUWG/J0cXkMVGLTegPBDDcCH0tvG+oIGk5M0YsNWAytCyCIUpFOlZZ8rK29+p3hVIsiGew9kQkmOG5uEOAOMNMhyGOWXAlU0L9NA79gtTKOPavyF0ttvOcfjUoWqB88M2V3nhPMokpxO+mpRrj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711031303; c=relaxed/simple; bh=pH2prGeFdJHwwa2fwQUUxFRLlz1GTq7varQulC5JgdY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=B8DHshr59EyVNQMuqoDXLvp2VcicAWl63RFCqmz+0YsAi2k6N/SDQz2y+qpfYlNvfYuiEn0q/4IcQVReUA1XNAfa4LG6Z+5z+v3HOJFqiksYgXynelgeepNvsJkR07lh4kkCwczFJ+dOPg82/ZvU8nRpL4zD+Q5nPvWRAJ5PpkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SpxN06Lp; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BDABC433F1; Thu, 21 Mar 2024 14:28:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711031303; bh=pH2prGeFdJHwwa2fwQUUxFRLlz1GTq7varQulC5JgdY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SpxN06LppfVgIhmcsu1LrlaPRuDknGG/5OjUT5Wu+HapT8qxkC8DGJ+6guCxsERy1 PXZpdK+Dm1USZIRFXud+clP1GT8QF72UPK7UfyHLkoAsFM24+lUacMN98ru+KSstF9 OYj9uf+ri6/KXrTMW/4glRlbmBr29nm06GuRCGKcXVApw5eNf4g8DJJoGK6qz+rAGv J3xCmoV3A/XHruiLd9xAyosdmPjSmq+ePeZs8x4N25ak1RxBXhnTE+xp94RQ8LYc9f 0LI5lyBQsTHoSzT0UOAl2NrNRpo9fzTVhGpL/H0FR3Wl/2Gv4YV9tpbUHAT9sjIENR tGTK4DbXeziKA== Date: Thu, 21 Mar 2024 07:28:21 -0700 From: Jakub Kicinski To: Jeff Johnson Cc: Breno Leitao , Kalle Valo , Jeff Johnson , , "open list:NETWORKING DRIVERS (WIRELESS)" , "open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER" , open list Subject: Re: [PATCH] ath10k: allocate dummy net_device dynamically Message-ID: <20240321072821.59f56757@kernel.org> In-Reply-To: <9fcdb857-da62-4832-ae11-043fe993e4ad@quicinc.com> References: <20240319104754.2535294-1-leitao@debian.org> <9fcdb857-da62-4832-ae11-043fe993e4ad@quicinc.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 20 Mar 2024 08:12:46 -0700 Jeff Johnson wrote: > NAK this based upon the ath11k patch results. The ath11 patch is much more complex, I'd wager this one is fine. > As suggested there we should just use kmalloc/kfree to match the existing logic. Please no. There is no magic here. alloc + free must match whether you're using magic object alloc wrapper (alloc_netdev()) or straight up kzalloc().