Received-SPF: pass (google.com: domain of linux-wireless+bounces-5095-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v2 2/3] wifi: b43: Convert sprintf/snprintf to sysfs_emit
From: Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20240315055211.1347548-2-lizhijian@fujitsu.com>
References: <20240315055211.1347548-2-lizhijian@fujitsu.com>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Li Zhijian <lizhijian@fujitsu.com>,
 Larry Finger <Larry.Finger@lwfinger.net>, linux-wireless@vger.kernel.org,
 b43-dev@lists.infradead.org
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <171103368135.103792.8592804467389574911.kvalo@kernel.org>
Date: Thu, 21 Mar 2024 15:08:02 +0000 (UTC)

Li Zhijian <lizhijian@fujitsu.com> wrote:

> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
> 
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
> 
> sprintf() will be converted as weel if they have.
> 
> Generally, this patch is generated by
> make coccicheck M=<path/to/file> MODE=patch \
> COCCI=scripts/coccinelle/api/device_attr_show.cocci
> 
> No functional change intended
> 
> CC: Larry Finger <Larry.Finger@lwfinger.net>
> CC: Kalle Valo <kvalo@kernel.org>
> CC: linux-wireless@vger.kernel.org
> CC: b43-dev@lists.infradead.org
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>

2 patches applied to wireless-next.git, thanks.

6db5c15c8b6a wifi: b43: Convert sprintf/snprintf to sysfs_emit
48be5774b21b wifi: ti: Convert sprintf/snprintf to sysfs_emit

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240315055211.1347548-2-lizhijian@fujitsu.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches