Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp551482lqp; Thu, 21 Mar 2024 08:40:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX/Y1D9jz4KOl8aAOLO8Hapkd0NeVqk/Iz0KCwZiMYmuGQGI26Lyq0sikIcQG7gYpaMARpSkRZCa47mli6dF0sJUPS0MaX1sIHZFgyzQQ== X-Google-Smtp-Source: AGHT+IHDZ1t3Hu1AbeC7xYcxZW4hUdrq866hfE7FF3MvPmY6JOFcvrN4Nt54qFc4ECvKzv0kANgc X-Received: by 2002:ac5:cccf:0:b0:4d4:b89:bd2a with SMTP id j15-20020ac5cccf000000b004d40b89bd2amr4928535vkn.3.1711035609250; Thu, 21 Mar 2024 08:40:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711035609; cv=pass; d=google.com; s=arc-20160816; b=FPcafIbZbSFCL53WAheOJNkHk0Zq6GdMW1+GmifwuRvtE5Tt9KeSYWuSjWCKd7QO3/ /zkRexS3ZmEbLpDfHCqmsX/V7dlQ6jbuwVdy4eZ+yAaj8xb6Zqt0ePn1q6q8zMFakQh+ ek7HKXLzOBqRac7FYJgMLV3RY7oe/3rVv3+N1gneLwOpqC7pac25FM1XdzoK5NBveyMF zFjE88CzmLzuSzCsmWG5NIfHyevNPaqEh2Zqts1EmoCPJErp/J30RbpqOvNcs62NypIt WVApAQCBHcajA+KQXp5+BWf/4YWMVuSY9SIFTbBaVmn81dJAgIVfLtVCPxgNzTB0IT16 dkFg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=WxIW9g4svG3b4T9Y97JK3vEMPqM6/1zJtRKF4q5G/Yg=; fh=OxKqZzwGDA7cb0IMVR6jHy9PHAac01hGigkxEPgCcAw=; b=WAcBCFxbtiWMo7yeq5VHCXUbrGr436Ejv3TqO4k9s7a8fz/gggTJ1vS1I5N7PwnwI4 6utMKfQQnZW9ECoWZsk5C3XIQPHXYZbwCcfhEKQxvursDchfC9g50X80Cvf/LnO0V9J7 DoVaTDo8jWxwLsOFQrRa2QVdu58i1cjCQq0DjbzpdS0H1kWMziW7kEXpWZe8AgI0r/IJ rMYk2ejC7Xx2OExF/5eyalzlxmTuj5BLZeuRJ7kiyO6VgOPIvBgOrFwKVpUaKZp8D+LX 1IUunytJDt4LCS5q0wwG6UElQUfILn4NevYLkPZ6UWnb4MMxm8MBnasIOnJErEEcsWUM G1lg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p6MfFBfN; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5099-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5099-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id b13-20020ac5c74d000000b004bd7aab05c7si33872vkn.118.2024.03.21.08.40.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 08:40:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5099-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p6MfFBfN; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5099-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5099-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E49901C21895 for ; Thu, 21 Mar 2024 15:40:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 47AB486ACD; Thu, 21 Mar 2024 15:34:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p6MfFBfN" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23E4086AC6 for ; Thu, 21 Mar 2024 15:34:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711035280; cv=none; b=f/fvKbok0MtqkYhDA4ceQKvq4rN6/Oe0U13vmg678xN+uMLbvyr9VF53Qk0iV0SKQkmvvSNZIgtpRIrwFzFH4IjLMIWPh6GXLUFQE8NuDX5w0KfodrDnMD3HFHEw73uxRhvjBHtyS0nHX9OMqmzEro4AWh5kByHFmP2JxQBSv+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711035280; c=relaxed/simple; bh=MAHUPtYjdGc+9hQjJoAj0zR0wpCQp51B1j0aTAHtuuk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=FPs5QPVd26QbJjQkblGr1h2gaQpEh2CNt/kL+4BiEz/RsfHutl11K0nY2EvkcZdiL+o/vofC4WbSYqLy4HvTXU+LkLEtuzHm48syDM30wFRe5A3ImWYw9amfFS4v3X+1SBIdv8R7xD6c8ST0iZhzpOoJyPyzJZnX0/8VJkU+4cY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p6MfFBfN; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2A86C43390; Thu, 21 Mar 2024 15:34:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711035279; bh=MAHUPtYjdGc+9hQjJoAj0zR0wpCQp51B1j0aTAHtuuk=; h=From:To:Cc:Subject:Date:From; b=p6MfFBfNAdVwWojjb/eAHspZ3SudeVqtYjKy2IJM//3Y4TaljCJiIN3dyDbzm5csw H733ilr46+ch7QFNladD/6F3GOoCRM9yCSkc2iPKdrq1SEhSW802aDHh/caSYYMPbV zTMtiSU/jJXRzOy9xdvwqjnLQEehuLhu9uvx46p1mRK4KsfXfIp0Q6uWKXuBCa8buH OkI/Ih3hYT/B03wOfZj/GVBgRfm27ItaLSMHEnLUnLHaxopqsvOackgQMRfGE/88lk b9tEIBch+dlUOZoxYmA9hP3/mrxhIWDjEOzm6tKTKucK6j0ej6ekrIO1KSJ1XPuiME qXZ/aDsAcjShQ== From: Kalle Valo To: nbd@nbd.name, lorenzo.bianconi@redhat.com Cc: linux-wireless@vger.kernel.org Subject: [PATCH] wifi: mt76: mt7915: workaround dubious x | !y warning Date: Thu, 21 Mar 2024 17:34:37 +0200 Message-Id: <20240321153437.403259-1-kvalo@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sparse warns: drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:526:9: warning: dubious: x | !y Workaround it by using the '?' operator. Compile tested only. Signed-off-by: Kalle Valo --- drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c index 450f4d221184..3f47aafb1a6c 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c @@ -523,7 +523,7 @@ mt7915_fw_debug_wm_set(void *data, u64 val) /* WM CPU info record control */ mt76_clear(dev, MT_CPU_UTIL_CTRL, BIT(0)); - mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | !dev->fw.debug_wm); + mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | dev->fw.debug_wm ? 0 : BIT(0)); mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_MASK_CLR_ADDR, BIT(5)); mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_SOFT_ADDR, BIT(5)); base-commit: 61cdb09ff760dd32439cde1200a1a8bd208807cd -- 2.39.2