Received-SPF: pass (google.com: domain of linux-wireless+bounces-5100-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <06508917-f7a0-4ea7-b9da-eb392da9171f@green-communications.fr>
Date: Thu, 21 Mar 2024 16:51:07 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] wifi: mt76: mt7915: workaround dubious x | !y warning
Content-Language: en-US
To: Kalle Valo <kvalo@kernel.org>, nbd@nbd.name, lorenzo.bianconi@redhat.com
Cc: linux-wireless@vger.kernel.org
References: <20240321153437.403259-1-kvalo@kernel.org>
From: Nicolas Cavallari <Nicolas.Cavallari@green-communications.fr>
In-Reply-To: <20240321153437.403259-1-kvalo@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:UhyT2iIthC0=;pEMw45oHqDO3EA1YwRCD4n5L0/D
 xaVx0XGv8GFD7zoRY6Bej2/YZ82TmGrIQRAb4YEFpG8O4+xC05Hr3vS94MbyAWOKpviz812gW
 pKvO+hi2QFWaQCCfr2BKvtHAUSRdpNwRlrlLzlTTjke+Nkf6Mv/fHyToy7mhy80Q4vMqKm5uH
 KjfRv7TgBK8va4Ix9nViEc8FLslNITKqco5AY4EsnP7ihn9NKBiV0jPZ13LnOiu9FrYJFEWdK
 6Oh273RKkg4jPDRrslw2Ejjh9tnSgjSDdgDGFpK2nlFfnrsG2Jqm2VbFq9lqzpM/PW7GhqKJ5
 +L/3Akoa37Mc27b2bhdc8n7sg3k19Y9bLE7CvgHlLGfC7RIby4K+tmMghiXVyG40ldS/Dek0r
 wY7UCLMRouoEzcBbwdFr+ri0xaFRPVJYN/rvVzWWcPqZF94h1XLzv8U+8LpTlb1p4oq441B3Y
 7Rrq/SiAgt4rsd2SIr/xz97Z76xBHRHUjqfWWEF3Rkd/50RytC6VOIxgErIwnZtPB+bzMg8NN
 XsusxjrmdW8/1xioyyERGQmKii06sc8SOpz+d2TEO38/7//RBmmz5/OfXene3eE+dUinyzVwr
 lpKbdq4m3Vo266/JyNW1IHRemzW790hw9tH0Kan0wgbQuSz57q4BS+QqvryI5rc4dvIyr4/Xm
 lFrBE4OAnFY/udmxzlKyMellSWLFEQXCDTQNhcwRb2swBUWm3UfWpxlaSNlSvd+J6E+mEJivA
 0IGUYlebbTA33NlBLJ62JVyxtcRdrdSV953oi7PDr2EtXV+z7slJ9M=

On 21/03/2024 16:34, Kalle Valo wrote:
> Sparse warns:
> 
> drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:526:9: warning: dubious: x | !y
> 
> Workaround it by using the '?' operator. Compile tested only.
> 
> Signed-off-by: Kalle Valo <kvalo@kernel.org>
> ---
>   drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
> index 450f4d221184..3f47aafb1a6c 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
> @@ -523,7 +523,7 @@ mt7915_fw_debug_wm_set(void *data, u64 val)
>   
>   	/* WM CPU info record control */
>   	mt76_clear(dev, MT_CPU_UTIL_CTRL, BIT(0));
> -	mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | !dev->fw.debug_wm);
> +	mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | dev->fw.debug_wm ? 0 : BIT(0));

clang says "bitwise or with non-zero value always evaluates to true 
[-Wtautological-bitwise-compare]"

It needs some parenthesis.