Received-SPF: pass (google.com: domain of linux-wireless+bounces-5103-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Kalle Valo <kvalo@kernel.org>
To: Nicolas Cavallari <Nicolas.Cavallari@green-communications.fr>
Cc: nbd@nbd.name,  lorenzo.bianconi@redhat.com,  linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: mt76: mt7915: workaround dubious x | !y warning
References: <20240321153437.403259-1-kvalo@kernel.org>
	<06508917-f7a0-4ea7-b9da-eb392da9171f@green-communications.fr>
Date: Thu, 21 Mar 2024 18:52:55 +0200
In-Reply-To: <06508917-f7a0-4ea7-b9da-eb392da9171f@green-communications.fr>
	(Nicolas Cavallari's message of "Thu, 21 Mar 2024 16:51:07 +0100")
Message-ID: <8734sja5nc.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Nicolas Cavallari <Nicolas.Cavallari@green-communications.fr> writes:

> On 21/03/2024 16:34, Kalle Valo wrote:
>> Sparse warns:
>> drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:526:9: warning:
>> dubious: x | !y
>> Workaround it by using the '?' operator. Compile tested only.
>> Signed-off-by: Kalle Valo <kvalo@kernel.org>
>> ---
>>   drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
>> b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
>> index 450f4d221184..3f47aafb1a6c 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
>> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
>> @@ -523,7 +523,7 @@ mt7915_fw_debug_wm_set(void *data, u64 val)
>>     	/* WM CPU info record control */
>>   	mt76_clear(dev, MT_CPU_UTIL_CTRL, BIT(0));
>> -	mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | !dev->fw.debug_wm);
>> +	mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | dev->fw.debug_wm ? 0 : BIT(0));
>
> clang says "bitwise or with non-zero value always evaluates to true
> [-Wtautological-bitwise-compare]"
>
> It needs some parenthesis.

Thanks, I'll send v2.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches