Received-SPF: pass (google.com: domain of linux-wireless+bounces-5142-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
CC: Ping-Ke Shih <pkshih@realtek.com>,
        Larry Finger
	<Larry.Finger@lwfinger.net>,
        Stefan Lippers-Hollmann <s.l-h@gmx.de>,
        Christian Hewitt <chewitt@libreelec.tv>
Subject: Re: [PATCH v3 01/12] wifi: rtlwifi: rtl8192de: Fix 5 GHz TX power
References: <7f4b3309-1580-48f3-9426-29f1eb4052fd@gmail.com> 
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain
Message-ID: <e85ff026-b264-41bf-addf-d9da178f3cc5@RTEXMBS04.realtek.com.tw>
Date: Fri, 22 Mar 2024 14:13:51 +0800

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

> Different channels have different TX power settings. rtl8192de is using
> the TX power setting from the wrong channel in the 5 GHz band because
> _rtl92c_phy_get_rightchnlplace expects an array which includes all the
> channel numbers, but it's using an array which includes only the 5 GHz
> channel numbers.
> 
> Use the array channel_all (defined in rtl8192de/phy.c) instead of
> the incorrect channel5g (defined in core.c).
> 
> Tested only with rtl8192du, which will use the same TX power code.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

I have reviewed this patchset. Set patchset state to Changes Requested.

[v3,01/12] wifi: rtlwifi: rtl8192de: Fix 5 GHz TX power
[v3,02/12] wifi: rtlwifi: Move code from rtl8192de to rtl8192d-common
[v3,03/12] wifi: rtlwifi: Adjust rtl8192d-common for USB
[v3,04/12] wifi: rtlwifi: Add rtl8192du/table.{c,h}
[v3,05/12] wifi: rtlwifi: Add rtl8192du/hw.{c,h}
[v3,06/12] wifi: rtlwifi: Add rtl8192du/phy.{c,h}
[v3,07/12] wifi: rtlwifi: Add rtl8192du/trx.{c,h}
[v3,08/12] wifi: rtlwifi: Add rtl8192du/rf.{c,h}
[v3,09/12] wifi: rtlwifi: Add rtl8192du/fw.{c,h} and rtl8192du/led.{c,h}
[v3,10/12] wifi: rtlwifi: Add rtl8192du/dm.{c,h}
[v3,11/12] wifi: rtlwifi: Add rtl8192du/sw.{c,h}
[v3,12/12] wifi: rtlwifi: Enable the new rtl8192du driver

---
https://github.com/pkshih/rtw.git