Received-SPF: pass (google.com: domain of linux-wireless+bounces-5170-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f690a1f8-09f8-a27c-e1be-fc6c76ea3456@quicinc.com>
Date: Mon, 25 Mar 2024 12:21:47 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v2]wifi: ath12k: Add firmware coredump collection support
Content-Language: en-US
To: Johannes Berg <johannes@sipsolutions.net>
CC: <linux-wireless@vger.kernel.org>, <ath12k@lists.infradead.org>
References: <20240322054231.467152-1-quic_ssreeela@quicinc.com>
 <bec0c3f9220c5084f163a39355499bcc7a32da36.camel@sipsolutions.net>
From: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
In-Reply-To: <bec0c3f9220c5084f163a39355499bcc7a32da36.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 3/22/2024 9:32 PM, Johannes Berg wrote:
> On Fri, 2024-03-22 at 11:12 +0530, Sowmiya Sree Elavalagan wrote:
>>
>> +config ATH12K_COREDUMP
>> +	bool "ath12k coredump"
>> +	depends on ATH12K
>> +	select WANT_DEV_COREDUMP
>> +	help
>> +	  Enable ath12k coredump collection
>> +
>> +	  If unsure, say Y to make it easier to debug problems. But if
>> +	  you want optimal performance choose N.
> 
> Why would having the hooks to dump affect performance? Surely you don't
> expect to be doing it much?
> 
> Also I'm impressed - 55MB seems like a lot :)
> 
> johannes
> 

Hi Johannes,

As per the current design it shouldn't affect performance, here we collect the dump and queue the work of uploading using a work queue and trigger core restart. But according to earlier design we postpone the core restart until the dump has been uploaded.  I will remove the statement on performance impact in my next version.
 
Firmware team requires all the memory regions to be dumped for easier debugging. This holds 55 MB only in case of high memory profile ( >= 1 GB). We haven't enabled any other low memory profile in upstream.

Thanks,
Sowmiya Sree