Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2705126lqp; Mon, 25 Mar 2024 07:09:10 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVjE0KlY+8tbbgJrx00SU89oprlDZlSk/ZLU5MQpbBDxZ6U1Sna7rlVGYvTOz/gsQriX0b3HnafCcQWsPZpVRzCNxyv7rHilFd5vxrMDA== X-Google-Smtp-Source: AGHT+IF8ye+oprPJ1lDFph6fi0Ux+koB6+z2/cWGxfhE3OGoscbgpWs1lPoWfoN3Ufsl4PME75aX X-Received: by 2002:ac8:5c84:0:b0:430:df57:d503 with SMTP id r4-20020ac85c84000000b00430df57d503mr8903153qta.9.1711375750518; Mon, 25 Mar 2024 07:09:10 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711375750; cv=pass; d=google.com; s=arc-20160816; b=YqaRBj7x0KjZoXk/8Jzr6EcLCxxH1ITEpfiQhsrV2xrshMd41n5Bf5SbqFMWPW4uc0 P1GRfUtcX93jEG7k3pVfs76D8pUFVRMQxn0vycRlP16xKdWJg53h0FRFTk4ouV3LwWIw Zs0EFZ8WUhd2rHMGlwzSVA1Q5Ygr3xkmCtg2Zl2LWlRMbcVmvWgh5O/hiMVyMtcqRzLS 6E3eX8onOzzm2QrA5Bz4xks/ZPi71MRK2Tk3jUEUlnc/44klhWxDL3Bl3wHFXSgwMxqa JA5UjpWO9r5BDGTouagLDU2R97oqHFB+PL7tjQgaBB/tchRwfJOGZu/i2IhwVGfPXTOs pTeg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:to :from:subject:message-id:dkim-signature; bh=6pijbRLvBqblq1qEKDSEGAclPOx1WC5er47SvIapkY8=; fh=jhPR+caUlMTPlT3etFPMoXI2bIxyoNSlrnAQfkynx3A=; b=XSMP680N+RqWABy126y0it03arLijktmq3skh8HtDxHJe4mJYM+sNPeENHoMAuryMw ARgTEZwj+l8fzWsIl2bKcZJZWITub0Xcy6Akq35dUp0COs3utXxlPRhLOkScobSji5Ih yjwXB0eh2pCOZmtZs/w7UrUrPW61sP2IOAJhOaL69AdmWzPH0M7tw0TlbnwDnKTL4IRA D5/38Xf1m8YjBaNG8N2jfem42U7oJTFxLEqfc3tz71qrPoatW8RIECgYAy/SOwu/ZhjC f0mVYEz4NUKTyIFX2JmYxpPrYIUGmLgRqsdUHRgCh5bbl44D2ZnbazP05Mm1r2c7R4qA z/sg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b="YuU/EZbM"; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-5172-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5172-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id ge5-20020a05622a5c8500b0043136512ebbsi5889872qtb.445.2024.03.25.07.09.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 07:09:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5172-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b="YuU/EZbM"; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-5172-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5172-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 773251C39ED6 for ; Mon, 25 Mar 2024 14:09:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE1A5148823; Mon, 25 Mar 2024 10:42:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="YuU/EZbM" X-Original-To: linux-wireless@vger.kernel.org Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EC241869D3 for ; Mon, 25 Mar 2024 09:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711360043; cv=none; b=Zz900bV57ouboRHwPrE84KHFa146rrDBBljqYYiuM0zynbAXzfrzc1Eyrca+3abYdJkA4+NV8mOifdthe8bp4Qq0tAQh0t6rq618fNBfdrvljFg+LvzYiPkGAVYnCTLeE4PYAIxMUwPHDZFwZ40REpL7FXFU7BAh/rplZiugZi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711360043; c=relaxed/simple; bh=6pijbRLvBqblq1qEKDSEGAclPOx1WC5er47SvIapkY8=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=mr6ZfvFqMLZz4BS3iot1TtixNke6ECjHH9SIbkcOioaTYxGDViwxeYwF4zpruPaw2rMuccsrF25uhkxjjnc3qafYngNqk8P+187bMZmVohKY4L38q5WI25czd4lLOiNSeJ6byd9l3HAe4XssIxC9LwLTrKNOXdUxJeasWlH4FyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=YuU/EZbM; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=6pijbRLvBqblq1qEKDSEGAclPOx1WC5er47SvIapkY8=; t=1711360040; x=1712569640; b=YuU/EZbMyHTY9Gr2cjSQNcTJCy+flYkc/OA88xc08lMNtNV 3SDtPUh6qoNBMw48m9OuQNsK7WvkmzRAnRG5X7r0R4cfQRsB1MYR9+0BHk3VlGW+yzxvr2oxbWFAB w2nMhs6Ti9GHFMcHEv0oJh7SV168S6d7AI84AF5g+E3D5sFUpKUpcYj6pwXO74zboyn8vaOtxJNU8 aV/vVMn25DZZgmCW1/jR3v/RFsVYMMYkT8RCnWKGgbI87wPidp4dDuMfKRmZw4WTrfbeUL+5048+g UzA/DTRdZNr7bZ/NSI/jq+jWJdmoSDhA5HmCn098p+NkjIeSwyCZlZa4eZ3dUQcw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1rogv9-0000000Djgl-2Iou; Mon, 25 Mar 2024 10:47:11 +0100 Message-ID: <661c532c30e9fa218cf0b3d30da0bb65aafc4e8c.camel@sipsolutions.net> Subject: Re: Access to ieee80211_conn_settings in the driver? From: Johannes Berg To: Ben Greear , "linux-wireless@vger.kernel.org" Date: Mon, 25 Mar 2024 10:47:10 +0100 In-Reply-To: <1df701f9-3f27-4887-a9ed-60cf2f12beb4@candelatech.com> References: <1df701f9-3f27-4887-a9ed-60cf2f12beb4@candelatech.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned Hi Ben > I'm interested in getting access to ieee80211_conn_settings > struct in drivers. My first instinct here is to say no. This thing was only introduced recently, and it was ... difficult ... to do. I don't even want to imagine I'd have had to worry about a whole bunch of drivers using it for random purposes as well. > Specifically, so I can deal with disabling > 160Mhz in mt76 even if peer is 160Mhz for instance, on a per-station vdev= basis. Not sure how that even makes sense? You have the min_def in the chandef though, so you could do some bandwidth tricks there for AP side? > Actually, 160Mhz is bad example, but in case I want to pass other > association config info into the driver, like disabling as much of > OFDMA or MU-MIMO as possible. No idea what that means ... I mean I guess we could add somewhere (bss_conf?) a flag indicating "things" are needed, e.g. if you're connecting 160 MHz is it VHT or HE or EHT, to set things accordingly? > Is this of general interest, and if so, any suggestions for you > you'd like to see it implemented? I'd like to _not_ see it implemented :) johannes