Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2733795lqp; Mon, 25 Mar 2024 07:52:19 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX3vrsXhFuMP1VLyv8G1ejhb1deO2MmO5k44Vn46WzxaxQ629rAc5AB4VFijHPkY3pyKDRrGdXgp2QKlZ8N7Sz4rY12BPVzZDoc53Zbhw== X-Google-Smtp-Source: AGHT+IFi8Iyvl3DSK7/hzy29PqUzVVgO/3VhC1REjE27ODAHUurnTWrzQBtPRn8TRLgKDrnqIMvX X-Received: by 2002:a17:902:7005:b0:1e0:b60e:1a1c with SMTP id y5-20020a170902700500b001e0b60e1a1cmr80780plk.65.1711378339115; Mon, 25 Mar 2024 07:52:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711378339; cv=pass; d=google.com; s=arc-20160816; b=Ifh58IiLw+wcYxGSQ3mwwxK0Ger84+kyDWcxpbUxElUTxjMbxPJwTZXl5VgGlV78o4 RZ/PLkTenEtkFWEMLxd7PWM8gyP0UkaOpYgwtpc+/k61m8zLWnYeW2rrtU9B9QgOQYfK MH0GmietUFAIkNwjSCxMMLhcqym802RVC3NyWXgVVG5wQN/15G+coNp2H1reMxrug0To pRWlemlKnENwPfrCRXuUgMopOqeV+y+WsuGelw/0JOh7GIVbUZWBS1TCKq3JHgN54rRu F//NoGjJl5hYKl9rFMnoHbsQrxcHyAiZ9KMQqWQJnFbBIHhNd+5YVYg7Cy6Vvlfl1kEp 79DQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=miAacLjcFM/MuBLQKhoRbJAkx32oI9Z/KRait6Gwm4I=; fh=mYVW8HGAQz4BjSnG9wHLIPZibqvyMUGRQJL7ODSzGtg=; b=XDGs9oOM9oBDCXHJs07L+LaPDbZ05AhhPWST5hkfLG31L90vkiSOrjXAnRRJf1Vjul iiK6PEMIn74fLV/CwMfES56+MS39tUdOS6/EMkqNtcXviOcAx86sp5515TtNEPNhBwfZ qbGc/+KU1P2pImqiEYN0/I8kOuHJt9vEmrTBTwBzuSrBgKIug0oLF4x/C3GBgxqfQZG/ RF9EaSXDGuRRqm4AakpiUKEqeMd/p5hi0Xs5QxXWBF4c1QXXE4cklgrNmFpn86cckpVF 0phWJ2Hi8Z33Jt7sGv9PZ+1HjNx9+/vXTvI2JAH3FlKwmlFe429fJWtMe5OT4T6rOCJp wL4g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bIpOvCvI; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5176-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5176-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id ma13-20020a170903094d00b001e0c567bb5dsi1554711plb.425.2024.03.25.07.52.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 07:52:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5176-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bIpOvCvI; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5176-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5176-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5EF9C2C646F for ; Mon, 25 Mar 2024 14:43:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 29445137934; Mon, 25 Mar 2024 11:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bIpOvCvI" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50D5112CD9B for ; Mon, 25 Mar 2024 10:51:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711363912; cv=none; b=CsIV6RaNnl3d/IWLFtX0G+2JpmmBzLIRKQwT9zUNX0gaRIhlyX5cHK2Ici+xdan5l4RGqg5o1dRnSIt0jz/bi6bN7CRYKZaI+6zSYjHA0U4QlAQ+mGZSsWgpimt1MjAKfgZHWDgQ2ievYIvOXy7a9rUv+8NHBsQ5rojBpZRAR4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711363912; c=relaxed/simple; bh=lp35e7eS4CY1qdkvmPWtokuA6SAAw4yzmHLeOHp1kLI=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=o1+0WkAAxieLTBvVG5yFpIQ79lDoz1HM8blAvpKKeMcYi+DICeI+bwvWrD3EboweRpo0pWU1rSLaVOKRymVmN3OLH5MumSHWNF1B81QlRMjOdu+jWGdWEy19Q+07L5D3HXSWbAyHWaEfOiOBE8BBsdBx7qclK3mG68EQYDWQ2PI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bIpOvCvI; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21203C433C7; Mon, 25 Mar 2024 10:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711363911; bh=lp35e7eS4CY1qdkvmPWtokuA6SAAw4yzmHLeOHp1kLI=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=bIpOvCvIh06zMFKHw9i88lUgm12dkPjeXndvEQy6VsJbg0C7bs4J8Zki/a4I/yD5J 35w5BC6F5pd71LayK8ybCa2UPzIOTZbFucDAe1Wim+LU+kM8e/OHI+6Q8i9GIrCWzg eK43BJiJubHwlff6rtMAVgul90mfBOf0wEze/TD6nxf/y/FVr3ttHu7H2DyGPY0a4R tccj6tlFP+ryLKkp0N+nDlFjrOlXAw8L3Fw2sKMJUkQ7YQ3jRUIqFRS+dlf7ZPLUr9 5TGnSFF4BAxEbhX4hzkkjNtHSrQo6xskSqSn47M4K0YbPNVtxSuWIMhNznHA/1LGgU aExLjX85Isb0A== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH 1/3] wifi: ath9k: ath9k_set_moredata(): fix sparse warnings From: Kalle Valo In-Reply-To: <20240320170656.3534265-2-kvalo@kernel.org> References: <20240320170656.3534265-2-kvalo@kernel.org> To: Kalle Valo Cc: toke@toke.dk, linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171136390925.1022746.16408802632389269104.kvalo@kernel.org> Date: Mon, 25 Mar 2024 10:51:50 +0000 (UTC) Kalle Valo wrote: > Sparse warns: > > drivers/net/wireless/ath/ath9k/xmit.c:1677:20: warning: incorrect type in initializer (different base types) > drivers/net/wireless/ath/ath9k/xmit.c:1677:20: expected unsigned short [usertype] mask > drivers/net/wireless/ath/ath9k/xmit.c:1677:20: got restricted __le16 [usertype] > drivers/net/wireless/ath/ath9k/xmit.c:1681:17: warning: restricted __le16 degrades to integer > drivers/net/wireless/ath/ath9k/xmit.c:1682:42: warning: restricted __le16 degrades to integer > drivers/net/wireless/ath/ath9k/xmit.c:1682:36: warning: incorrect type in assignment (different base types) > drivers/net/wireless/ath/ath9k/xmit.c:1682:36: expected restricted __le16 [usertype] frame_control > drivers/net/wireless/ath/ath9k/xmit.c:1682:36: got int > > Fix ath9k_set_moredata() to use __le16 with masks and use if statement instead > of multiply operator. > > Compile tested only. > > Signed-off-by: Kalle Valo > Acked-by: Jeff Johnson > Acked-by: Toke Høiland-Jørgensen 3 patches applied to ath-next branch of ath.git, thanks. e5f6c85ac16f wifi: ath9k: ath9k_set_moredata(): fix sparse warnings a854028e7bd8 wifi: ath9k: fix ath9k_use_msi declaration f09e3b774fe8 wifi: ath9k: eeprom: fix sparse endian warnings -- https://patchwork.kernel.org/project/linux-wireless/patch/20240320170656.3534265-2-kvalo@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches