Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2798161lqp; Mon, 25 Mar 2024 09:27:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXUTcb8JhCU/M+C9zOxfDvc5LUZErjLAbJTg1UMW7u3j3IB47ySEQlJUu9OTZQu70BBWh4DvVJKQ1k/gU65pUZWvNouLgX9e+jhhawFrQ== X-Google-Smtp-Source: AGHT+IHgMU0YvTtljqYHAkYaH2Dn5hyjgjlqhqiYfwY3ZN6u8eiqlHwKRLdVAF1CvyqWdOKu4PNY X-Received: by 2002:a17:907:ea2:b0:a46:ea3c:72ab with SMTP id ho34-20020a1709070ea200b00a46ea3c72abmr7080048ejc.74.1711384048138; Mon, 25 Mar 2024 09:27:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711384048; cv=pass; d=google.com; s=arc-20160816; b=EmO4tTua5a0pnszU1HfoWJh+PEyrr2RsVJPWzWZ4H/ypodo+rEBam9Af5PmTAAo3CS 5y1D0xZ+/oUu+DLc23sz5A/ND2Y38fIUHeigTNgAiZ1Uvu6fLHVi2D/TxUaZ2sVt0YWG OC8UoB6ePof6mwA4lG/jyW6vv+TFTInb1G4C1/P84Sym1Y0RpAMGV3W3T408OMpGB9Pw lhl9eWDNneOeOTDOF0bLOglwSCZ37EmoOsvVfF7sRa6ltzg03ijG2S+fHxvKWWn7l9YV 8CCPFTpllXSwC62M5XAnl5N8EfZQLBRjUtLlCP7mr6CvhcLE8QjC14Usx5Z7/RMXZaOl LLjg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id:dkim-signature; bh=SBbUL15zjlK6CBiHDHkylojz2BS2Xhc/F/dz7Eh30wY=; fh=/wDthGfc2X4h8DNxX11w6QtjZ1A9wRkwwJ3fRJge8YQ=; b=PHOrLLXWp3P1xUymj7D16MAIo2PQLQwrty5miS6mv91pnKfHyhyNDL0BWVN9LKcqQH rkGC68OLA5melne0ij9d9nzUoLfIaOH6mKfcLZ+fdkXVef0aSbWFvCnv1HkqaeKFmfXy 1ONkrobSa0a32bLLbeDXEL8NOc6OQbCnJNrDUOcu+4zUuzQz9OL0j44WmDGDlixoIptr HcQKcZKoKGmGof2Qu9qqVH8nKNTLi4X0g573MJcrg6CTBkU83mvZyvM9TAIaoQPewVfc Cvm9DC2AVnic4c0w/rCxDN4i6F3Z8aZuWtRXMvn5MfrMfXv8w0Z0f6xSLmBrmA4RpMRw sUgw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=rWp4NeTC; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-5199-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5199-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id bt7-20020a170906b14700b00a46caa13e60si2538276ejb.476.2024.03.25.09.27.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 09:27:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5199-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=rWp4NeTC; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-5199-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5199-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 904351F3F8A8 for ; Mon, 25 Mar 2024 16:26:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 35BD26E616; Mon, 25 Mar 2024 14:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="rWp4NeTC" X-Original-To: linux-wireless@vger.kernel.org Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A083E128377 for ; Mon, 25 Mar 2024 14:27:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711376865; cv=none; b=kMnpLHz1OBBHQQXeP/qIPWtSQuzCAgb5NM5XR0bM5n1Gu+0f5f0+thD4oMb136tBF4v5DwMudZcm2SuKMlVVi+Y9ppzABUdyhjYlJPLgFDltVWtKx4RcPh8RlKKcZSNKoq0bjkK4qcT1oVk6tWmSQ6PZ/LQDc8el5vacaoknUsQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711376865; c=relaxed/simple; bh=PSQZ+Ozdu8cQPLJxQXrDn9n6O7TZmAyAIkZ18i1ub1o=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=I0krzM2QiIX2poz5ylr0LmqNHq4hUWw4+XRUwjUK2n/CvxejtSwZCQ5do9wxYSZd8uS7IFVpAaCpdsJGhBZerkZKxFQ7jOKtKgF6ff3zwrdPQPIt0rKRL7P4R6ijrrAeU5iGeP4vj+IG4Tjhdk+ektYuwrKjPGIUXwy+r1BlTlI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=rWp4NeTC; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=SBbUL15zjlK6CBiHDHkylojz2BS2Xhc/F/dz7Eh30wY=; t=1711376862; x=1712586462; b=rWp4NeTC33cj4VoHh6Pv3xe29pvfObAEhYm6PlmGZp90Tms cnAbwFx8lz38cDoJ0gMqx0cthSXJPjO7pNXGduCW63oRbkURhpyDUDNY4lMO81eIJZTFNR+OxEIHo uOV7n/kszbYjQihK1c/7OHW8ZOl6Vkwu+v8wM2wssxQp4gR2lGVphw8DfQVPbjB8GUn+3iJWdjC2w BH1idrLY1ZJXjqUMZf8Rj8fxPcmEBA3V+zQEFAKHQ6QZqWga+gW4SuRElvhleqUlKcXeQXILmyapX P6NYMmccVlYiP1I4bRGR1EbOE1XxoVae92CEqJENBkiSdUztjKT//QB00xHJ/2kw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1rolIZ-0000000DsNl-3zfs; Mon, 25 Mar 2024 15:27:40 +0100 Message-ID: Subject: Re: [PATCH 15/17] wifi: iwlwifi: mvm: select STA mask only for active links From: Johannes Berg To: Miri Korenblit Cc: linux-wireless@vger.kernel.org Date: Mon, 25 Mar 2024 15:27:39 +0100 In-Reply-To: <20240320232419.c6818d1c6033.I6357f05c55ef111002ddc169287eb356ca0c1b21@changeid> References: <20240320212638.1446082-1-miriam.rachel.korenblit@intel.com> <20240320232419.c6818d1c6033.I6357f05c55ef111002ddc169287eb356ca0c1b21@changeid> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Wed, 2024-03-20 at 23:26 +0200, Miri Korenblit wrote: >=20 > - link_sta =3D > + mvm_link_sta =3D > rcu_dereference_check(mvmsta->link[link_id], > lockdep_is_held(&mvm->mutex)); > if (!link_sta) > continue; >=20 I forgot to adjust this condition, and as we found out, that will be needed during link switch :) I'll fix that when I apply it. johannes