Received-SPF: pass (google.com: domain of linux-wireless+bounces-5208-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <9c9e1297e2548b363fc93e774c8546e6ebf4efd6.camel@sipsolutions.net>
Subject: Re: kunit alltests runs broken in mainline
From: Johannes Berg <johannes@sipsolutions.net>
To: Mark Brown <broonie@kernel.org>, Brendan Higgins
 <brendanhiggins@google.com>,  David Gow <davidgow@google.com>, Rae Moar
 <rmoar@google.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, 
	kunit-dev@googlegroups.com, x86@kernel.org, linux-wireless@vger.kernel.org
Date: Mon, 25 Mar 2024 16:29:53 +0100
In-Reply-To: <b743a5ec-3d07-4747-85e0-2fb2ef69db7c@sirena.org.uk>
References: <b743a5ec-3d07-4747-85e0-2fb2ef69db7c@sirena.org.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-03-25 at 15:21 +0000, Mark Brown wrote:
> Hi,
>=20
> Commit 28b3df1fe6ba2cb4 ("kunit: add wireless unit tests") which I can't
> seem to find on lore breaks full kunit runs on non-UML builds and is now
> present in mainline.  If I run:
>=20
>    ./tools/testing/kunit/kunit.py run --alltests --cross_compile x86_64-l=
inux-gnu- --arch x86_64
>=20
> on a clean tree then I get:
>=20
>    [15:09:20] Configuring KUnit Kernel ...
>    Generating .config ...
>    Populating config with:
>    $ make ARCH=3Dx86_64 O=3D.kunit olddefconfig CROSS_COMPILE=3Dx86_64-li=
nux-gnu-
>    ERROR:root:Not all Kconfig options selected in kunitconfig were in the=
 generated .config.
>    This is probably due to unsatisfied dependencies.
>    Missing: CONFIG_IWLWIFI=3Dy, CONFIG_WLAN_VENDOR_INTEL=3Dy
>=20
> UML works fine, but other real architectures (eg, arm64) seem similarly
> broken.

Hmm, strange.

> I've not looked properly yet, I'm a bit confused given that
> there's not even any dependencies for WLAN_VENDOR_INTEL and it's not
> mentoned in the defconfig.

Well it's in the directory dependencies or something I think, this seems
to help:

--- a/tools/testing/kunit/configs/all_tests.config
+++ b/tools/testing/kunit/configs/all_tests.config
@@ -28,6 +28,8 @@ CONFIG_MCTP_FLOWS=3Dy
 CONFIG_INET=3Dy
 CONFIG_MPTCP=3Dy
=20
+CONFIG_NETDEVICES=3Dy
+CONFIG_WLAN=3Dy
 CONFIG_CFG80211=3Dy
 CONFIG_MAC80211=3Dy
 CONFIG_WLAN_VENDOR_INTEL=3Dy


But I'm not sure why ARCH=3Dum is different?

johannes